2023-09-21 01:33:33

by Brian Norris

[permalink] [raw]
Subject: Re: [PATCH] wifi: mwifiex: fix SDIO firmware dump wait

On Wed, Sep 20, 2023 at 02:22:32PM +0300, Dmitry Antipov wrote:
> In 'mwifiex_sdio_generic_fw_dump()', move (presumably placed
> by mistake) 'if (tries == MAX_POLL_TRIES)' check to an outer
> waiting loop.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Dmitry Antipov <[email protected]>

Have you tested this patch? You've certainly caught a logic bug, but
that doesn't mean the seemingly obvious solution actually works.

(Disclaimer: I haven't tested it.)