2024-06-12 13:11:41

by Sascha Hauer

Subject: Re: [PATCH v10 2/2] wifi: mwifiex: add host mlme for AP mode

Hi David,

On Thu, Apr 18, 2024 at 02:06:26PM +0800, David Lin wrote:
> Add host based MLME to enable WPA3 functionalities in AP mode.
> This feature required a firmware with the corresponding V2 Key API
> support. The feature (WPA3) is currently enabled and verified only
> on IW416. Also, verified no regression with change when host MLME
> is disabled.
>
> Signed-off-by: David Lin <[email protected]>
> Reviewed-by: Francesco Dolcini <[email protected]>
> ---
>

> diff --git a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> index 491e36611909..073c665183b3 100644
> --- a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> +++ b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> @@ -72,6 +72,10 @@ int mwifiex_set_secure_params(struct mwifiex_private *priv,
> bss_config->key_mgmt = KEY_MGMT_PSK;
> }
> break;
> + case WLAN_AKM_SUITE_SAE:
> + bss_config->protocol = PROTOCOL_WPA2;
> + bss_config->key_mgmt = KEY_MGMT_SAE;
> + break;

Shouldn't this be |= PROTOCOL_WPA2 and |= KEY_MGMT_SAE?
Clearing the other flags when SAE is enabled looks wrong to me.

Sascha

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2024-06-14 02:06:54

by David Lin

Subject: RE: [EXT] Re: [PATCH v10 2/2] wifi: mwifiex: add host mlme for AP mode

> From: Sascha Hauer <[email protected]>
> Sent: Wednesday, June 12, 2024 9:12 PM
> To: David Lin <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; Pete
> Hsieh <[email protected]>; Francesco Dolcini
> <[email protected]>
> Subject: [EXT] Re: [PATCH v10 2/2] wifi: mwifiex: add host mlme for AP mode
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> Hi David,
>
> On Thu, Apr 18, 2024 at 02:06:26PM +0800, David Lin wrote:
> > Add host based MLME to enable WPA3 functionalities in AP mode.
> > This feature required a firmware with the corresponding V2 Key API
> > support. The feature (WPA3) is currently enabled and verified only on
> > IW416. Also, verified no regression with change when host MLME is
> > disabled.
> >
> > Signed-off-by: David Lin <[email protected]>
> > Reviewed-by: Francesco Dolcini <[email protected]>
> > ---
> >
>
> > diff --git a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> > b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> > index 491e36611909..073c665183b3 100644
> > --- a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> > +++ b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> > @@ -72,6 +72,10 @@ int mwifiex_set_secure_params(struct
> mwifiex_private *priv,
> > bss_config->key_mgmt =
> KEY_MGMT_PSK;
> > }
> > break;
> > + case WLAN_AKM_SUITE_SAE:
> > + bss_config->protocol = PROTOCOL_WPA2;
> > + bss_config->key_mgmt = KEY_MGMT_SAE;
> > + break;
>
> Shouldn't this be |= PROTOCOL_WPA2 and |= KEY_MGMT_SAE?
> Clearing the other flags when SAE is enabled looks wrong to me.
>
> Sascha
>

These fields are used for the configuration of FW, this is the correct setting.

David