On Wed, 2024-06-12 at 20:51 +0200, Arend van Spriel wrote:
> Hi Johannes, Larry,
>
> I got a query from a brcmsmac user about support for WPA3. I had no idea
> what would be needed and actually assumed/hoped mac80211 would take care
> of it. My first attempt was looking in patchwork for other mac80211
> drivers adding WPA3 and found this one interesting enough:
>
> https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
>
> It only sets flag IEEE80211_HW_MFP_CAPABLE in hw->flags. So I suggested
> to do the same in brcmsmac. Unfortunately no success so can you think of
> anything else that would be required from brcmsmac.
You need the correct ciphers too (at least BIP, possibly GMAC)
johannes
On Wed, 2024-06-12 at 20:56 +0200, Johannes Berg wrote:
> On Wed, 2024-06-12 at 20:51 +0200, Arend van Spriel wrote:
> > Hi Johannes, Larry,
> >
> > I got a query from a brcmsmac user about support for WPA3. I had no idea
> > what would be needed and actually assumed/hoped mac80211 would take care
> > of it. My first attempt was looking in patchwork for other mac80211
> > drivers adding WPA3 and found this one interesting enough:
> >
> > https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
> >
> > It only sets flag IEEE80211_HW_MFP_CAPABLE in hw->flags. So I suggested
> > to do the same in brcmsmac. Unfortunately no success so can you think of
> > anything else that would be required from brcmsmac.
>
> You need the correct ciphers too (at least BIP, possibly GMAC)
No wait, you said brcmsmac, and it doesn't even have HW crypto?!
Then it seems like it should just work, does wpa_s have errors?
johannes
On June 12, 2024 9:08:11 PM Johannes Berg <[email protected]> wrote:
> On Wed, 2024-06-12 at 20:56 +0200, Johannes Berg wrote:
>> On Wed, 2024-06-12 at 20:51 +0200, Arend van Spriel wrote:
>>> Hi Johannes, Larry,
>>>
>>> I got a query from a brcmsmac user about support for WPA3. I had no idea
>>> what would be needed and actually assumed/hoped mac80211 would take care
>>> of it. My first attempt was looking in patchwork for other mac80211
>>> drivers adding WPA3 and found this one interesting enough:
>>>
>>> https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
>>>
>>> It only sets flag IEEE80211_HW_MFP_CAPABLE in hw->flags. So I suggested
>>> to do the same in brcmsmac. Unfortunately no success so can you think of
>>> anything else that would be required from brcmsmac.
>>
>> You need the correct ciphers too (at least BIP, possibly GMAC)
>
> No wait, you said brcmsmac, and it doesn't even have HW crypto?!
It probably has, but apparently we never implemented it.
> Then it seems like it should just work, does wpa_s have errors?
I am waiting for logs/sniffer captures.
Thanks,
Arend