John Stultz <[email protected]> writes:
> On Wed, Jun 13, 2018 at 8:13 AM, Ryan Grachek <[email protected]> wrote:
>> These properties are required for compatibility with runtime PM.
>> Without these properties, MMC host controller will not be aware
>> of power capabilities. When the wlcore driver attempts to power
>> on the device, it will erroneously fail with -EACCES.
>>
>> Signed-off-by: Ryan Grachek <[email protected]>
>
> Fixes: 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power")
> Tested-by: John Stultz <[email protected]>
> Acked-by: John Stultz <[email protected]>
>
> Wei Xu: This fixes a functional regression with wifi on the HiKey
> board that was introduced in 4.18-rc with commit 60f36637bbbd
> ("wlcore: sdio: allow pm to handle sdio power").
>
> Could you please be sure to queue this for the 4.18-rc ?
Adding linux-wireless so that wireless folks are aware of this wlcore
regression fix as well.
--
Kalle Valo
> >> These properties are required for compatibility with runtime PM.
> >> Without these properties, MMC host controller will not be aware
> >> of power capabilities. When the wlcore driver attempts to power
> >> on the device, it will erroneously fail with -EACCES.
> >>
> >> Signed-off-by: Ryan Grachek <[email protected]>
> >
> > Fixes: 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power")
> > Tested-by: John Stultz <[email protected]>
> > Acked-by: John Stultz <[email protected]>
> >
> > Wei Xu: This fixes a functional regression with wifi on the HiKey
> > board that was introduced in 4.18-rc with commit 60f36637bbbd
> > ("wlcore: sdio: allow pm to handle sdio power").
> >
> > Could you please be sure to queue this for the 4.18-rc ?
>=20
> Adding linux-wireless so that wireless folks are aware of this wlcore
> regression fix as well.
>=20
Actually "cap-power-off-card" is normally included with all .dts files sup=
porting wilink=20
So it should have been there from the start for this board as well.=20
It probably worked without it due to the explicit call to mmc_power_restore=
_host()
that was there as an old workaround for trying to control the power explici=
tly from the
driver which was actually causing other failures on suspend/resume as the m=
mc layer=20
already power the module on resume.
"keep-power-in-suspend" is needed in case of planning to use "WoWLAN":
Iw phy0 wowlan enable....
Best Regards,
Eyal