Hi Larry,
> -----Original Message-----
> From: Larry Finger <[email protected]>
> Sent: Tuesday, February 27, 2024 10:35 AM
> To: Kalle Valo <[email protected]>
> Cc: Johannes Berg <[email protected]>; [email protected]; Nick Morrow
> <[email protected]>; Larry Finger <[email protected]>; Ping-Ke Shih <[email protected]>;
> [email protected]
> Subject: [PATCHi V2] wifi: rtw88: Add missing VID/PIDs doe 8811CU and 8821CU
Not sure if "doe" is typo?
>
> From: Nick Morrow <[email protected]>
>
> Purpose: Add VID/PIDs that are known to be missing for this driver.
> - removed /* 8811CU */ and /* 8821CU */ as they are redundant
> since the file is specific to those chips.
> - removed /* TOTOLINK A650UA v3 */ as the manufacturer. It has a REALTEK
> VID so it may not be specific to this adapter.
>
> Source is
> https://1EHFQ.trk.elasticemail.com/tracking/click?d=I82H0YR_W_h175Lb3Nkb0D8i6IqvuhESe0WLnY6P7IVwR1UKvB
> 0SPxd1Olp3PNJEJTqsu4kyqBXayE0BVd_k7uLFvlTe65Syx2uqLUB-UQSfsKKLkuyE-frMZXSCL7q824UG3Oer614GGEeEz-DNEWHh
> 43p_e8oz7OouS6gRBEng0
> Verified and tested.
>
> Signed-off-by: Nick Morrow <[email protected]>
> Signed-off-by: Larry Finger <[email protected]>
> Acked-by: Ping-Ke Shih <[email protected]>
>
Did you keep a blank line intentionally?
> Cc: [email protected]
Ping-Ke Shih <[email protected]> writes:
> Hi Larry,
>
>> -----Original Message-----
>> From: Larry Finger <[email protected]>
>> Sent: Tuesday, February 27, 2024 10:35 AM
>> To: Kalle Valo <[email protected]>
>> Cc: Johannes Berg <[email protected]>; [email protected]; Nick Morrow
>> <[email protected]>; Larry Finger <[email protected]>; Ping-Ke Shih <[email protected]>;
>> [email protected]
>> Subject: [PATCHi V2] wifi: rtw88: Add missing VID/PIDs doe 8811CU and 8821CU
>
> Not sure if "doe" is typo?
I think it means "for" but Larry's finger was one key off to the left :) I can fix that.
>> From: Nick Morrow <[email protected]>
>>
>> Purpose: Add VID/PIDs that are known to be missing for this driver.
>> - removed /* 8811CU */ and /* 8821CU */ as they are redundant
>> since the file is specific to those chips.
>> - removed /* TOTOLINK A650UA v3 */ as the manufacturer. It has a REALTEK
>> VID so it may not be specific to this adapter.
>>
>> Source is
>> https://1EHFQ.trk.elasticemail.com/tracking/click?d=I82H0YR_W_h175Lb3Nkb0D8i6IqvuhESe0WLnY6P7IVwR1UKvB
>> 0SPxd1Olp3PNJEJTqsu4kyqBXayE0BVd_k7uLFvlTe65Syx2uqLUB-UQSfsKKLkuyE-frMZXSCL7q824UG3Oer614GGEeEz-DNEWHh
>> 43p_e8oz7OouS6gRBEng0
>> Verified and tested.
>>
>> Signed-off-by: Nick Morrow <[email protected]>
>> Signed-off-by: Larry Finger <[email protected]>
>> Acked-by: Ping-Ke Shih <[email protected]>
>>
>
> Did you keep a blank line intentionally?
I can fix this as well. I'll also move 'cc: stable' to the beginning of
tags.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
On 2/27/24 00:38, Kalle Valo wrote:
> Ping-Ke Shih <[email protected]> writes:
>
>> Hi Larry,
>>
>>> -----Original Message-----
>>> From: Larry Finger <[email protected]>
>>> Sent: Tuesday, February 27, 2024 10:35 AM
>>> To: Kalle Valo <[email protected]>
>>> Cc: Johannes Berg <[email protected]>; [email protected]; Nick Morrow
>>> <[email protected]>; Larry Finger <[email protected]>; Ping-Ke Shih <[email protected]>;
>>> [email protected]
>>> Subject: [PATCHi V2] wifi: rtw88: Add missing VID/PIDs doe 8811CU and 8821CU
>>
>> Not sure if "doe" is typo?
>
> I think it means "for" but Larry's finger was one key off to the left :) I can fix that.
>
>>> From: Nick Morrow <[email protected]>
>>>
>>> Purpose: Add VID/PIDs that are known to be missing for this driver.
>>> - removed /* 8811CU */ and /* 8821CU */ as they are redundant
>>> since the file is specific to those chips.
>>> - removed /* TOTOLINK A650UA v3 */ as the manufacturer. It has a REALTEK
>>> VID so it may not be specific to this adapter.
>>>
>>> Source is
>>> https://1EHFQ.trk.elasticemail.com/tracking/click?d=I82H0YR_W_h175Lb3Nkb0D8i6IqvuhESe0WLnY6P7IVwR1UKvB
>>> 0SPxd1Olp3PNJEJTqsu4kyqBXayE0BVd_k7uLFvlTe65Syx2uqLUB-UQSfsKKLkuyE-frMZXSCL7q824UG3Oer614GGEeEz-DNEWHh
>>> 43p_e8oz7OouS6gRBEng0
>>> Verified and tested.
>>>
>>> Signed-off-by: Nick Morrow <[email protected]>
>>> Signed-off-by: Larry Finger <[email protected]>
>>> Acked-by: Ping-Ke Shih <[email protected]>
>>>
>>
>> Did you keep a blank line intentionally?
>
> I can fix this as well. I'll also move 'cc: stable' to the beginning of
> tags.
>
Kalle,
Thanks for correcting my mistakes.
Larry