From: Deren Wu <[email protected]>
mt7921/mt7922 support HE max aggregation subframes 256 for both tx/rx.
Get better throughput then before.
Fixes: 94bb18b03d43 ("mt76: mt7921: fix max aggregation subframes setting")
Tested-by: Ming Yen Hsieh <[email protected]>
Reviewed-by: Sean Wang <[email protected]>
Signed-off-by: Deren Wu <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7921/init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
index 48a10aaecc62..7b4766ea55bc 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
@@ -52,8 +52,8 @@ mt7921_init_wiphy(struct ieee80211_hw *hw)
struct wiphy *wiphy = hw->wiphy;
hw->queues = 4;
- hw->max_rx_aggregation_subframes = 64;
- hw->max_tx_aggregation_subframes = 128;
+ hw->max_rx_aggregation_subframes = IEEE80211_MAX_AMPDU_BUF_HE;
+ hw->max_tx_aggregation_subframes = IEEE80211_MAX_AMPDU_BUF_HE;
hw->netdev_features = NETIF_F_RXCSUM;
hw->radiotap_timestamp.units_pos =
--
2.18.0
On 16.06.22 17:57, Deren Wu wrote:
> From: Deren Wu <[email protected]>
>
> mt7921/mt7922 support HE max aggregation subframes 256 for both tx/rx.
> Get better throughput then before.
>
> Fixes: 94bb18b03d43 ("mt76: mt7921: fix max aggregation subframes setting")
> Tested-by: Ming Yen Hsieh <[email protected]>
> Reviewed-by: Sean Wang <[email protected]>
> Signed-off-by: Deren Wu <[email protected]>
When I made the change that you're reverting here, I used the values
from the reference SDK that I got, and the change actually seemed to
improve performance in my tests.
Did something change in the firmware, or is there a related chipset
difference between 7921 and 7922?
- Felix
Hi Felix,
On Fri, 2022-06-17 at 10:39 +0200, Felix Fietkau wrote:
> On 16.06.22 17:57, Deren Wu wrote:
> > From: Deren Wu <[email protected]>
> >
> > mt7921/mt7922 support HE max aggregation subframes 256 for both
> > tx/rx.
> > Get better throughput then before.
> >
> > Fixes: 94bb18b03d43 ("mt76: mt7921: fix max aggregation subframes
> > setting")
> > Tested-by: Ming Yen Hsieh <[email protected]>
> > Reviewed-by: Sean Wang <[email protected]>
> > Signed-off-by: Deren Wu <[email protected]>
>
> When I made the change that you're reverting here, I used the values
> from the reference SDK that I got, and the change actually seemed to
> improve performance in my tests.
> Did something change in the firmware, or is there a related chipset
> difference between 7921 and 7922?
>
> - Felix
>
Yes, there was some fw changes ready in 2021 and the SDK was updated as
well. After some performance re-check, the test result is much better
with the new patch. We think the max-size-256 can be applied in
mt7921/mt7922 driver now.
PS: mt7921/mt7922 are the same. Both of them can support this size.
Thanks,
Deren