> -------- Forwarded Message --------
> Subject: Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
> Date: Fri, 19 Apr 2024 07:16:07 +0300
> From: Kalle Valo <[email protected]>
> To: Jeff Johnson <[email protected]>
> CC: [email protected], [email protected]
>
> Jeff Johnson <[email protected]> writes:
>
> > On 4/18/2024 9:20 AM, Kalle Valo wrote:
> >
> >> From: Kalle Valo <[email protected]>
> >>
> >> Through reading ACPI tables, implement Time-Average-SAR(TAS), BIOS
> >> SAR, configuration of CCA threshold and band edge channel power
> functionalities.
> >> This is enabled only on WCN7850.
> >>
> >> TODO:
> >>
> >> * test with ACPI support in hardware (I don't have such hardware),
> especially
> >> suspend and hibernation
>
> [...]
>
> > I can verify this doesn't crash my system, but apparently my ACPI
> > doesn't have the underlying settings, so cannot verify actual
> > functionality
>
> Thanks for testing. I hope Lingbo has a device with proper ACPI settings.
>
yes, I'll apply these patch then test it.
> > Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0:
> > acpi_evaluate_dsm() failed Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel:
> > ath12k_pci 0000:03:00.0: failed to get ACPI DSM data: -2 Apr 18
> > 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi
> > failed: -2
>
> I just want to verify that these are debug messages, right? Normal users
> shouldn't see any ACPI errors if there are no ACPI settings in the
system.
>
Let me check it.
Best regards
Lingbo Kong
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
>
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpat
> ches
On 2024/4/19 14:30, Lingbo Kong wrote:
> > -------- Forwarded Message --------
> > Subject: Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
> > Date: Fri, 19 Apr 2024 07:16:07 +0300
> > From: Kalle Valo <[email protected]>
> > To: Jeff Johnson <[email protected]>
> > CC: [email protected], [email protected]
> >
> > Jeff Johnson <[email protected]> writes:
> >
> > > On 4/18/2024 9:20 AM, Kalle Valo wrote:
> > >
> > >> From: Kalle Valo <[email protected]>
> > >>
> > >> Through reading ACPI tables, implement Time-Average-SAR(TAS), BIOS
> > >> SAR, configuration of CCA threshold and band edge channel power
> > functionalities.
> > >> This is enabled only on WCN7850.
> > >>
> > >> TODO:
> > >>
> > >> * test with ACPI support in hardware (I don't have such hardware),
> > especially
> > >> suspend and hibernation
> >
> > [...]
> >
> > > I can verify this doesn't crash my system, but apparently my ACPI
> > > doesn't have the underlying settings, so cannot verify actual
> > > functionality
> >
> > Thanks for testing. I hope Lingbo has a device with proper ACPI
> settings.
> >
>
> yes, I'll apply these patch then test it.
>
Hi, kalle, i've applied this patchset, set ACPI correctly, then ACPI's
functionality is right.
> > > Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0:
> > > acpi_evaluate_dsm() failed Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel:
> > > ath12k_pci 0000:03:00.0: failed to get ACPI DSM data: -2 Apr 18
> > > 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi
> > > failed: -2
> >
> > I just want to verify that these are debug messages, right? Normal users
> > shouldn't see any ACPI errors if there are no ACPI settings in the
> system.
> >
>
> Let me check it.
>
> Best regards
> Lingbo Kong
>
These messages belong to debug messages, normal users won't see any ACPI
errors if there are no ACPI settings in the system.
> > --
> > https://patchwork.kernel.org/project/linux-wireless/list/
> >
> >
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpat
> > ches
>
Lingbo Kong <[email protected]> writes:
> On 2024/4/19 14:30, Lingbo Kong wrote:
>> > -------- Forwarded Message --------
>> > Subject: Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
>> > Date: Fri, 19 Apr 2024 07:16:07 +0300
>> > From: Kalle Valo <[email protected]>
>> > To: Jeff Johnson <[email protected]>
>> > CC: [email protected], [email protected]
>> >
>> > Jeff Johnson <[email protected]> writes:
>> >
>> > > On 4/18/2024 9:20 AM, Kalle Valo wrote:
>> > >
>> > >> From: Kalle Valo <[email protected]>
>> > >>
>> > >> Through reading ACPI tables, implement Time-Average-SAR(TAS), BIOS
>> > >> SAR, configuration of CCA threshold and band edge channel power
>> > functionalities.
>> > >> This is enabled only on WCN7850.
>> > >>
>> > >> TODO:
>> > >>
>> > >> * test with ACPI support in hardware (I don't have such hardware),
>> > especially
>> > >> suspend and hibernation
>> >
>> > [...]
>> >
>> > > I can verify this doesn't crash my system, but apparently my ACPI
>> > > doesn't have the underlying settings, so cannot verify actual
>> > > functionality
>> >
>> > Thanks for testing. I hope Lingbo has a device with proper ACPI
>> settings.
>> >
>> yes, I'll apply these patch then test it.
>>
>
> Hi, kalle, i've applied this patchset, set ACPI correctly, then ACPI's
> functionality is right.
Nice, thanks for testing.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches