2009-01-27 03:42:26

by Jason Andryuk

[permalink] [raw]
Subject: p54usb and 2.13.24.0 Firmware fail to probe 1st generation (ISL3886 + net2280)

Device is ID 2001:3701 D-Link Corp. [hex] DWL-G120 Spinnaker 802.11b

With firmware 2.13.24.0.lm86.arm, the probe fails:

Jan 26 22:24:26 rainbow kernel: [ 153.217044] usb 5-2: new high speed
USB device using ehci_hcd and address 3
Jan 26 22:24:26 rainbow kernel: [ 153.349788] usb 5-2: configuration
#1 chosen from 1 choice
Jan 26 22:24:26 rainbow kernel: [ 153.350045] usb 5-2: firmware:
requesting isl3886usb
Jan 26 22:24:26 rainbow kernel: [ 153.357700] phy2: p54 detected a
LM86 firmware
Jan 26 22:24:26 rainbow kernel: [ 153.357706] p54: rx_mtu reduced
from 3240 to 2392
Jan 26 22:24:26 rainbow kernel: [ 153.357711] phy2: FW rev 2.13.24.0
- Softmac protocol 5.9
Jan 26 22:24:26 rainbow kernel: [ 153.357716] phy2: cryptographic
accelerator WEP:YES, TKIP:YES, CCMP:YES
Jan 26 22:24:28 rainbow kernel: [ 155.552234] p54usb: probe of
5-2:1.0 failed with error -110
Jan 26 22:24:48 rainbow kernel: [ 174.879425] usb 5-2: USB
disconnect, address 3

Change firmware to 2.13.1.0.arm.0 and it succeeds:

Jan 26 22:24:50 rainbow kernel: [ 177.316145] usb 5-2: new high speed
USB device using ehci_hcd and address 4
Jan 26 22:24:50 rainbow kernel: [ 177.448722] usb 5-2: configuration
#1 chosen from 1 choice
Jan 26 22:24:50 rainbow kernel: [ 177.448935] usb 5-2: firmware:
requesting isl3886usb
Jan 26 22:24:50 rainbow kernel: [ 177.485489] phy3: p54 detected a
LM86 firmware
Jan 26 22:24:50 rainbow kernel: [ 177.485496] p54: rx_mtu reduced
from 3240 to 2392
Jan 26 22:24:50 rainbow kernel: [ 177.485501] phy3: FW rev 2.13.1.0 -
Softmac protocol 5.5
Jan 26 22:24:50 rainbow kernel: [ 177.485506] phy3: cryptographic
accelerator WEP:YES, TKIP:YES, CCMP:YES
Jan 26 22:24:52 rainbow kernel: [ 179.392096] phy3: hwaddr
00:15:e9:12:3f:65, MAC:isl3886 RF:Frisbee
Jan 26 22:24:52 rainbow kernel: [ 179.400242] wmaster0 (p54usb): not
using net_device_ops yet
Jan 26 22:24:52 rainbow kernel: [ 179.401500] phy3: Selected rate
control algorithm 'minstrel'
Jan 26 22:24:52 rainbow kernel: [ 179.401592] wlan0 (p54usb): not
using net_device_ops yet
Jan 26 22:24:52 rainbow kernel: [ 179.421574] udev: renamed network
interface wlan0 to wlan2
Jan 26 22:24:56 rainbow kernel: [ 183.486290] ADDRCONF(NETDEV_UP):
wlan2: link is not ready
Jan 26 22:24:57 rainbow kernel: [ 184.181337] wlan2: authenticate
with AP 00:30:bd:c0:90:24
Jan 26 22:24:57 rainbow kernel: [ 184.190363] wlan2: authenticated
Jan 26 22:24:57 rainbow kernel: [ 184.190370] wlan2: associate with
AP 00:30:bd:c0:90:24
Jan 26 22:24:57 rainbow kernel: [ 184.193885] wlan2: RX AssocResp
from 00:30:bd:c0:90:24 (capab=0x1 status=0 aid=8)
Jan 26 22:24:57 rainbow kernel: [ 184.193892] wlan2: associated
Jan 26 22:24:57 rainbow kernel: [ 184.194510] wlan2: disassociating
by local choice (reason=3)
Jan 26 22:25:03 rainbow kernel: [ 189.870792] wlan2: authenticate
with AP 00:30:bd:c0:90:24
Jan 26 22:25:03 rainbow kernel: [ 189.875492] wlan2: authenticated
Jan 26 22:25:03 rainbow kernel: [ 189.875498] wlan2: associate with
AP 00:30:bd:c0:90:24
Jan 26 22:25:03 rainbow kernel: [ 189.878367] wlan2: RX AssocResp
from 00:30:bd:c0:90:24 (capab=0x1 status=0 aid=8)
Jan 26 22:25:03 rainbow kernel: [ 189.878374] wlan2: associated
Jan 26 22:25:03 rainbow kernel: [ 189.883084]
ADDRCONF(NETDEV_CHANGE): wlan2: link becomes ready
Jan 26 22:25:13 rainbow kernel: [ 200.460142] wlan2: no IPv6 routers present

This message is went with the older 2.13.1.0 firmware.

Jason


2009-01-28 00:10:08

by Jason Andryuk

[permalink] [raw]
Subject: Re: p54usb and 2.13.24.0 Firmware fail to probe 1st generation (ISL3886 + net2280)

With the below patch, -ETIMEDOUT is returned from usb_interrupt_msg in
addition to alen != sizeof(__le32)

[ 53.876103] usb 4-2: new high speed USB device using ehci_hcd and address 2
[ 54.008792] usb 4-2: configuration #1 chosen from 1 choice
[ 54.131230] usb 4-2: firmware: requesting isl3886usb
[ 54.148759] phy1: p54 detected a LM86 firmware
[ 54.148765] p54: rx_mtu reduced from 3240 to 2392
[ 54.148770] phy1: FW rev 2.13.24.0 - Softmac protocol 5.9
[ 54.148775] phy1: cryptographic accelerator WEP:YES, TKIP:YES, CCMP:YES
[ 56.316196] usb 4-2: (p54usb) err=-110, alen=0, size=4
[ 56.316311] p54usb: probe of 4-2:1.0 failed with error -110
[ 56.316356] usbcore: registered new interface driver p54usb

diff --git a/drivers/net/wireless/p54/p54usb.c b/drivers/net/wireless/p54/p54usb
index 9539ddc..3e26085 100644
--- a/drivers/net/wireless/p54/p54usb.c
+++ b/drivers/net/wireless/p54/p54usb.c
@@ -652,6 +652,7 @@ static int p54u_upload_firmware_net2280(struct ieee80211_hw

err = p54_parse_firmware(dev, fw_entry);
if (err) {
+ dev_err(&priv->udev->dev, "(p54usb) cannot parse firmware\n");
kfree(buf);
release_firmware(fw_entry);
return err;
@@ -858,8 +859,11 @@ static int p54u_upload_firmware_net2280(struct ieee80211_hw
err = usb_interrupt_msg(priv->udev,
usb_rcvbulkpipe(priv->udev, P54U_PIPE_INT),
buf, sizeof(__le32), &alen, 1000);
- if (err || alen != sizeof(__le32))
+ if (err || alen != sizeof(__le32)) {
+ dev_err(&priv->udev->dev, "(p54usb) err=%d, alen=%d, size=%d\n",
+ err, alen, sizeof(__le32));
goto fail;
+ }

P54U_READ(NET2280_DEV_U32, &devreg->int_ident);
P54U_WRITE(NET2280_DEV_U32, &devreg->int_ack, reg);

2009-01-28 02:53:34

by Artur Skawina

[permalink] [raw]
Subject: Re: p54usb and 2.13.24.0 Firmware fail to probe 1st generation (ISL3886 + net2280)

Jason Andryuk wrote:
> On Tue, Jan 27, 2009 at 7:10 PM, Jason Andryuk <[email protected]> wrote:
>> With the below patch, -ETIMEDOUT is returned from usb_interrupt_msg in
>> addition to alen != sizeof(__le32)
>>
>> [ 53.876103] usb 4-2: new high speed USB device using ehci_hcd and address 2
>> [ 54.008792] usb 4-2: configuration #1 chosen from 1 choice
>> [ 54.131230] usb 4-2: firmware: requesting isl3886usb
>> [ 54.148759] phy1: p54 detected a LM86 firmware
>> [ 54.148765] p54: rx_mtu reduced from 3240 to 2392
>> [ 54.148770] phy1: FW rev 2.13.24.0 - Softmac protocol 5.9
>> [ 54.148775] phy1: cryptographic accelerator WEP:YES, TKIP:YES, CCMP:YES
>> [ 56.316196] usb 4-2: (p54usb) err=-110, alen=0, size=4
>> [ 56.316311] p54usb: probe of 4-2:1.0 failed with error -110
>> [ 56.316356] usbcore: registered new interface driver p54usb

> Increasing the timeout to 9000 still results in -ETIMEDOUT. Could the
> firmware just be incompatible with the device?

i'm seeing the same w/ another 1st gen device (t-sinus 154data), so likely yes.

[from an older post]
> Tried the newer fw, but it does not seem to like my hw:
>
> usb 1-1.1: new full speed USB device using uhci_hcd and address 6
> usb 1-1.1: New USB device found, idVendor=0846, idProduct=4200
> usb 1-1.1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
> usb 1-1.1: configuration #1 chosen from 1 choice
> usb 1-1.1: firmware: requesting isl3886usb
> phy1: p54 detected a LM86 firmware
> p54: rx_mtu reduced from 3240 to 2392
> phy1: FW rev 2.13.24.0 - Softmac protocol 5.9
> phy1: cryptographic accelerator WEP:YES, TKIP:YES, CCMP:YES
> p54usb: probe of 1-1.1:1.0 failed with error -110
>
> Last one working is:
>
> usb 1-1.1: new full speed USB device using uhci_hcd and address 5
> usb 1-1.1: New USB device found, idVendor=0846, idProduct=4200
> usb 1-1.1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
> usb 1-1.1: configuration #1 chosen from 1 choice
> usb 1-1.1: firmware: requesting isl3886usb
> phy0: p54 detected a LM86 firmware
> p54: rx_mtu reduced from 3240 to 2392
> phy0: FW rev 2.13.1.0 - Softmac protocol 5.5
> phy0: cryptographic accelerator WEP:YES, TKIP:YES, CCMP:YES
> phy0: hwaddr 00:30:12:34:45:67, MAC:isl3886 RF:Frisbee
> wmaster0 (p54usb): not using net_device_ops yet
> phy0: Selected rate control algorithm 'minstrel'
> wlan0 (p54usb): not using net_device_ops yet
> mon.ap0 (p54usb): not using net_device_ops yet

artur


2009-01-27 03:44:38

by Jason Andryuk

[permalink] [raw]
Subject: Re: p54usb and 2.13.24.0 Firmware fail to probe 1st generation (ISL3886 + net2280)

Oh yeah, this is with wireless-testing master-2009-01-26 and master-2009-01-23.

Jason

On Mon, Jan 26, 2009 at 10:42 PM, Jason Andryuk <[email protected]> wrote:
> Device is ID 2001:3701 D-Link Corp. [hex] DWL-G120 Spinnaker 802.11b
>
> With firmware 2.13.24.0.lm86.arm, the probe fails:
>
> Jan 26 22:24:26 rainbow kernel: [ 153.217044] usb 5-2: new high speed
> USB device using ehci_hcd and address 3
> Jan 26 22:24:26 rainbow kernel: [ 153.349788] usb 5-2: configuration
> #1 chosen from 1 choice
> Jan 26 22:24:26 rainbow kernel: [ 153.350045] usb 5-2: firmware:
> requesting isl3886usb
> Jan 26 22:24:26 rainbow kernel: [ 153.357700] phy2: p54 detected a
> LM86 firmware
> Jan 26 22:24:26 rainbow kernel: [ 153.357706] p54: rx_mtu reduced
> from 3240 to 2392
> Jan 26 22:24:26 rainbow kernel: [ 153.357711] phy2: FW rev 2.13.24.0
> - Softmac protocol 5.9
> Jan 26 22:24:26 rainbow kernel: [ 153.357716] phy2: cryptographic
> accelerator WEP:YES, TKIP:YES, CCMP:YES
> Jan 26 22:24:28 rainbow kernel: [ 155.552234] p54usb: probe of
> 5-2:1.0 failed with error -110
> Jan 26 22:24:48 rainbow kernel: [ 174.879425] usb 5-2: USB
> disconnect, address 3
>
> Change firmware to 2.13.1.0.arm.0 and it succeeds:
>
> Jan 26 22:24:50 rainbow kernel: [ 177.316145] usb 5-2: new high speed
> USB device using ehci_hcd and address 4
> Jan 26 22:24:50 rainbow kernel: [ 177.448722] usb 5-2: configuration
> #1 chosen from 1 choice
> Jan 26 22:24:50 rainbow kernel: [ 177.448935] usb 5-2: firmware:
> requesting isl3886usb
> Jan 26 22:24:50 rainbow kernel: [ 177.485489] phy3: p54 detected a
> LM86 firmware
> Jan 26 22:24:50 rainbow kernel: [ 177.485496] p54: rx_mtu reduced
> from 3240 to 2392
> Jan 26 22:24:50 rainbow kernel: [ 177.485501] phy3: FW rev 2.13.1.0 -
> Softmac protocol 5.5
> Jan 26 22:24:50 rainbow kernel: [ 177.485506] phy3: cryptographic
> accelerator WEP:YES, TKIP:YES, CCMP:YES
> Jan 26 22:24:52 rainbow kernel: [ 179.392096] phy3: hwaddr
> 00:15:e9:12:3f:65, MAC:isl3886 RF:Frisbee
> Jan 26 22:24:52 rainbow kernel: [ 179.400242] wmaster0 (p54usb): not
> using net_device_ops yet
> Jan 26 22:24:52 rainbow kernel: [ 179.401500] phy3: Selected rate
> control algorithm 'minstrel'
> Jan 26 22:24:52 rainbow kernel: [ 179.401592] wlan0 (p54usb): not
> using net_device_ops yet
> Jan 26 22:24:52 rainbow kernel: [ 179.421574] udev: renamed network
> interface wlan0 to wlan2
> Jan 26 22:24:56 rainbow kernel: [ 183.486290] ADDRCONF(NETDEV_UP):
> wlan2: link is not ready
> Jan 26 22:24:57 rainbow kernel: [ 184.181337] wlan2: authenticate
> with AP 00:30:bd:c0:90:24
> Jan 26 22:24:57 rainbow kernel: [ 184.190363] wlan2: authenticated
> Jan 26 22:24:57 rainbow kernel: [ 184.190370] wlan2: associate with
> AP 00:30:bd:c0:90:24
> Jan 26 22:24:57 rainbow kernel: [ 184.193885] wlan2: RX AssocResp
> from 00:30:bd:c0:90:24 (capab=0x1 status=0 aid=8)
> Jan 26 22:24:57 rainbow kernel: [ 184.193892] wlan2: associated
> Jan 26 22:24:57 rainbow kernel: [ 184.194510] wlan2: disassociating
> by local choice (reason=3)
> Jan 26 22:25:03 rainbow kernel: [ 189.870792] wlan2: authenticate
> with AP 00:30:bd:c0:90:24
> Jan 26 22:25:03 rainbow kernel: [ 189.875492] wlan2: authenticated
> Jan 26 22:25:03 rainbow kernel: [ 189.875498] wlan2: associate with
> AP 00:30:bd:c0:90:24
> Jan 26 22:25:03 rainbow kernel: [ 189.878367] wlan2: RX AssocResp
> from 00:30:bd:c0:90:24 (capab=0x1 status=0 aid=8)
> Jan 26 22:25:03 rainbow kernel: [ 189.878374] wlan2: associated
> Jan 26 22:25:03 rainbow kernel: [ 189.883084]
> ADDRCONF(NETDEV_CHANGE): wlan2: link becomes ready
> Jan 26 22:25:13 rainbow kernel: [ 200.460142] wlan2: no IPv6 routers present
>
> This message is went with the older 2.13.1.0 firmware.
>
> Jason
>

2009-01-28 01:26:48

by Jason Andryuk

[permalink] [raw]
Subject: Re: p54usb and 2.13.24.0 Firmware fail to probe 1st generation (ISL3886 + net2280)

Increasing the timeout to 9000 still results in -ETIMEDOUT. Could the
firmware just be incompatible with the device?

Jason

On Tue, Jan 27, 2009 at 7:10 PM, Jason Andryuk <[email protected]> wrote:
> With the below patch, -ETIMEDOUT is returned from usb_interrupt_msg in
> addition to alen != sizeof(__le32)
>
> [ 53.876103] usb 4-2: new high speed USB device using ehci_hcd and address 2
> [ 54.008792] usb 4-2: configuration #1 chosen from 1 choice
> [ 54.131230] usb 4-2: firmware: requesting isl3886usb
> [ 54.148759] phy1: p54 detected a LM86 firmware
> [ 54.148765] p54: rx_mtu reduced from 3240 to 2392
> [ 54.148770] phy1: FW rev 2.13.24.0 - Softmac protocol 5.9
> [ 54.148775] phy1: cryptographic accelerator WEP:YES, TKIP:YES, CCMP:YES
> [ 56.316196] usb 4-2: (p54usb) err=-110, alen=0, size=4
> [ 56.316311] p54usb: probe of 4-2:1.0 failed with error -110
> [ 56.316356] usbcore: registered new interface driver p54usb
>
> diff --git a/drivers/net/wireless/p54/p54usb.c b/drivers/net/wireless/p54/p54usb
> index 9539ddc..3e26085 100644
> --- a/drivers/net/wireless/p54/p54usb.c
> +++ b/drivers/net/wireless/p54/p54usb.c
> @@ -652,6 +652,7 @@ static int p54u_upload_firmware_net2280(struct ieee80211_hw
>
> err = p54_parse_firmware(dev, fw_entry);
> if (err) {
> + dev_err(&priv->udev->dev, "(p54usb) cannot parse firmware\n");
> kfree(buf);
> release_firmware(fw_entry);
> return err;
> @@ -858,8 +859,11 @@ static int p54u_upload_firmware_net2280(struct ieee80211_hw
> err = usb_interrupt_msg(priv->udev,
> usb_rcvbulkpipe(priv->udev, P54U_PIPE_INT),
> buf, sizeof(__le32), &alen, 1000);
> - if (err || alen != sizeof(__le32))
> + if (err || alen != sizeof(__le32)) {
> + dev_err(&priv->udev->dev, "(p54usb) err=%d, alen=%d, size=%d\n",
> + err, alen, sizeof(__le32));
> goto fail;
> + }
>
> P54U_READ(NET2280_DEV_U32, &devreg->int_ident);
> P54U_WRITE(NET2280_DEV_U32, &devreg->int_ack, reg);
>