2022-09-15 03:14:24

by Jilin Yuan

Subject: [PATCH] orinoco: fix repeated words in comments

Delete the redundant word 'this'.

Signed-off-by: Jilin Yuan <[email protected]>
---
drivers/net/wireless/intersil/orinoco/main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intersil/orinoco/main.h b/drivers/net/wireless/intersil/orinoco/main.h
index 5a8fec26136e..852e1643dad2 100644
--- a/drivers/net/wireless/intersil/orinoco/main.h
+++ b/drivers/net/wireless/intersil/orinoco/main.h
@@ -12,7 +12,7 @@
/* Compile time configuration and compatibility stuff */
/********************************************************************/

-/* We do this this way to avoid ifdefs in the actual code */
+/* We do this way to avoid ifdefs in the actual code */
#ifdef WIRELESS_SPY
#define SPY_NUMBER(priv) (priv->spy_data.spy_number)
#else
--
2.36.1

2022-09-15 04:04:03

by Jeff Johnson

Subject: Re: [PATCH] orinoco: fix repeated words in comments

On 9/14/2022 8:02 PM, Jilin Yuan wrote:
> Delete the redundant word 'this'.
>
> Signed-off-by: Jilin Yuan <[email protected]>
> ---
> drivers/net/wireless/intersil/orinoco/main.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intersil/orinoco/main.h b/drivers/net/wireless/intersil/orinoco/main.h
> index 5a8fec26136e..852e1643dad2 100644
> --- a/drivers/net/wireless/intersil/orinoco/main.h
> +++ b/drivers/net/wireless/intersil/orinoco/main.h
> @@ -12,7 +12,7 @@
> /* Compile time configuration and compatibility stuff */
> /********************************************************************/
>
> -/* We do this this way to avoid ifdefs in the actual code */
> +/* We do this way to avoid ifdefs in the actual code */

In this case the two instances of "this" are not a repetition, they are
different parts of speech.

The existing sentence is correct English; the modified sentence is not.

If the repeated word really bothers you then insert "in": We do this in
this way...


> #ifdef WIRELESS_SPY
> #define SPY_NUMBER(priv) (priv->spy_data.spy_number)
> #else

2022-09-15 05:29:26

by Jeff Johnson

Subject: Re: [PATCH] orinoco: fix repeated words in comments

On 9/14/2022 8:54 PM, Jeff Johnson wrote:
> On 9/14/2022 8:02 PM, Jilin Yuan wrote:
>> Delete the redundant word 'this'.
>>
>> Signed-off-by: Jilin Yuan <[email protected]>
>> ---
>>   drivers/net/wireless/intersil/orinoco/main.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/intersil/orinoco/main.h
>> b/drivers/net/wireless/intersil/orinoco/main.h
>> index 5a8fec26136e..852e1643dad2 100644
>> --- a/drivers/net/wireless/intersil/orinoco/main.h
>> +++ b/drivers/net/wireless/intersil/orinoco/main.h
>> @@ -12,7 +12,7 @@
>>   /* Compile time configuration and compatibility stuff               */
>>   /********************************************************************/
>> -/* We do this this way to avoid ifdefs in the actual code */
>> +/* We do this way to avoid ifdefs in the actual code */
>
> In this case the two instances of "this" are not a repetition, they are
> different parts of speech.
>
> The existing sentence is correct English; the modified sentence is not.
>
> If the repeated word really bothers you then insert "in": We do this in
> this way...
>
>
>>   #ifdef WIRELESS_SPY
>>   #define SPY_NUMBER(priv)    (priv->spy_data.spy_number)
>>   #else
>
In addition the patch subject of all files in drivers/net/wireless
should now begin with "wifi: "