2023-03-20 23:35:48

by Tom Rix

Subject: [PATCH] wifi: rtw88: remove unused rtw_pci_get_tx_desc function

clang with W=1 reports
drivers/net/wireless/realtek/rtw88/pci.c:92:21: error:
unused function 'rtw_pci_get_tx_desc' [-Werror,-Wunused-function]
static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
^
This function is not used, so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/net/wireless/realtek/rtw88/pci.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
index b4bd831c9845..6a8e6ee82069 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.c
+++ b/drivers/net/wireless/realtek/rtw88/pci.c
@@ -89,13 +89,6 @@ static void rtw_pci_write32(struct rtw_dev *rtwdev, u32 addr, u32 val)
writel(val, rtwpci->mmap + addr);
}

-static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
-{
- int offset = tx_ring->r.desc_size * idx;
-
- return tx_ring->r.head + offset;
-}
-
static void rtw_pci_free_tx_ring_skbs(struct rtw_dev *rtwdev,
struct rtw_pci_tx_ring *tx_ring)
{
--
2.27.0

2023-03-21 00:33:59

by Ping-Ke Shih

Subject: RE: [PATCH] wifi: rtw88: remove unused rtw_pci_get_tx_desc function

> -----Original Message-----
> From: Tom Rix <[email protected]>
> Sent: Tuesday, March 21, 2023 7:35 AM
> To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; Tom Rix <[email protected]>
> Subject: [PATCH] wifi: rtw88: remove unused rtw_pci_get_tx_desc function
>
> clang with W=1 reports
> drivers/net/wireless/realtek/rtw88/pci.c:92:21: error:
> unused function 'rtw_pci_get_tx_desc' [-Werror,-Wunused-function]
> static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Ping-Ke Shih <[email protected]>

> ---
> drivers/net/wireless/realtek/rtw88/pci.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
> index b4bd831c9845..6a8e6ee82069 100644
> --- a/drivers/net/wireless/realtek/rtw88/pci.c
> +++ b/drivers/net/wireless/realtek/rtw88/pci.c
> @@ -89,13 +89,6 @@ static void rtw_pci_write32(struct rtw_dev *rtwdev, u32 addr, u32 val)
> writel(val, rtwpci->mmap + addr);
> }
>
> -static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
> -{
> - int offset = tx_ring->r.desc_size * idx;
> -
> - return tx_ring->r.head + offset;
> -}
> -
> static void rtw_pci_free_tx_ring_skbs(struct rtw_dev *rtwdev,
> struct rtw_pci_tx_ring *tx_ring)
> {
> --
> 2.27.0

2023-03-31 14:50:24

by Kalle Valo

Subject: Re: [PATCH] wifi: rtw88: remove unused rtw_pci_get_tx_desc function

Tom Rix <[email protected]> wrote:

> clang with W=1 reports
> drivers/net/wireless/realtek/rtw88/pci.c:92:21: error:
> unused function 'rtw_pci_get_tx_desc' [-Werror,-Wunused-function]
> static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>
> Reviewed-by: Ping-Ke Shih <[email protected]>

Patch applied to wireless-next.git, thanks.

c9b6111a6f94 wifi: rtw88: remove unused rtw_pci_get_tx_desc function

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches