2022-05-05 21:42:28

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH 4/4] mt76: mt7915: limit minimum twt duration

On 05.05.22 14:23, Lorenzo Bianconi wrote:
>> The minimum twt duration supported by mt7915 is 64 according to hardware
>> design. Reply station with TWT_SETUP_CMD_DICTATE if min_twt_dur smaller
>> than 64.
>>
>> Signed-off-by: Peter Chiu <[email protected]>
>> ---
>> drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
>> index ff60a3d2d26d..e912ecacb578 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
>> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
>> @@ -2633,6 +2633,7 @@ void mt7915_mac_add_twt_setup(struct ieee80211_hw *hw,
>> struct ieee80211_sta *sta,
>> struct ieee80211_twt_setup *twt)
>> {
>> +#define MT7915_MIN_TWT_DUR 64
>
> nit: can you please move MT7915_MIN_TWT_DUR in mt7915.h since we have other twt
> defs there?
Fixed in my tree.

- Felix