It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
this build error:
drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
Signed-off-by: Andreas Schwab <[email protected]>
---
This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
misattributed as a compiler bug.
---
drivers/net/wireless/iwlwifi/iwl3945-base.c | 1 -
1 file changed, 1 deletion(-)
--- linux-2.6.30-rc4.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-30 08:59:41.000000000 +0200
+++ linux-2.6.30-rc4/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-30 09:34:14.000000000 +0200
@@ -1745,7 +1745,6 @@ static void iwl3945_rx_queue_free(struct
rxq->bd = NULL;
rxq->rb_stts = NULL;
}
-EXPORT_SYMBOL(iwl3945_rx_queue_free);
/* Convert linear signal-to-noise ratio into dB */
--
Andreas Schwab, [email protected]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
On Thu, 2009-04-30 at 09:58 +0200, Andreas Schwab wrote:
> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
> this build error:
>
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:
> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
>
> Signed-off-by: Andreas Schwab <[email protected]>
> ---
> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
> misattributed as a compiler bug.
At least in my tree the function isn't static...(yet I still got the
compiler error)?
johannes
Johannes Berg <[email protected]> writes:
> On Thu, 2009-04-30 at 09:58 +0200, Andreas Schwab wrote:
>> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
>> this build error:
>>
>> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:
>> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
>>
>> Signed-off-by: Andreas Schwab <[email protected]>
>> ---
>> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
>> misattributed as a compiler bug.
>
> At least in my tree the function isn't static...(yet I still got the
> compiler error)?
The static function is iwl3945_rx_queue_free.
Andreas.
--
Andreas Schwab, [email protected]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
reinette chatre
<[email protected]> writes:
> Thanks. Even though this patch obsoletes
> 6269b731560d69c5eaa929909891edec39496d71 it still makes sense to have
> that patch in the repo as it removes another unnecessary EXPORT_SYMBOL.
> I would thus prefer that both patches are included.
I agree.
Andreas.
--
Andreas Schwab, [email protected]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
On Thu, 2009-04-30 at 00:58 -0700, Andreas Schwab wrote:
> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
> this build error:
>
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
>
> Signed-off-by: Andreas Schwab <[email protected]>
> ---
> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
>From which repo is this commit id?
> misattributed as a compiler bug.
> ---
> drivers/net/wireless/iwlwifi/iwl3945-base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-2.6.30-rc4.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-30 08:59:41.000000000 +0200
> +++ linux-2.6.30-rc4/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-30 09:34:14.000000000 +0200
> @@ -1745,7 +1745,6 @@ static void iwl3945_rx_queue_free(struct
> rxq->bd = NULL;
> rxq->rb_stts = NULL;
> }
> -EXPORT_SYMBOL(iwl3945_rx_queue_free);
>
>
> /* Convert linear signal-to-noise ratio into dB */
>
Acked-by: Reinette Chatre <[email protected]>
Thank you
Reinette
Andreas,
On Thu, 2009-04-30 at 10:27 -0700, Andreas Schwab wrote:
>
> reinette chatre
> <[email protected]> writes:
>
> > On Thu, 2009-04-30 at 00:58 -0700, Andreas Schwab wrote:
> >> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
> >> this build error:
> >>
> >> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
> >>
> >> Signed-off-by: Andreas Schwab <[email protected]>
> >> ---
> >> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
> >
> >>From which repo is this commit id?
>
> That's from davem/net-2.6 or linville/wireless-2.6.git
Thanks. Even though this patch obsoletes
6269b731560d69c5eaa929909891edec39496d71 it still makes sense to have
that patch in the repo as it removes another unnecessary EXPORT_SYMBOL.
I would thus prefer that both patches are included.
Reinette
On Thu, 2009-04-30 at 10:20 +0200, Andreas Schwab wrote:
> >> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:
> >> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
> > At least in my tree the function isn't static...(yet I still got the
> > compiler error)?
>
> The static function is iwl3945_rx_queue_free.
Oh. I have to admit to not looking that far, thanks.
johannes
reinette chatre
<[email protected]> writes:
> On Thu, 2009-04-30 at 00:58 -0700, Andreas Schwab wrote:
>> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
>> this build error:
>>
>> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
>>
>> Signed-off-by: Andreas Schwab <[email protected]>
>> ---
>> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
>
>>From which repo is this commit id?
That's from davem/net-2.6 or linville/wireless-2.6.git
Andreas.
--
Andreas Schwab, [email protected]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."