2010-03-20 15:00:07

by Matteo Croce

[permalink] [raw]
Subject: Compat wireless with kernel 2.6.33

This patch allows compat wireless to compile with a kernel >= 2.6.33

Index: compat-wireless-2010-03-19/scripts/gen-compat-autoconf.sh
===================================================================
--- compat-wireless-2010-03-19.orig/scripts/gen-compat-autoconf.sh 2010-03-20
15:26:22.604720545 +0100
+++ compat-wireless-2010-03-19/scripts/gen-compat-autoconf.sh 2010-03-20
15:27:49.212236531 +0100
@@ -145,7 +145,11 @@
kernel_version_req $OLDEST_KERNEL_SUPPORTED

# Handle core kernel wireless depenencies here
+echo '#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,33)'
+define_config_req CONFIG_CFG80211_WEXT
+echo '#else'
define_config_req CONFIG_WIRELESS_EXT
+echo '#endif'

# For each CONFIG_FOO=x option
for i in $(grep '^CONFIG_' $COMPAT_CONFIG); do


--
Matteo Croce
OpenWrt developer
_______ ________ __
| |.-----.-----.-----.| | | |.----.| |_
| - || _ | -__| || | | || _|| _|
|_______|| __|_____|__|__||________||__| |____|
|__| W I R E L E S S F R E E D O M
KAMIKAZE (bleeding edge) ------------------
* 10 oz Vodka Shake well with ice and strain
* 10 oz Triple sec mixture into 10 shot glasses.
* 10 oz lime juice Salute!
---------------------------------------------------


2010-04-05 23:34:36

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: Compat wireless with kernel 2.6.33

On Sat, Mar 20, 2010 at 7:59 AM, Matteo Croce <[email protected]> wrote:
> This patch allows compat wireless to compile with a kernel >= 2.6.33
>
> Index: compat-wireless-2010-03-19/scripts/gen-compat-autoconf.sh
> ===================================================================
> --- compat-wireless-2010-03-19.orig/scripts/gen-compat-autoconf.sh      2010-03-20
> 15:26:22.604720545 +0100
> +++ compat-wireless-2010-03-19/scripts/gen-compat-autoconf.sh   2010-03-20
> 15:27:49.212236531 +0100
> @@ -145,7 +145,11 @@
>  kernel_version_req $OLDEST_KERNEL_SUPPORTED
>
>  # Handle core kernel wireless depenencies here
> +echo '#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,33)'
> +define_config_req CONFIG_CFG80211_WEXT
> +echo '#else'
>  define_config_req CONFIG_WIRELESS_EXT
> +echo '#endif'
>
>  # For each CONFIG_FOO=x option
>  for i in $(grep '^CONFIG_' $COMPAT_CONFIG); do

Sorry been meaning to reply, reason I haven't applied it is this seems
wrong, we should be able to build kernels with 802.11 without wext
crap on new kernels. Perhaps only add the requirement for kernels
older than 2.6.33?

Luis

2010-04-05 23:54:45

by Matteo Croce

[permalink] [raw]
Subject: Re: Compat wireless with kernel 2.6.33

On Tue, Apr 6, 2010 at 1:34 AM, Luis R. Rodriguez <[email protected]> wrote:
> On Sat, Mar 20, 2010 at 7:59 AM, Matteo Croce <[email protected]> wrote:
>> This patch allows compat wireless to compile with a kernel >= 2.6.33
>>
>> Index: compat-wireless-2010-03-19/scripts/gen-compat-autoconf.sh
>> ===================================================================
>> --- compat-wireless-2010-03-19.orig/scripts/gen-compat-autoconf.sh      2010-03-20
>> 15:26:22.604720545 +0100
>> +++ compat-wireless-2010-03-19/scripts/gen-compat-autoconf.sh   2010-03-20
>> 15:27:49.212236531 +0100
>> @@ -145,7 +145,11 @@
>>  kernel_version_req $OLDEST_KERNEL_SUPPORTED
>>
>>  # Handle core kernel wireless depenencies here
>> +echo '#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,33)'
>> +define_config_req CONFIG_CFG80211_WEXT
>> +echo '#else'
>>  define_config_req CONFIG_WIRELESS_EXT
>> +echo '#endif'
>>
>>  # For each CONFIG_FOO=x option
>>  for i in $(grep '^CONFIG_' $COMPAT_CONFIG); do
>
> Sorry been meaning to reply, reason I haven't applied it is this seems
> wrong, we should be able to build kernels with 802.11 without wext
> crap on new kernels. Perhaps only add the requirement for kernels
> older than 2.6.33?
>
>  Luis
>

Please do not disable wext until nl80211 can really replace it.
There are some things than nl80211 can't do yet (eg. txpower)

--
Matteo Croce
OpenWrt developer
_______ ________ __
| |.-----.-----.-----.| | | |.----.| |_
| - || _ | -__| || | | || _|| _|
|_______|| __|_____|__|__||________||__| |____|
|__| W I R E L E S S F R E E D O M
KAMIKAZE (bleeding edge) ------------------
* 10 oz Vodka Shake well with ice and strain
* 10 oz Triple sec mixture into 10 shot glasses.
* 10 oz lime juice Salute!
---------------------------------------------------

2010-04-05 22:17:17

by John Daiker

[permalink] [raw]
Subject: Re: Compat wireless with kernel 2.6.33

Luis,

It would be nice to see this pushed into the latest compat-wireless.

It's helpful for people using a 2.6.33 kernel and needing the latest b43
updates for our Atom-based netbooks! :)

John Daiker

On 03/20/2010 07:59 AM, Matteo Croce wrote:
> This patch allows compat wireless to compile with a kernel>= 2.6.33
>
> Index: compat-wireless-2010-03-19/scripts/gen-compat-autoconf.sh
> ===================================================================
> --- compat-wireless-2010-03-19.orig/scripts/gen-compat-autoconf.sh 2010-03-20
> 15:26:22.604720545 +0100
> +++ compat-wireless-2010-03-19/scripts/gen-compat-autoconf.sh 2010-03-20
> 15:27:49.212236531 +0100
> @@ -145,7 +145,11 @@
> kernel_version_req $OLDEST_KERNEL_SUPPORTED
>
> # Handle core kernel wireless depenencies here
> +echo '#if LINUX_VERSION_CODE>= KERNEL_VERSION(2,6,33)'
> +define_config_req CONFIG_CFG80211_WEXT
> +echo '#else'
> define_config_req CONFIG_WIRELESS_EXT
> +echo '#endif'
>
> # For each CONFIG_FOO=x option
> for i in $(grep '^CONFIG_' $COMPAT_CONFIG); do
>
>


2010-04-06 06:58:40

by Johannes Berg

[permalink] [raw]
Subject: Re: Compat wireless with kernel 2.6.33

On Mon, 2010-04-05 at 17:08 -0700, Luis R. Rodriguez wrote:

> > Please do not disable wext until nl80211 can really replace it.
>
> wext is already disabled by default if you don't have a driver that requires it.

Not yet:

config CFG80211_WEXT
bool "cfg80211 wireless extensions compatibility"
depends on CFG80211
select WEXT_CORE
default y
help
Enable this option if you need old userspace for wireless
extensions with cfg80211-based drivers.

johannes


2010-04-06 00:08:29

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: Compat wireless with kernel 2.6.33

On Mon, Apr 5, 2010 at 4:54 PM, Matteo Croce <[email protected]> wrote:
> On Tue, Apr 6, 2010 at 1:34 AM, Luis R. Rodriguez <[email protected]> wrote:
>> On Sat, Mar 20, 2010 at 7:59 AM, Matteo Croce <[email protected]> wrote:
>>> This patch allows compat wireless to compile with a kernel >= 2.6.33
>>>
>>> Index: compat-wireless-2010-03-19/scripts/gen-compat-autoconf.sh
>>> ===================================================================
>>> --- compat-wireless-2010-03-19.orig/scripts/gen-compat-autoconf.sh      2010-03-20
>>> 15:26:22.604720545 +0100
>>> +++ compat-wireless-2010-03-19/scripts/gen-compat-autoconf.sh   2010-03-20
>>> 15:27:49.212236531 +0100
>>> @@ -145,7 +145,11 @@
>>>  kernel_version_req $OLDEST_KERNEL_SUPPORTED
>>>
>>>  # Handle core kernel wireless depenencies here
>>> +echo '#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,33)'
>>> +define_config_req CONFIG_CFG80211_WEXT
>>> +echo '#else'
>>>  define_config_req CONFIG_WIRELESS_EXT
>>> +echo '#endif'
>>>
>>>  # For each CONFIG_FOO=x option
>>>  for i in $(grep '^CONFIG_' $COMPAT_CONFIG); do
>>
>> Sorry been meaning to reply, reason I haven't applied it is this seems
>> wrong, we should be able to build kernels with 802.11 without wext
>> crap on new kernels. Perhaps only add the requirement for kernels
>> older than 2.6.33?
>>
>>  Luis
>>
>
> Please do not disable wext until nl80211 can really replace it.

wext is already disabled by default if you don't have a driver that requires it.

> There are some things than nl80211 can't do yet (eg. txpower)

Sure, that's the only thing I'm aware of.

Luis