2021-01-28 17:14:36

by Colin King

[permalink] [raw]
Subject: [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus

From: Colin Ian King <[email protected]>

The variable rtstatu is being initialized with a value that is never
read and it is being updated later with a new value. The initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c
index 63283d9e7485..aaa004d4d6d0 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c
@@ -1017,7 +1017,7 @@ bool rtl92s_phy_bb_config(struct ieee80211_hw *hw)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
struct rtl_phy *rtlphy = &(rtlpriv->phy);
- bool rtstatus = true;
+ bool rtstatus;
u8 pathmap, index, rf_num = 0;
u8 path1, path2;

--
2.29.2


2021-01-28 18:48:52

by Willem de Bruijn

[permalink] [raw]
Subject: Re: [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus

On Thu, Jan 28, 2021 at 12:15 PM Colin King <[email protected]> wrote:
>
> From: Colin Ian King <[email protected]>
>
> The variable rtstatu is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

(for netdrv)

Acked-by: Willem de Bruijn <[email protected]>

2021-02-08 10:44:42

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus

Colin King <[email protected]> wrote:

> From: Colin Ian King <[email protected]>
>
> The variable rtstatu is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> Acked-by: Willem de Bruijn <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

711fa16f1dfe rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches