2021-02-11 20:33:47

by Luca Coelho

[permalink] [raw]
Subject: [PATCH] iwlwifi: remove incorrect comment in pnvm

From: Luca Coelho <[email protected]>

We use this driver as a backport that also runs on older kernels (as
part of the backports project). So we use some checks to backport or
prevent code from compiling in incompatible kernel version.

When I took one of the PNVM patches from the backport, I accidentally
left the comment that a certain part of the code doesn't work in older
kernels. This obviously should never be valid for the mainline.
Remove this comment.

Reported-by: Kalle Valo <[email protected]>
Signed-off-by: Luca Coelho <[email protected]>
---
drivers/net/wireless/intel/iwlwifi/fw/pnvm.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
index 2cd07d2690e0..fd070ca5e517 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
@@ -220,11 +220,6 @@ static int iwl_pnvm_parse(struct iwl_trans *trans, const u8 *data,
return -ENOENT;
}

-/*
- * This is known to be broken on v4.19 and to work on v5.4. Until we
- * figure out why this is the case and how to make it work, simply
- * disable the feature in old kernels.
- */
#if defined(CONFIG_EFI)

#define IWL_EFI_VAR_GUID EFI_GUID(0x92daaf2f, 0xc02b, 0x455b, \
--
2.30.0


2021-02-12 06:15:52

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: remove incorrect comment in pnvm

Luca Coelho <[email protected]> writes:

> From: Luca Coelho <[email protected]>
>
> We use this driver as a backport that also runs on older kernels (as
> part of the backports project). So we use some checks to backport or
> prevent code from compiling in incompatible kernel version.
>
> When I took one of the PNVM patches from the backport, I accidentally
> left the comment that a certain part of the code doesn't work in older
> kernels. This obviously should never be valid for the mainline.
> Remove this comment.
>
> Reported-by: Kalle Valo <[email protected]>
> Signed-off-by: Luca Coelho <[email protected]>

Thanks, I assigned this to myself on patchwork and apply directly to
wireless-drivers-next.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2021-02-12 07:49:25

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: remove incorrect comment in pnvm

Luca Coelho <[email protected]> wrote:

> From: Luca Coelho <[email protected]>
>
> We use this driver as a backport that also runs on older kernels (as
> part of the backports project). So we use some checks to backport or
> prevent code from compiling in incompatible kernel version.
>
> When I took one of the PNVM patches from the backport, I accidentally
> left the comment that a certain part of the code doesn't work in older
> kernels. This obviously should never be valid for the mainline.
> Remove this comment.
>
> Reported-by: Kalle Valo <[email protected]>
> Signed-off-by: Luca Coelho <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

3304b6f937a3 iwlwifi: remove incorrect comment in pnvm

--
https://patchwork.kernel.org/project/linux-wireless/patch/iwlwifi.202102[email protected]changeid/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches