2021-08-25 01:36:27

by Daniel Golle

Subject: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property

EEPROM data for mt76 can be embedded into device-tree as an array.

Signed-off-by: Daniel Golle <[email protected]>
---
.../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 3e2c2e43175e5..1489d3c1cd6ec 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -47,6 +47,11 @@ properties:

ieee80211-freq-limit: true

+ mediatek,eeprom-data:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description:
+ EEPROM data embedded as array.
+
mediatek,mtd-eeprom:
$ref: /schemas/types.yaml#/definitions/phandle-array
description:
--
2.32.0

2021-08-31 19:29:47

by Rob Herring (Arm)

Subject: Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property

On Wed, 25 Aug 2021 02:33:23 +0100, Daniel Golle wrote:
> EEPROM data for mt76 can be embedded into device-tree as an array.
>
> Signed-off-by: Daniel Golle <[email protected]>
> ---
> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>

Acked-by: Rob Herring <[email protected]>

2021-09-24 21:48:44

by Felix Fietkau

Subject: Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property

On 2021-08-25 03:33, Daniel Golle wrote:
> EEPROM data for mt76 can be embedded into device-tree as an array.
>
> Signed-off-by: Daniel Golle <[email protected]>
> ---
> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 3e2c2e43175e5..1489d3c1cd6ec 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -47,6 +47,11 @@ properties:
>
> ieee80211-freq-limit: true
>
> + mediatek,eeprom-data:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
Given that the driver patch simply uses memcpy on the data, shouldn't we
use an uint8-array here?

- Felix

2021-10-05 16:38:05

by Daniel Golle

Subject: Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property

On Fri, Sep 24, 2021 at 07:14:47PM +0200, Felix Fietkau wrote:
>
> On 2021-08-25 03:33, Daniel Golle wrote:
> > EEPROM data for mt76 can be embedded into device-tree as an array.
> >
> > Signed-off-by: Daniel Golle <[email protected]>
> > ---
> > .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > index 3e2c2e43175e5..1489d3c1cd6ec 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > @@ -47,6 +47,11 @@ properties:
> >
> > ieee80211-freq-limit: true
> >
> > + mediatek,eeprom-data:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> Given that the driver patch simply uses memcpy on the data, shouldn't we
> use an uint8-array here?

When using the /incbin/('file.bin'); syntax the result is included as
what appears to be a uint32-array when decompiling again with dtc.