2017-09-11 11:42:43

by Colin King

Subject: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp

From: Colin Ian King <[email protected]>

sqp is being initialised when it is being declared and then updated
a little later on making the first initialization redundant. Clean
this up by initializing ptr and sqp at their declaration.

Cleans up warning: "warning: Value stored to 'sqp' during its
initialization is never read"

Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue pointer as needed on flush")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/infiniband/hw/cxgb3/cxio_hal.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio_hal.c
index 3eff6541bd6f..b42e81ab5fa8 100644
--- a/drivers/infiniband/hw/cxgb3/cxio_hal.c
+++ b/drivers/infiniband/hw/cxgb3/cxio_hal.c
@@ -404,12 +404,10 @@ static void insert_sq_cqe(struct t3_wq *wq, struct t3_cq *cq,

int cxio_flush_sq(struct t3_wq *wq, struct t3_cq *cq, int count)
{
- __u32 ptr;
+ __u32 ptr = wq->sq_rptr + count;
int flushed = 0;
- struct t3_swsq *sqp = wq->sq + Q_PTR2IDX(wq->sq_rptr, wq->sq_size_log2);
+ struct t3_swsq *sqp = wq->sq + Q_PTR2IDX(ptr, wq->sq_size_log2);

- ptr = wq->sq_rptr + count;
- sqp = wq->sq + Q_PTR2IDX(ptr, wq->sq_size_log2);
while (ptr != wq->sq_wptr) {
sqp->signaled = 0;
insert_sq_cqe(wq, cq, sqp);
--
2.14.1

2017-09-11 14:28:14

by Steve Wise

Subject: RE: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp

>
> From: Colin Ian King <[email protected]>
>
> sqp is being initialised when it is being declared and then updated
> a little later on making the first initialization redundant. Clean
> this up by initializing ptr and sqp at their declaration.
>
> Cleans up warning: "warning: Value stored to 'sqp' during its
> initialization is never read"
>
> Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue pointer as
> needed on flush")
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Steve Wise <[email protected]>

2017-09-27 13:11:32

by Doug Ledford

Subject: Re: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp

On Mon, 2017-09-11 at 12:42 +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> sqp is being initialised when it is being declared and then updated
> a little later on making the first initialization redundant. Clean
> this up by initializing ptr and sqp at their declaration.
>
> Cleans up warning: "warning: Value stored to 'sqp' during its
> initialization is never read"
>
> Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue
> pointer as needed on flush")
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, applied.

--
Doug Ledford <[email protected]>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD