Commit a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") left
the BOOT_MEM_INIT_RAM unused, remove it.
Signed-off-by: Youling Tang <[email protected]>
---
arch/mips/include/asm/bootinfo.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/include/asm/bootinfo.h b/arch/mips/include/asm/bootinfo.h
index 147c932..39196ae 100644
--- a/arch/mips/include/asm/bootinfo.h
+++ b/arch/mips/include/asm/bootinfo.h
@@ -91,7 +91,6 @@ extern unsigned long mips_machtype;
#define BOOT_MEM_RAM 1
#define BOOT_MEM_ROM_DATA 2
#define BOOT_MEM_RESERVED 3
-#define BOOT_MEM_INIT_RAM 4
#define BOOT_MEM_NOMAP 5
extern void add_memory_region(phys_addr_t start, phys_addr_t size, long type);
--
2.1.0
?? 2020/9/12 9:59, Youling Tang д??:
> Commit a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") left
> the BOOT_MEM_INIT_RAM unused, remove it.
>
> Signed-off-by: Youling Tang <[email protected]>
> ---
> arch/mips/include/asm/bootinfo.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/bootinfo.h b/arch/mips/include/asm/bootinfo.h
> index 147c932..39196ae 100644
> --- a/arch/mips/include/asm/bootinfo.h
> +++ b/arch/mips/include/asm/bootinfo.h
> @@ -91,7 +91,6 @@ extern unsigned long mips_machtype;
> #define BOOT_MEM_RAM 1
> #define BOOT_MEM_ROM_DATA 2
> #define BOOT_MEM_RESERVED 3
> -#define BOOT_MEM_INIT_RAM 4
If you're willing to remove that you'd better turn the memtype struct
into a enum.
Btw: It seems you've done a lot of minor clean-up works recently,
if you'd like to I think you can try to turn all the platforms into memblock
and remove all these gules between memblock and legacy code.
Thanks.
- Jiaxun
> #define BOOT_MEM_NOMAP 5
>
> extern void add_memory_region(phys_addr_t start, phys_addr_t size, long type);
On 09/14/2020 12:32 PM, Jiaxun Yang wrote:
>
>
> 在 2020/9/12 9:59, Youling Tang 写道:
>> Commit a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") left
>> the BOOT_MEM_INIT_RAM unused, remove it.
>>
>> Signed-off-by: Youling Tang <[email protected]>
>> ---
>> arch/mips/include/asm/bootinfo.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/mips/include/asm/bootinfo.h
>> b/arch/mips/include/asm/bootinfo.h
>> index 147c932..39196ae 100644
>> --- a/arch/mips/include/asm/bootinfo.h
>> +++ b/arch/mips/include/asm/bootinfo.h
>> @@ -91,7 +91,6 @@ extern unsigned long mips_machtype;
>> #define BOOT_MEM_RAM 1
>> #define BOOT_MEM_ROM_DATA 2
>> #define BOOT_MEM_RESERVED 3
>> -#define BOOT_MEM_INIT_RAM 4
>
> If you're willing to remove that you'd better turn the memtype struct
> into a enum.
>
Hi Jiaxun,
Do you mean to modify it as follows?
enum boot_memtype {
BOOT_MEM_RAM,
BOOT_MEM_ROM_DATA,
BOOT_MEM_RESERVED,
BOOT_MEM_NOMAP,
};
Thanks.
- Youling
> Btw: It seems you've done a lot of minor clean-up works recently,
> if you'd like to I think you can try to turn all the platforms into
> memblock
> and remove all these gules between memblock and legacy code.
>
> Thanks.
>
> - Jiaxun
>
>> #define BOOT_MEM_NOMAP 5
>> extern void add_memory_region(phys_addr_t start, phys_addr_t
>> size, long type);
On Mon, Sep 14, 2020 at 06:39:51PM +0800, Youling Tang wrote:
>
>
> On 09/14/2020 12:32 PM, Jiaxun Yang wrote:
> >
> >
> >在 2020/9/12 9:59, Youling Tang 写道:
> >>Commit a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") left
> >>the BOOT_MEM_INIT_RAM unused, remove it.
> >>
> >>Signed-off-by: Youling Tang <[email protected]>
> >>---
> >> arch/mips/include/asm/bootinfo.h | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >>diff --git a/arch/mips/include/asm/bootinfo.h
> >>b/arch/mips/include/asm/bootinfo.h
> >>index 147c932..39196ae 100644
> >>--- a/arch/mips/include/asm/bootinfo.h
> >>+++ b/arch/mips/include/asm/bootinfo.h
> >>@@ -91,7 +91,6 @@ extern unsigned long mips_machtype;
> >> #define BOOT_MEM_RAM 1
> >> #define BOOT_MEM_ROM_DATA 2
> >> #define BOOT_MEM_RESERVED 3
> >>-#define BOOT_MEM_INIT_RAM 4
> >
> >If you're willing to remove that you'd better turn the memtype struct
> >into a enum.
> >
> Hi Jiaxun,
> Do you mean to modify it as follows?
>
> enum boot_memtype {
> BOOT_MEM_RAM,
> BOOT_MEM_ROM_DATA,
> BOOT_MEM_RESERVED,
> BOOT_MEM_NOMAP,
> };
that's not worth the effort, we should convert from add_memory_region
to direct memblock_XXX calls and get rid of MIPS boot mem completely.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]