2017-07-19 23:58:32

by Randy Dunlap

Subject: [PATCH -next] staging: pi433: depends on SPI

From: Randy Dunlap <[email protected]>

The pi433 driver uses SPI interfaces so it should depend on SPI.
Also, the "default n" can be removed since that is already the
default.

Fixes these build errors when SPI is not enabled:

drivers/staging/pi433/pi433_if.o: In function `pi433_probe':
pi433_if.c:(.text+0x1135): undefined reference to `spi_setup'
pi433_if.c:(.text+0x1177): undefined reference to `spi_write_then_read'
drivers/staging/pi433/pi433_if.o: In function `pi433_init':
pi433_if.c:(.init.text+0xb8): undefined reference to `__spi_register_driver'
drivers/staging/pi433/rf69.o: In function `rf69_read_fifo':
rf69.c:(.text+0x102): undefined reference to `spi_sync'
drivers/staging/pi433/rf69.o: In function `rf69_write_fifo':
rf69.c:(.text+0x248): undefined reference to `spi_sync'
drivers/staging/pi433/rf69.o: In function `rf69_read_reg':
rf69.c:(.text+0x290): undefined reference to `spi_write_then_read'
drivers/staging/pi433/rf69.o: In function `rf69_write_reg':
rf69.c:(.text+0x523): undefined reference to `spi_sync'

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Marcus Wolf <[email protected]>
---
drivers/staging/pi433/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- next-2017-0719.orig/drivers/staging/pi433/Kconfig
+++ next-2017-0719/drivers/staging/pi433/Kconfig
@@ -1,6 +1,6 @@
config PI433
tristate "Pi433 - a 433MHz radio module for Raspberry Pi"
- default n
+ depends on SPI
---help---
This option allows you to enable support for the radio module Pi433.

2017-07-20 11:06:14

by Marcus Wolf

Subject: Re: [PATCH -next] staging: pi433: depends on SPI

Reviewed-by: Marcus Wolf <[email protected]>

Am Do, 20.07.2017, 01:58 schrieb Randy Dunlap:
> From: Randy Dunlap <[email protected]>
>
> The pi433 driver uses SPI interfaces so it should depend on SPI.
> Also, the "default n" can be removed since that is already the
> default.
>
> Fixes these build errors when SPI is not enabled:
>
> drivers/staging/pi433/pi433_if.o: In function `pi433_probe':
> pi433_if.c:(.text+0x1135): undefined reference to `spi_setup'
> pi433_if.c:(.text+0x1177): undefined reference to `spi_write_then_read'
> drivers/staging/pi433/pi433_if.o: In function `pi433_init':
> pi433_if.c:(.init.text+0xb8): undefined reference to `__spi_register_driver'
> drivers/staging/pi433/rf69.o: In function `rf69_read_fifo':
> rf69.c:(.text+0x102): undefined reference to `spi_sync'
> drivers/staging/pi433/rf69.o: In function `rf69_write_fifo':
> rf69.c:(.text+0x248): undefined reference to `spi_sync'
> drivers/staging/pi433/rf69.o: In function `rf69_read_reg':
> rf69.c:(.text+0x290): undefined reference to `spi_write_then_read'
> drivers/staging/pi433/rf69.o: In function `rf69_write_reg':
> rf69.c:(.text+0x523): undefined reference to `spi_sync'
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Marcus Wolf <[email protected]>
> ---
> drivers/staging/pi433/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- next-2017-0719.orig/drivers/staging/pi433/Kconfig
> +++ next-2017-0719/drivers/staging/pi433/Kconfig
> @@ -1,6 +1,6 @@
> config PI433
> tristate "Pi433 - a 433MHz radio module for Raspberry Pi"
> - default n
> + depends on SPI
> ---help---
> This option allows you to enable support for the radio module Pi433.
>
>
>
>
>