Subject: [PATCH v2] platform/x86/pcengines-apuv2: use KEY_RESTART for front button

From: Enrico Weigelt <[email protected]>

The keycode KEY_RESTART is more appropriate for the front button,
as most people use it for things like restart or factory reset.

Signed-off-by: Enrico Weigelt <[email protected]>
Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe ("x86: pcengines apuv2 gpio/leds/keys platform driver")
---
drivers/platform/x86/pcengines-apuv2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index b0d3110..4138007c 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -93,7 +93,7 @@

static struct gpio_keys_button apu2_keys_buttons[] = {
{
- .code = KEY_SETUP,
+ .code = KEY_RESTART,
.active_low = 1,
.desc = "front button",
.type = EV_KEY,
--
1.9.1



2019-08-01 15:47:43

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v2] platform/x86/pcengines-apuv2: use KEY_RESTART for front button

On Thu, Jul 25, 2019 at 10:06 PM Enrico Weigelt, metux IT consult
<[email protected]> wrote:
>
> From: Enrico Weigelt <[email protected]>
>
> The keycode KEY_RESTART is more appropriate for the front button,
> as most people use it for things like restart or factory reset.
>

Applied, thanks!

> Signed-off-by: Enrico Weigelt <[email protected]>
> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe ("x86: pcengines apuv2 gpio/leds/keys platform driver")

Please, use allowed minimum (12 nowadays) characters of hash.

> ---
> drivers/platform/x86/pcengines-apuv2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
> index b0d3110..4138007c 100644
> --- a/drivers/platform/x86/pcengines-apuv2.c
> +++ b/drivers/platform/x86/pcengines-apuv2.c
> @@ -93,7 +93,7 @@
>
> static struct gpio_keys_button apu2_keys_buttons[] = {
> {
> - .code = KEY_SETUP,
> + .code = KEY_RESTART,
> .active_low = 1,
> .desc = "front button",
> .type = EV_KEY,
> --
> 1.9.1
>


--
With Best Regards,
Andy Shevchenko

Subject: Re: [PATCH v2] platform/x86/pcengines-apuv2: use KEY_RESTART for front button

On 01.08.19 17:00, Andy Shevchenko wrote:

Hi,

> On Thu, Jul 25, 2019 at 10:06 PM Enrico Weigelt, metux IT consult
> <[email protected]> wrote:
>>
>> From: Enrico Weigelt <[email protected]>
>>
>> The keycode KEY_RESTART is more appropriate for the front button,
>> as most people use it for things like restart or factory reset.
>>
>
> Applied, thanks!

thx.

>
>> Signed-off-by: Enrico Weigelt <[email protected]>
>> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe ("x86: pcengines apuv2 gpio/leds/keys platform driver")
>
> Please, use allowed minimum (12 nowadays) characters of hash.

hmm, do you happen to know how to configure tig to show the short hash ?


--mtx

--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
[email protected] -- +49-151-27565287

2019-08-16 10:08:35

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v2] platform/x86/pcengines-apuv2: use KEY_RESTART for front button

On Mon, Aug 5, 2019 at 3:06 PM Enrico Weigelt, metux IT consult
<[email protected]> wrote:
> On 01.08.19 17:00, Andy Shevchenko wrote:
> > On Thu, Jul 25, 2019 at 10:06 PM Enrico Weigelt, metux IT consult
> > <[email protected]> wrote:
> >> From: Enrico Weigelt <[email protected]>

> >> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe ("x86: pcengines apuv2 gpio/leds/keys platform driver")
> >
> > Please, use allowed minimum (12 nowadays) characters of hash.
>
> hmm, do you happen to know how to configure tig to show the short hash ?

I have configured '--oneline' to show 12.

--
With Best Regards,
Andy Shevchenko