2023-12-07 12:39:30

by Wang Jinchao

Subject: [PATCH] sched/headers: Remove duplicated struct rq declare

`struct rq` has been declared at the top of the file,
so remove the second declaration.

Signed-off-by: WangJinchao <[email protected]>
---
kernel/sched/sched.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 2e5a95486a42..349c90554bd8 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -931,7 +931,6 @@ struct uclamp_rq {
DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
#endif /* CONFIG_UCLAMP_TASK */

-struct rq;
struct balance_callback {
struct balance_callback *next;
void (*func)(struct rq *rq);
--
2.40.0

2023-12-12 22:27:00

by Tim Chen

Subject: Re: [PATCH] sched/headers: Remove duplicated struct rq declare

On Thu, 2023-12-07 at 20:19 +0800, WangJinchao wrote:
> `struct rq` has been declared at the top of the file,
> so remove the second declaration.
>
> Signed-off-by: WangJinchao <[email protected]>
> ---
> kernel/sched/sched.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 2e5a95486a42..349c90554bd8 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -931,7 +931,6 @@ struct uclamp_rq {
> DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
> #endif /* CONFIG_UCLAMP_TASK */
>
> -struct rq;
> struct balance_callback {
> struct balance_callback *next;
> void (*func)(struct rq *rq);

Reviewed-by: Tim Chen <[email protected]>

Tim

2023-12-18 13:51:29

by Vincent Guittot

Subject: Re: [PATCH] sched/headers: Remove duplicated struct rq declare

On Thu, 7 Dec 2023 at 13:20, WangJinchao <[email protected]> wrote:
>
> `struct rq` has been declared at the top of the file,
> so remove the second declaration.
>
> Signed-off-by: WangJinchao <[email protected]>

Reviewed-by: Vincent Guittot <[email protected]>

> ---
> kernel/sched/sched.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 2e5a95486a42..349c90554bd8 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -931,7 +931,6 @@ struct uclamp_rq {
> DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
> #endif /* CONFIG_UCLAMP_TASK */
>
> -struct rq;
> struct balance_callback {
> struct balance_callback *next;
> void (*func)(struct rq *rq);
> --
> 2.40.0
>