2021-04-21 13:10:10

by Greg Kroah-Hartman

Subject: [PATCH 046/190] Revert "net/mlx4_core: fix a memory leak bug."

This reverts commit febfd9d3c7f74063e8e630b15413ca91b567f963.

Commits from @umn.edu addresses have been found to be submitted in "bad
faith" to try to test the kernel community's ability to review "known
malicious" changes. The result of these submissions can be found in a
paper published at the 42nd IEEE Symposium on Security and Privacy
entitled, "Open Source Insecurity: Stealthily Introducing
Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
of Minnesota) and Kangjie Lu (University of Minnesota).

Because of this, all submissions from this group must be reverted from
the kernel tree and will need to be re-reviewed again to determine if
they actually are a valid fix. Until that work is complete, remove this
change to ensure that no problems are being introduced into the
codebase.

Cc: Qiushi Wu <[email protected]>
Cc: David S. Miller <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
index f6cfec81ccc3..380e027ba5df 100644
--- a/drivers/net/ethernet/mellanox/mlx4/fw.c
+++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
@@ -2734,7 +2734,7 @@ void mlx4_opreq_action(struct work_struct *work)
if (err) {
mlx4_err(dev, "Failed to retrieve required operation: %d\n",
err);
- goto out;
+ return;
}
MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET);
MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET);
--
2.31.1

2021-04-22 01:30:29

by Jakub Kicinski

Subject: Re: [PATCH 046/190] Revert "net/mlx4_core: fix a memory leak bug."

(replying from the archive)

> This reverts commit febfd9d3c7f74063e8e630b15413ca91b567f963.

CCing Tariq on this one, unless there is some deep magic this one looks
okay, too.

2021-04-26 11:20:04

by Tariq Toukan

Subject: Re: [PATCH 046/190] Revert "net/mlx4_core: fix a memory leak bug."

On 4/21/2021 3:58 PM, Greg Kroah-Hartman wrote:
> This reverts commit febfd9d3c7f74063e8e630b15413ca91b567f963.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Qiushi Wu <[email protected]>
> Cc: David S. Miller <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
> drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
> index f6cfec81ccc3..380e027ba5df 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/fw.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
> @@ -2734,7 +2734,7 @@ void mlx4_opreq_action(struct work_struct *work)
> if (err) {
> mlx4_err(dev, "Failed to retrieve required operation: %d\n",
> err);
> - goto out;
> + return;
> }
> MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET);
> MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET);
>

Reviewed-by: Tariq Toukan <[email protected]>

The original commit febfd9d3c7f74063e8e630b15413ca91b567f963 is a bad
commit. Not to be re-submitted.

Regards,
Tariq

2021-04-27 13:01:07

by Greg Kroah-Hartman

Subject: Re: [PATCH 046/190] Revert "net/mlx4_core: fix a memory leak bug."

On Mon, Apr 26, 2021 at 02:18:37PM +0300, Tariq Toukan wrote:
>
>
> On 4/21/2021 3:58 PM, Greg Kroah-Hartman wrote:
> > This reverts commit febfd9d3c7f74063e8e630b15413ca91b567f963.
> >
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes. The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> >
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix. Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> >
> > Cc: Qiushi Wu <[email protected]>
> > Cc: David S. Miller <[email protected]>
> > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> > ---
> > drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
> > index f6cfec81ccc3..380e027ba5df 100644
> > --- a/drivers/net/ethernet/mellanox/mlx4/fw.c
> > +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
> > @@ -2734,7 +2734,7 @@ void mlx4_opreq_action(struct work_struct *work)
> > if (err) {
> > mlx4_err(dev, "Failed to retrieve required operation: %d\n",
> > err);
> > - goto out;
> > + return;
> > }
> > MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET);
> > MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET);
> >
>
> Reviewed-by: Tariq Toukan <[email protected]>
>
> The original commit febfd9d3c7f74063e8e630b15413ca91b567f963 is a bad
> commit. Not to be re-submitted.

Thanks for the review, will keep!

greg k-h

2021-04-29 17:18:11

by Greg Kroah-Hartman

Subject: Re: [PATCH 046/190] Revert "net/mlx4_core: fix a memory leak bug."

On Tue, Apr 27, 2021 at 03:00:08PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 26, 2021 at 02:18:37PM +0300, Tariq Toukan wrote:
> >
> >
> > On 4/21/2021 3:58 PM, Greg Kroah-Hartman wrote:
> > > This reverts commit febfd9d3c7f74063e8e630b15413ca91b567f963.
> > >
> > > Commits from @umn.edu addresses have been found to be submitted in "bad
> > > faith" to try to test the kernel community's ability to review "known
> > > malicious" changes. The result of these submissions can be found in a
> > > paper published at the 42nd IEEE Symposium on Security and Privacy
> > > entitled, "Open Source Insecurity: Stealthily Introducing
> > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > > of Minnesota) and Kangjie Lu (University of Minnesota).
> > >
> > > Because of this, all submissions from this group must be reverted from
> > > the kernel tree and will need to be re-reviewed again to determine if
> > > they actually are a valid fix. Until that work is complete, remove this
> > > change to ensure that no problems are being introduced into the
> > > codebase.
> > >
> > > Cc: Qiushi Wu <[email protected]>
> > > Cc: David S. Miller <[email protected]>
> > > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> > > ---
> > > drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
> > > index f6cfec81ccc3..380e027ba5df 100644
> > > --- a/drivers/net/ethernet/mellanox/mlx4/fw.c
> > > +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
> > > @@ -2734,7 +2734,7 @@ void mlx4_opreq_action(struct work_struct *work)
> > > if (err) {
> > > mlx4_err(dev, "Failed to retrieve required operation: %d\n",
> > > err);
> > > - goto out;
> > > + return;
> > > }
> > > MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET);
> > > MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET);
> > >
> >
> > Reviewed-by: Tariq Toukan <[email protected]>
> >
> > The original commit febfd9d3c7f74063e8e630b15413ca91b567f963 is a bad
> > commit. Not to be re-submitted.
>
> Thanks for the review, will keep!

In looking closer (well, Atul looked closer after I asked them too), it
seems that the original commit is ok, so I'm going to drop this revert
from my tree.

Tariq, unless you can point out the problem you see here?

thanks,

greg k-h

2021-05-09 10:23:11

by Tariq Toukan

Subject: Re: [PATCH 046/190] Revert "net/mlx4_core: fix a memory leak bug."

On 4/27/2021 4:00 PM, Greg Kroah-Hartman wrote:
> On Mon, Apr 26, 2021 at 02:18:37PM +0300, Tariq Toukan wrote:
>>
>>
>> On 4/21/2021 3:58 PM, Greg Kroah-Hartman wrote:
>>> This reverts commit febfd9d3c7f74063e8e630b15413ca91b567f963.
>>>
>>> Commits from @umn.edu addresses have been found to be submitted in "bad
>>> faith" to try to test the kernel community's ability to review "known
>>> malicious" changes. The result of these submissions can be found in a
>>> paper published at the 42nd IEEE Symposium on Security and Privacy
>>> entitled, "Open Source Insecurity: Stealthily Introducing
>>> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
>>> of Minnesota) and Kangjie Lu (University of Minnesota).
>>>
>>> Because of this, all submissions from this group must be reverted from
>>> the kernel tree and will need to be re-reviewed again to determine if
>>> they actually are a valid fix. Until that work is complete, remove this
>>> change to ensure that no problems are being introduced into the
>>> codebase.
>>>
>>> Cc: Qiushi Wu <[email protected]>
>>> Cc: David S. Miller <[email protected]>
>>> Signed-off-by: Greg Kroah-Hartman <[email protected]>
>>> ---
>>> drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
>>> index f6cfec81ccc3..380e027ba5df 100644
>>> --- a/drivers/net/ethernet/mellanox/mlx4/fw.c
>>> +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
>>> @@ -2734,7 +2734,7 @@ void mlx4_opreq_action(struct work_struct *work)
>>> if (err) {
>>> mlx4_err(dev, "Failed to retrieve required operation: %d\n",
>>> err);
>>> - goto out;
>>> + return;
>>> }
>>> MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET);
>>> MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET);
>>>
>>
>> Reviewed-by: Tariq Toukan <[email protected]>
>>
>> The original commit febfd9d3c7f74063e8e630b15413ca91b567f963 is a bad
>> commit. Not to be re-submitted.
>
> Thanks for the review, will keep!
>
> greg k-h
>

Hi Greg,

I got confused with another error handling code in same function.

After a second look, original commit
febfd9d3c7f74063e8e630b15413ca91b567f963 looks fine to me.

Regards,
Tariq

2021-05-09 11:16:25

by Greg Kroah-Hartman

Subject: Re: [PATCH 046/190] Revert "net/mlx4_core: fix a memory leak bug."

On Sun, May 09, 2021 at 01:19:37PM +0300, Tariq Toukan wrote:
>
>
> On 4/27/2021 4:00 PM, Greg Kroah-Hartman wrote:
> > On Mon, Apr 26, 2021 at 02:18:37PM +0300, Tariq Toukan wrote:
> > >
> > >
> > > On 4/21/2021 3:58 PM, Greg Kroah-Hartman wrote:
> > > > This reverts commit febfd9d3c7f74063e8e630b15413ca91b567f963.
> > > >
> > > > Commits from @umn.edu addresses have been found to be submitted in "bad
> > > > faith" to try to test the kernel community's ability to review "known
> > > > malicious" changes. The result of these submissions can be found in a
> > > > paper published at the 42nd IEEE Symposium on Security and Privacy
> > > > entitled, "Open Source Insecurity: Stealthily Introducing
> > > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > > > of Minnesota) and Kangjie Lu (University of Minnesota).
> > > >
> > > > Because of this, all submissions from this group must be reverted from
> > > > the kernel tree and will need to be re-reviewed again to determine if
> > > > they actually are a valid fix. Until that work is complete, remove this
> > > > change to ensure that no problems are being introduced into the
> > > > codebase.
> > > >
> > > > Cc: Qiushi Wu <[email protected]>
> > > > Cc: David S. Miller <[email protected]>
> > > > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> > > > ---
> > > > drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
> > > > index f6cfec81ccc3..380e027ba5df 100644
> > > > --- a/drivers/net/ethernet/mellanox/mlx4/fw.c
> > > > +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
> > > > @@ -2734,7 +2734,7 @@ void mlx4_opreq_action(struct work_struct *work)
> > > > if (err) {
> > > > mlx4_err(dev, "Failed to retrieve required operation: %d\n",
> > > > err);
> > > > - goto out;
> > > > + return;
> > > > }
> > > > MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET);
> > > > MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET);
> > > >
> > >
> > > Reviewed-by: Tariq Toukan <[email protected]>
> > >
> > > The original commit febfd9d3c7f74063e8e630b15413ca91b567f963 is a bad
> > > commit. Not to be re-submitted.
> >
> > Thanks for the review, will keep!
> >
> > greg k-h
> >
>
> Hi Greg,
>
> I got confused with another error handling code in same function.
>
> After a second look, original commit
> febfd9d3c7f74063e8e630b15413ca91b567f963 looks fine to me.

Thanks for the information, and the re-review.

greg k-h