Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_core_mode_support':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:8229:1: error: the frame size of 2736 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
8229 | } // dml_core_mode_support
| ^
cc1: all warnings being treated as errors
Caused by commit
7966f319c66d ("drm/amd/display: Introduce DML2")
(or maybe something later that changed storage size).
I have used the amdgpu tree from next-20231009 for today.
--
Cheers,
Stephen Rothwell
On 10/9/23 19:43, Stephen Rothwell wrote:
> Hi all,
>
> After merging the amdgpu tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_core_mode_support':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:8229:1: error: the frame size of 2736 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> 8229 | } // dml_core_mode_support
> | ^
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 7966f319c66d ("drm/amd/display: Introduce DML2")
>
> (or maybe something later that changed storage size).
>
> I have used the amdgpu tree from next-20231009 for today.
>
Hi Stephen,
(+ others)
I think I have a fix for that, but some things are unclear to me. I'm
only able to see this issue when using allmodconfig. Additionally, when
I inspected the function, it had a few local variables, not enough to
explode the stack size fwiu. Is there any option in the allmodconfig
that makes it easy to see this issue? Maybe something that I'm missing
in my custom config file? Is it possible that allmodconfig enables some
option that might increase the stack size? Perhaps the FPU flags from
GCC include something else in the stack?
Also, for investigating this issue, I'm considering the local variables,
but as you can see from dml_core_mode_support, it has a few pointers. Am
I missing something?
P.s.: I was able to fix this issue by splitting two operations from the
original function.
Thanks
Siqueira
Hi Rodrigo,
On Tue, 10 Oct 2023 15:14:46 -0600 Rodrigo Siqueira Jordao <[email protected]> wrote:
>
> I think I have a fix for that, but some things are unclear to me. I'm
> only able to see this issue when using allmodconfig. Additionally,
> when I inspected the function, it had a few local variables, not
> enough to explode the stack size fwiu. Is there any option in the
> allmodconfig that makes it easy to see this issue? Maybe something
> that I'm missing in my custom config file? Is it possible that
> allmodconfig enables some option that might increase the stack size?
> Perhaps the FPU flags from GCC include something else in the stack?
>
> Also, for investigating this issue, I'm considering the local
> variables, but as you can see from dml_core_mode_support, it has a
> few pointers. Am I missing something?
This could possibly be caused by inlining of other functions that are
static within the same file.
Other than that, I am also at a loss.
--
Cheers,
Stephen Rothwell
Hi all,
On Tue, 10 Oct 2023 12:43:57 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the amdgpu tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_core_mode_support':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:8229:1: error: the frame size of 2736 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> 8229 | } // dml_core_mode_support
> | ^
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 7966f319c66d ("drm/amd/display: Introduce DML2")
>
> (or maybe something later that changed storage size).
>
> I have used the amdgpu tree from next-20231009 for today.
I am still getting this failure.
--
Cheers,
Stephen Rothwell
On 10/15/23 18:39, Stephen Rothwell wrote:
> Hi Rodrigo,
>
> On Tue, 10 Oct 2023 15:14:46 -0600 Rodrigo Siqueira Jordao <[email protected]> wrote:
>>
>> I think I have a fix for that, but some things are unclear to me. I'm
>> only able to see this issue when using allmodconfig. Additionally,
>> when I inspected the function, it had a few local variables, not
>> enough to explode the stack size fwiu. Is there any option in the
>> allmodconfig that makes it easy to see this issue? Maybe something
>> that I'm missing in my custom config file? Is it possible that
>> allmodconfig enables some option that might increase the stack size?
>> Perhaps the FPU flags from GCC include something else in the stack?
>>
>> Also, for investigating this issue, I'm considering the local
>> variables, but as you can see from dml_core_mode_support, it has a
>> few pointers. Am I missing something?
>
> This could possibly be caused by inlining of other functions that are
> static within the same file.
>
> Other than that, I am also at a loss.
Hi Stephen,
Could you try this patchset?
https://lore.kernel.org/amd-gfx/[email protected]/T/#t
Thanks
Siqueira
Hi Rodrigo,
On Mon, 16 Oct 2023 08:53:05 -0600 Rodrigo Siqueira Jordao <[email protected]> wrote:
>
> Could you try this patchset?
>
> https://lore.kernel.org/amd-gfx/[email protected]/T/#t
I will apply that to the merge of the amdgpu tree today.
--
Cheers,
Stephen Rothwell
Hi Stephen,
On Tue, 17 Oct 2023 07:59:06 +1100 Stephen Rothwell <[email protected]> wrote:
>
> Hi Rodrigo,
>
> On Mon, 16 Oct 2023 08:53:05 -0600 Rodrigo Siqueira Jordao <[email protected]> wrote:
> >
> > Could you try this patchset?
> >
> > https://lore.kernel.org/amd-gfx/[email protected]/T/#t
>
> I will apply that to the merge of the amdgpu tree today.
That fixed the build problem.
Tested-by: Stephen Rothwell <[email protected]>
--
Cheers,
Stephen Rothwell
Hi all,
On Tue, 10 Oct 2023 12:43:57 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the amdgpu tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_core_mode_support':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:8229:1: error: the frame size of 2736 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> 8229 | } // dml_core_mode_support
> | ^
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 7966f319c66d ("drm/amd/display: Introduce DML2")
>
> (or maybe something later that changed storage size).
>
> I have used the amdgpu tree from next-20231009 for today.
This build failure now (presumably) exists in the drm tree. I am still
applying the 2 patches from Rodrigo to my tree as a work around.
I would have expected that this was fixed in the amdgpu tree before
Dave was asked to merge it ...
--
Cheers,
Stephen Rothwell
Hi all,
On Thu, 19 Oct 2023 12:06:18 +1100 Stephen Rothwell <[email protected]> wrote:
>
> On Tue, 10 Oct 2023 12:43:57 +1100 Stephen Rothwell <[email protected]> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_core_mode_support':
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:8229:1: error: the frame size of 2736 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > 8229 | } // dml_core_mode_support
> > | ^
> > cc1: all warnings being treated as errors
> >
> > Caused by commit
> >
> > 7966f319c66d ("drm/amd/display: Introduce DML2")
> >
> > (or maybe something later that changed storage size).
> >
> > I have used the amdgpu tree from next-20231009 for today.
>
> This build failure now (presumably) exists in the drm tree. I am still
> applying the 2 patches from Rodrigo to my tree as a work around.
>
> I would have expected that this was fixed in the amdgpu tree before
> Dave was asked to merge it ...
Any progress here? I am still applying the 2 patches.
--
Cheers,
Stephen Rothwell
On Mon, Oct 23, 2023 at 8:59 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> On Thu, 19 Oct 2023 12:06:18 +1100 Stephen Rothwell <[email protected]> wrote:
> >
> > On Tue, 10 Oct 2023 12:43:57 +1100 Stephen Rothwell <[email protected]> wrote:
> > >
> > > After merging the amdgpu tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_core_mode_support':
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:8229:1: error: the frame size of 2736 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > > 8229 | } // dml_core_mode_support
> > > | ^
> > > cc1: all warnings being treated as errors
> > >
> > > Caused by commit
> > >
> > > 7966f319c66d ("drm/amd/display: Introduce DML2")
> > >
> > > (or maybe something later that changed storage size).
> > >
> > > I have used the amdgpu tree from next-20231009 for today.
> >
> > This build failure now (presumably) exists in the drm tree. I am still
> > applying the 2 patches from Rodrigo to my tree as a work around.
> >
> > I would have expected that this was fixed in the amdgpu tree before
> > Dave was asked to merge it ...
>
> Any progress here? I am still applying the 2 patches.
The two patches are in my -next tree and in the PR I sent last week.
Alex
On Tue, Oct 24, 2023 at 8:57 AM Alex Deucher <[email protected]> wrote:
>
> On Mon, Oct 23, 2023 at 8:59 PM Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > On Thu, 19 Oct 2023 12:06:18 +1100 Stephen Rothwell <[email protected]> wrote:
> > >
> > > On Tue, 10 Oct 2023 12:43:57 +1100 Stephen Rothwell <[email protected]> wrote:
> > > >
> > > > After merging the amdgpu tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > >
> > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_core_mode_support':
> > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:8229:1: error: the frame size of 2736 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > > > 8229 | } // dml_core_mode_support
> > > > | ^
> > > > cc1: all warnings being treated as errors
> > > >
> > > > Caused by commit
> > > >
> > > > 7966f319c66d ("drm/amd/display: Introduce DML2")
> > > >
> > > > (or maybe something later that changed storage size).
> > > >
> > > > I have used the amdgpu tree from next-20231009 for today.
> > >
> > > This build failure now (presumably) exists in the drm tree. I am still
> > > applying the 2 patches from Rodrigo to my tree as a work around.
> > >
> > > I would have expected that this was fixed in the amdgpu tree before
> > > Dave was asked to merge it ...
> >
> > Any progress here? I am still applying the 2 patches.
>
> The two patches are in my -next tree and in the PR I sent last week.
Looks like the gitlab migration over the weekend lost some history.
I've fixed it up.
Alex
Hi Alex,
On Tue, 24 Oct 2023 08:57:16 -0400 Alex Deucher <[email protected]> wrote:
>
> The two patches are in my -next tree and in the PR I sent last week.
Thanks.
--
Cheers,
Stephen Rothwell