2008-01-11 18:17:37

by Alan

Subject: [PATCH] serverworks: IRQ routing needs no _p

I can find no reason for the _p on the serverworks IRQ routing logic, and
a review of the documentation contains no indication that any such delay
is needed so lets try this

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc6-mm1/arch/x86/pci/irq.c linux-2.6.24-rc6-mm1/arch/x86/pci/irq.c
--- linux.vanilla-2.6.24-rc6-mm1/arch/x86/pci/irq.c 2008-01-02 16:04:19.000000000 +0000
+++ linux-2.6.24-rc6-mm1/arch/x86/pci/irq.c 2008-01-11 15:21:17.000000000 +0000
@@ -461,14 +461,14 @@
*/
static int pirq_serverworks_get(struct pci_dev *router, struct pci_dev *dev, int pirq)
{
- outb_p(pirq, 0xc00);
+ outb(pirq, 0xc00);
return inb(0xc01) & 0xf;
}

static int pirq_serverworks_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq)
{
- outb_p(pirq, 0xc00);
- outb_p(irq, 0xc01);
+ outb(pirq, 0xc00);
+ outb(irq, 0xc01);
return 1;
}

2008-01-11 23:18:51

by Zachary Amsden

Subject: Re: [PATCH] serverworks: IRQ routing needs no _p

On Fri, 2008-01-11 at 18:14 +0000, Alan Cox wrote:
> I can find no reason for the _p on the serverworks IRQ routing logic, and
> a review of the documentation contains no indication that any such delay
> is needed so lets try this
>

Looks good to me; unfortunately my Serverworks boxes got upgraded so I
can't test, but install base is really big.

Acked-by: Zachary Amsden <[email protected]>

2008-01-14 15:52:35

by Ingo Molnar

Subject: Re: [PATCH] serverworks: IRQ routing needs no _p

* Alan Cox <[email protected]> wrote:

> I can find no reason for the _p on the serverworks IRQ routing logic,
> and a review of the documentation contains no indication that any such
> delay is needed so lets try this

thanks, applied to x86.git.

Ingo