2008-10-22 03:28:18

by Harvey Harrison

Subject: [PATCH] sound: correct bracketing in spdif test

Noticed by sparse:
sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y

Signed-off-by: Harvey Harrison <[email protected]>
---
sound/pci/hda/patch_sigmatel.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index a2ac720..788fdc6 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
return err;
spec->multiout.share_spdif = 1;
}
- if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
+ if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
if (err < 0)
return err;
--
1.6.0.2.824.geb4d2

2008-10-22 03:38:48

by Matthew Ranostay

Subject: Re: [PATCH] sound: correct bracketing in spdif test

Harvey Harrison wrote:
> Noticed by sparse:
> sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y
>
> Signed-off-by: Harvey Harrison <[email protected]>
> ---
> sound/pci/hda/patch_sigmatel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index a2ac720..788fdc6 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
> return err;
> spec->multiout.share_spdif = 1;
> }
> - if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
> + if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
> err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
> if (err < 0)
> return err;

Thanks for finding this.


Acked-by: Matthew Ranostay <[email protected]>

2008-10-22 06:02:21

by Takashi Iwai

Subject: Re: [PATCH] sound: correct bracketing in spdif test

At Tue, 21 Oct 2008 23:38:31 -0400,
Matthew Ranostay wrote:
>
> Harvey Harrison wrote:
> > Noticed by sparse:
> > sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y
> >
> > Signed-off-by: Harvey Harrison <[email protected]>
> > ---
> > sound/pci/hda/patch_sigmatel.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> > index a2ac720..788fdc6 100644
> > --- a/sound/pci/hda/patch_sigmatel.c
> > +++ b/sound/pci/hda/patch_sigmatel.c
> > @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
> > return err;
> > spec->multiout.share_spdif = 1;
> > }
> > - if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
> > + if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
> > err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
> > if (err < 0)
> > return err;
>
> Thanks for finding this.
>
>
> Acked-by: Matthew Ranostay <[email protected]>

Applied now. Thanks!

Takashi