2023-07-12 11:24:38

by Alejandro Tafalla

[permalink] [raw]

Subject: [PATCH] iio: imu: lsm6dsx: Fix mount matrix retrieval

---

The function lsm6dsx_get_acpi_mount_matrix should return true when ACPI
support is not enabled to allow executing iio_read_mount_matrix in the
probe function.

Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")

Signed-off-by: Alejandro Tafalla <[email protected]>
---
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/
st_lsm6dsx/st_lsm6dsx_core.c
index 6a18b363cf73..62bc3ee783fb 100644
--- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
+++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
@@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct device
*dev,
static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
struct
iio_mount_matrix *orientation)
{
- return false;
+ return true;
}

#endif
--
2.41.0

2023-07-12 11:37:39

by Lorenzo Bianconi

[permalink] [raw]

Subject: Re: [PATCH] iio: imu: lsm6dsx: Fix mount matrix retrieval

---

> The function lsm6dsx_get_acpi_mount_matrix should return true when ACPI
> support is not enabled to allow executing iio_read_mount_matrix in the
> probe function.
>
> Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")
>
> Signed-off-by: Alejandro Tafalla <[email protected]>
> ---
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/
> st_lsm6dsx/st_lsm6dsx_core.c
> index 6a18b363cf73..62bc3ee783fb 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct device
> *dev,
> static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> struct
> iio_mount_matrix *orientation)
> {
> - return false;
> + return true;

I would say it should return something like -EOPNOTSUPP.

Regards,
Lorenzo

> }
>
> #endif
> --
> 2.41.0
>
>
>
>

---

Attachments:

(No filename) (1.05 kB)
signature.asc (235.00 B)
Download all attachments

2023-07-12 18:55:34

by Alejandro Tafalla

[permalink] [raw]

Subject: Re: [PATCH] iio: imu: lsm6dsx: Fix mount matrix retrieval

---

On miércoles, 12 de julio de 2023 13:04:05 (CEST) Lorenzo Bianconi wrote:
> > The function lsm6dsx_get_acpi_mount_matrix should return true when ACPI
> > support is not enabled to allow executing iio_read_mount_matrix in the
> > probe function.
> >
> > Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")
> >
> > Signed-off-by: Alejandro Tafalla <[email protected]>
> > ---
> >
> > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > b/drivers/iio/imu/ st_lsm6dsx/st_lsm6dsx_core.c
> > index 6a18b363cf73..62bc3ee783fb 100644
> > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct
> > device *dev,
> >
> > static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> >
> > struct
> >
> > iio_mount_matrix *orientation)
> >
> > {
> >
> > - return false;
> > + return true;
>
> I would say it should return something like -EOPNOTSUPP.
>
> Regards,
> Lorenzo
>
> > }
> >
> > #endif

Hi, thank you for the review. I'll send a v2 with a better solution that uses
error codes.

Alejandro.