2013-08-16 08:53:44

by Alban Browaeys

Subject: usb: misc: usb3503: connect and intn mismatch in OF vs variable assignments

hub->gpio_intn? = of_get_named_gpio(np, "connect-gpios", 0);
and
hub->gpio_connect = of_get_named_gpio(np, "intn-gpios", 0);

I guess they should be switched , that is connect-gpios bound to hub->gpio_connect
and intn-gpios to hub->gpio_int.

Sorry not to provides a patch. I thought that this issue might ends up with dts relying
on this broken behaviour if not pointed early ...
Either way if not fixed soon , I will have completed my branch cleanup (I also have other patches
to this file ie drivers/usb/misc/usb3503.c).

Best regards
Alban

2013-08-16 09:46:01

by Dongjin Kim

Subject: Re: usb: misc: usb3503: connect and intn mismatch in OF vs variable assignments

Hi,

The patch is submitted by Mark Brown a week ago, and might be queued already.

[1] http://www.spinics.net/lists/linux-usb/msg91410.html

Thanks,
Dongjin.

On Fri, Aug 16, 2013 at 5:53 PM, Alban Browaeys <[email protected]> wrote:
> hub->gpio_intn = of_get_named_gpio(np, "connect-gpios", 0);
> and
> hub->gpio_connect = of_get_named_gpio(np, "intn-gpios", 0);
>
> I guess they should be switched , that is connect-gpios bound to hub->gpio_connect
> and intn-gpios to hub->gpio_int.
>
> Sorry not to provides a patch. I thought that this issue might ends up with dts relying
> on this broken behaviour if not pointed early ...
> Either way if not fixed soon , I will have completed my branch cleanup (I also have other patches
> to this file ie drivers/usb/misc/usb3503.c).
>
> Best regards
> Alban
>