2014-07-06 17:26:07

by Rickard Strandqvist

Subject: [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter

Remove assignment of function parameter, that has no effect outside the function

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/video/fbdev/xen-fbfront.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index 901014b..e1207a1 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
red = CNVT_TOHW(red, info->var.red.length);
green = CNVT_TOHW(green, info->var.green.length);
blue = CNVT_TOHW(blue, info->var.blue.length);
- transp = CNVT_TOHW(transp, info->var.transp.length);
#undef CNVT_TOHW

v = (red << info->var.red.offset) |
--
1.7.10.4

2014-07-07 10:21:27

by Stefano Stabellini

Subject: Re: [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter

On Sun, 6 Jul 2014, Rickard Strandqvist wrote:
> Remove assignment of function parameter, that has no effect outside the function
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <[email protected]>

Acked-by: Stefano Stabellini <[email protected]>


> drivers/video/fbdev/xen-fbfront.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index 901014b..e1207a1 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
> red = CNVT_TOHW(red, info->var.red.length);
> green = CNVT_TOHW(green, info->var.green.length);
> blue = CNVT_TOHW(blue, info->var.blue.length);
> - transp = CNVT_TOHW(transp, info->var.transp.length);
> #undef CNVT_TOHW
>
> v = (red << info->var.red.offset) |
> --
> 1.7.10.4
>

2014-07-08 17:28:10

by Konrad Rzeszutek Wilk

Subject: Re: [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter

On Mon, Jul 07, 2014 at 11:20:39AM +0100, Stefano Stabellini wrote:
> On Sun, 6 Jul 2014, Rickard Strandqvist wrote:
> > Remove assignment of function parameter, that has no effect outside the function
> >
> > This was found using a static code analysis program called cppcheck
> >
> > Signed-off-by: Rickard Strandqvist <[email protected]>
>
> Acked-by: Stefano Stabellini <[email protected]>

and Reviewed-by: Konrad Rzeszutek Wilk <[email protected]>
>
>
> > drivers/video/fbdev/xen-fbfront.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> > index 901014b..e1207a1 100644
> > --- a/drivers/video/fbdev/xen-fbfront.c
> > +++ b/drivers/video/fbdev/xen-fbfront.c
> > @@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
> > red = CNVT_TOHW(red, info->var.red.length);
> > green = CNVT_TOHW(green, info->var.green.length);
> > blue = CNVT_TOHW(blue, info->var.blue.length);
> > - transp = CNVT_TOHW(transp, info->var.transp.length);
> > #undef CNVT_TOHW
> >
> > v = (red << info->var.red.offset) |
> > --
> > 1.7.10.4
> >