2015-06-19 06:00:16

by Abdul, Hussain (H.)

Subject: [PATCH 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence

From: Abdul Hussain <[email protected]>

This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.

Signed-off-by: Abdul Hussain <[email protected]>
---
drivers/staging/comedi/drivers/dmm32at.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
index bb2883c..958c0d4 100644
--- a/drivers/staging/comedi/drivers/dmm32at.c
+++ b/drivers/staging/comedi/drivers/dmm32at.c
@@ -607,11 +607,7 @@ static int dmm32at_attach(struct comedi_device *dev,

/* Digital I/O subdevice */
s = &dev->subdevices[2];
- ret = subdev_8255_init(dev, s, dmm32at_8255_io, DMM32AT_8255_IOBASE);
- if (ret)
- return ret;
-
- return 0;
+ return subdev_8255_init(dev, s, dmm32at_8255_io, DMM32AT_8255_IOBASE);
}

static struct comedi_driver dmm32at_driver = {
--
1.9.1

2015-06-19 06:00:24

by Abdul, Hussain (H.)

Subject: [PATCH 2/6] Staging: comedi: fl512: Simplify a trivial if-return sequence

From: Abdul Hussain <[email protected]>

This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.

Signed-off-by: Abdul Hussain <[email protected]>
---
drivers/staging/comedi/drivers/fl512.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c
index e1f4932..55cae61 100644
--- a/drivers/staging/comedi/drivers/fl512.c
+++ b/drivers/staging/comedi/drivers/fl512.c
@@ -136,11 +136,7 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
s->range_table = &range_fl512;
s->insn_write = fl512_ao_insn_write;

- ret = comedi_alloc_subdev_readback(s);
- if (ret)
- return ret;
-
- return 0;
+ return comedi_alloc_subdev_readback(s);
}

static struct comedi_driver fl512_driver = {
--
1.9.1

2015-06-19 06:00:35

by Abdul, Hussain (H.)

Subject: [PATCH 3/6] Staging: comedi: daqboard2000: Simplify a trivial if-return sequence

From: Abdul Hussain <[email protected]>

This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.

Signed-off-by: Abdul Hussain <[email protected]>
---
drivers/staging/comedi/drivers/daqboard2000.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
index 611b0a3..58d8d5f 100644
--- a/drivers/staging/comedi/drivers/daqboard2000.c
+++ b/drivers/staging/comedi/drivers/daqboard2000.c
@@ -713,12 +713,7 @@ static int daqboard2000_auto_attach(struct comedi_device *dev,
return result;

s = &dev->subdevices[2];
- result = subdev_8255_init(dev, s, daqboard2000_8255_cb,
- dioP2ExpansionIO8Bit);
- if (result)
- return result;
-
- return 0;
+ return subdev_8255_init(dev, s, daqboard2000_8255_cb, dioP2ExpansionIO8Bit);
}

static void daqboard2000_detach(struct comedi_device *dev)
--
1.9.1

2015-06-19 06:00:41

by Abdul, Hussain (H.)

Subject: [PATCH 4/6] Staging: comedi: dac02: Simplify a trivial if-return sequence

From: Abdul Hussain <[email protected]>

This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.

Signed-off-by: Abdul Hussain <[email protected]>
---
drivers/staging/comedi/drivers/dac02.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/dac02.c b/drivers/staging/comedi/drivers/dac02.c
index a6798ad..a562df4 100644
--- a/drivers/staging/comedi/drivers/dac02.c
+++ b/drivers/staging/comedi/drivers/dac02.c
@@ -130,11 +130,7 @@ static int dac02_attach(struct comedi_device *dev, struct comedi_devconfig *it)
s->range_table = &das02_ao_ranges;
s->insn_write = dac02_ao_insn_write;

- ret = comedi_alloc_subdev_readback(s);
- if (ret)
- return ret;
-
- return 0;
+ return comedi_alloc_subdev_readback(s);
}

static struct comedi_driver dac02_driver = {
--
1.9.1

2015-06-19 06:00:50

by Abdul, Hussain (H.)

Subject: [PATCH 5/6] Staging: comedi: ni_daq_dio24: Simplify a trivial if-return sequence

From: Abdul Hussain <[email protected]>

This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.

Signed-off-by: Abdul Hussain <[email protected]>
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c
index a208cb3..d9de83a 100644
--- a/drivers/staging/comedi/drivers/ni_daq_dio24.c
+++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c
@@ -55,11 +55,7 @@ static int dio24_auto_attach(struct comedi_device *dev,

/* 8255 dio */
s = &dev->subdevices[0];
- ret = subdev_8255_init(dev, s, NULL, 0x00);
- if (ret)
- return ret;
-
- return 0;
+ return subdev_8255_init(dev, s, NULL, 0x00);
}

static struct comedi_driver driver_dio24 = {
--
1.9.1

2015-06-19 06:00:57

by Abdul, Hussain (H.)

Subject: [PATCH 6/6] Staging: comedi: s626: Simplify a trivial if-return sequence

From: Abdul Hussain <[email protected]>

This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.

Signed-off-by: Abdul Hussain <[email protected]>
---
drivers/staging/comedi/drivers/s626.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index 781918d..35f0f67 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -2852,11 +2852,7 @@ static int s626_auto_attach(struct comedi_device *dev,
s->insn_read = s626_enc_insn_read;
s->insn_write = s626_enc_insn_write;

- ret = s626_initialize(dev);
- if (ret)
- return ret;
-
- return 0;
+ return s626_initialize(dev);
}

static void s626_detach(struct comedi_device *dev)
--
1.9.1

2015-06-19 06:08:13

by Abdul, Hussain (H.)

Subject: Re: [PATCH 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence

On Friday 19 June 2015 04:30 AM, [email protected] wrote:
> On Tue, Jun 16, 2015 at 02:03:44PM +0000, Abdul, Hussain (H.) wrote:
>> From: Abdul Hussain <[email protected]>
>>
>> This patch simplify a trivial if-return sequence. Possibly combine with
>> a preceding function call.
>>
>> Signed-off-by: Abdul Hussain <[email protected]>
> Always use scripts/get_maintainer.pl to properly cc the maintainers
> responsible for these drivers.
>
> Please fix this up and resend.
>
> thanks,
>
> greg k-h
>
Greg, I resent the patch set with all the maintainer in the CC.

Thanks,
Abdul

2015-06-19 14:08:26

by Sudip Mukherjee

Subject: Re: [PATCH 3/6] Staging: comedi: daqboard2000: Simplify a trivial if-return sequence

On Fri, Jun 19, 2015 at 06:00:06AM +0000, Abdul, Hussain (H.) wrote:
> From: Abdul Hussain <[email protected]>
>
> This patch simplify a trivial if-return sequence. Possibly combine with
> a preceding function call.
>
> Signed-off-by: Abdul Hussain <[email protected]>
> ---
<snip>
> - return 0;
> + return subdev_8255_init(dev, s, daqboard2000_8255_cb, dioP2ExpansionIO8Bit);
this is introducing new checkpatch warning about line over 80 characters

regards
sudip

2015-06-19 14:16:42

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence

On Fri, Jun 19, 2015 at 06:08:04AM +0000, Abdul, Hussain (H.) wrote:
> On Friday 19 June 2015 04:30 AM, [email protected] wrote:
> > On Tue, Jun 16, 2015 at 02:03:44PM +0000, Abdul, Hussain (H.) wrote:
> >> From: Abdul Hussain <[email protected]>
> >>
> >> This patch simplify a trivial if-return sequence. Possibly combine with
> >> a preceding function call.
> >>
> >> Signed-off-by: Abdul Hussain <[email protected]>
> > Always use scripts/get_maintainer.pl to properly cc the maintainers
> > responsible for these drivers.
> >
> > Please fix this up and resend.
> >
> > thanks,
> >
> > greg k-h
> >
> Greg, I resent the patch set with all the maintainer in the CC.

But you didn't label it as a v2, so now I have a bunch of duplicate
emails in my inbox :(

2015-06-22 07:14:34

by Abdul, Hussain (H.)

Subject: Re: [PATCH 3/6] Staging: comedi: daqboard2000: Simplify a trivial if-return sequence

On Friday 19 June 2015 07:38 PM, Sudip Mukherjee wrote:
> On Fri, Jun 19, 2015 at 06:00:06AM +0000, Abdul, Hussain (H.) wrote:
>> From: Abdul Hussain <[email protected]>
>>
>> This patch simplify a trivial if-return sequence. Possibly combine with
>> a preceding function call.
>>
>> Signed-off-by: Abdul Hussain <[email protected]>
>> ---
> <snip>
>> - return 0;
>> + return subdev_8255_init(dev, s, daqboard2000_8255_cb, dioP2ExpansionIO8Bit);
> this is introducing new checkpatch warning about line over 80 characters
>
> regards
> sudip
>
Sudip,

I addressed the above issue and resent the patch set v2.

Thanks,
Abdul