2016-04-05 19:06:21

by Dave Gerlach

Subject: [PATCH] cpuidle: Indicate when a device has been unregistered

Currently the 'registered' member of the cpuidle_device struct is set
to 1 during cpuidle_register_device. In this same function there are
checks to see if the device is already registered to prevent duplicate
calls to register the device, but this value is never set to 0 even on
unregister of the device. Because of this, any attempt to call
cpuidle_register_device after a call to cpuidle_unregister_device will
fail which shouldn't be the case.

To prevent this, set registered to 0 when the device is unregistered.

Fixes: c878a52d3c7c ("cpuidle: Check if device is already registered")
Signed-off-by: Dave Gerlach <[email protected]>
---
drivers/cpuidle/cpuidle.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index f996efc56605..c2dd99ab1648 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -433,6 +433,8 @@ static void __cpuidle_unregister_device(struct cpuidle_device *dev)
list_del(&dev->device_list);
per_cpu(cpuidle_devices, dev->cpu) = NULL;
module_put(drv->owner);
+
+ dev->registered = 0;
}

static void __cpuidle_device_init(struct cpuidle_device *dev)
--
2.7.3

2016-04-06 19:00:55

by Daniel Lezcano

Subject: Re: [PATCH] cpuidle: Indicate when a device has been unregistered

On Tue, Apr 05, 2016 at 02:05:38PM -0500, Dave Gerlach wrote:
> Currently the 'registered' member of the cpuidle_device struct is set
> to 1 during cpuidle_register_device. In this same function there are
> checks to see if the device is already registered to prevent duplicate
> calls to register the device, but this value is never set to 0 even on
> unregister of the device. Because of this, any attempt to call
> cpuidle_register_device after a call to cpuidle_unregister_device will
> fail which shouldn't be the case.
>
> To prevent this, set registered to 0 when the device is unregistered.
>
> Fixes: c878a52d3c7c ("cpuidle: Check if device is already registered")
> Signed-off-by: Dave Gerlach <[email protected]>
> ---

Acked-by: Daniel Lezcano <[email protected]>

2016-04-22 00:38:05

by Rafael J. Wysocki

Subject: Re: [PATCH] cpuidle: Indicate when a device has been unregistered

On Wednesday, April 06, 2016 12:00:48 PM Daniel Lezcano wrote:
> On Tue, Apr 05, 2016 at 02:05:38PM -0500, Dave Gerlach wrote:
> > Currently the 'registered' member of the cpuidle_device struct is set
> > to 1 during cpuidle_register_device. In this same function there are
> > checks to see if the device is already registered to prevent duplicate
> > calls to register the device, but this value is never set to 0 even on
> > unregister of the device. Because of this, any attempt to call
> > cpuidle_register_device after a call to cpuidle_unregister_device will
> > fail which shouldn't be the case.
> >
> > To prevent this, set registered to 0 when the device is unregistered.
> >
> > Fixes: c878a52d3c7c ("cpuidle: Check if device is already registered")
> > Signed-off-by: Dave Gerlach <[email protected]>
> > ---
>
> Acked-by: Daniel Lezcano <[email protected]>

Applied, thanks!