2016-10-14 13:30:03

by Paul Bolle

Subject: Add "lightnvm: ensure that nvm_dev_ops can be used without CONFIG_NVM" to v4.4.y stable tree?

Hi,

I had a build of v4.4.24, with CONFIG_NVM not set, fail like this:
    drivers/block/null_blk.c:569:27: error: storage size of 'null_lnvm_dev_ops' isn't known
static struct nvm_dev_ops null_lnvm_dev_ops;
^~~~~~~~~~~~~~~~~
scripts/Makefile.build:264: recipe for target 'drivers/block/null_blk.o' failed
make[2]: *** [drivers/block/null_blk.o] Error 1
scripts/Makefile.build:403: recipe for target 'drivers/block' failed
make[1]: *** [drivers/block] Error 2
Makefile:959: recipe for target 'drivers' failed
make: *** [drivers] Error 2

Jens' commit a7fd9a4f3e81 ("lightnvm: ensure that nvm_dev_ops can be
used without CONFIG_NVM") fixed that for me (it did require a small
context change to get it applied to v4.4.24). Does it make sense to add
that commit to the v4.4.y stable tree?

Thanks,


Paul Bolle

2016-10-14 13:47:49

by Greg Kroah-Hartman

Subject: Re: Add "lightnvm: ensure that nvm_dev_ops can be used without CONFIG_NVM" to v4.4.y stable tree?

On Fri, Oct 14, 2016 at 03:28:41PM +0200, Paul Bolle wrote:
> Hi,
>
> I had a build of v4.4.24, with CONFIG_NVM not set, fail like this:
> ? ??drivers/block/null_blk.c:569:27: error: storage size of 'null_lnvm_dev_ops' isn't known
> static struct nvm_dev_ops null_lnvm_dev_ops;
> ^~~~~~~~~~~~~~~~~
> scripts/Makefile.build:264: recipe for target 'drivers/block/null_blk.o' failed
> make[2]: *** [drivers/block/null_blk.o] Error 1
> scripts/Makefile.build:403: recipe for target 'drivers/block' failed
> make[1]: *** [drivers/block] Error 2
> Makefile:959: recipe for target 'drivers' failed
> make: *** [drivers] Error 2
>
> Jens' commit a7fd9a4f3e81 ("lightnvm: ensure that nvm_dev_ops can be
> used without CONFIG_NVM") fixed that for me (it did require a small
> context change to get it applied to v4.4.24). Does it make sense to add
> that commit to the v4.4.y stable tree?

Makes sense to me, can you forward on a patch that applies cleanly and
I'll queue it up for the next round (after this one.)

thanks,

greg k-h

2016-10-14 16:30:50

by Paul Bolle

Subject: Re: Add "lightnvm: ensure that nvm_dev_ops can be used without CONFIG_NVM" to v4.4.y stable tree?

On Fri, 2016-10-14 at 15:47 +0200, Greg KH wrote:
> Makes sense to me, can you forward on a patch that applies cleanly and
> I'll queue it up for the next round (after this one.)

Hope to do that later today. If it turns out I've messed things up Jens
can still speak up.

Thanks,


Paul Bolle