2017-03-20 09:37:01

by Manish Narani

[permalink] [raw]

Subject: [PATCH] usb: gadget: Correct usb EP argument for BOT status request

---

This patch corrects the argument in usb_ep_free_request as it is
mistakenly set to ep_out. It should be ep_in for status request.

Signed-off-by: Manish Narani <[email protected]>
---
drivers/usb/gadget/function/f_tcm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
index d235113..a82e2bd 100644
--- a/drivers/usb/gadget/function/f_tcm.c
+++ b/drivers/usb/gadget/function/f_tcm.c
@@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)
usb_ep_free_request(fu->ep_in, fu->bot_req_in);
usb_ep_free_request(fu->ep_out, fu->bot_req_out);
usb_ep_free_request(fu->ep_out, fu->cmd.req);
- usb_ep_free_request(fu->ep_out, fu->bot_status.req);
+ usb_ep_free_request(fu->ep_in, fu->bot_status.req);

kfree(fu->cmd.buf);

--
1.7.1

2017-03-21 07:12:24

by Nicholas A. Bellinger

[permalink] [raw]

Subject: Re: [PATCH] usb: gadget: Correct usb EP argument for BOT status request

---

Hi Manish,

(Added target-devel CC')

On Mon, 2017-03-20 at 15:05 +0530, Manish Narani wrote:
> This patch corrects the argument in usb_ep_free_request as it is
> mistakenly set to ep_out. It should be ep_in for status request.
>
> Signed-off-by: Manish Narani <[email protected]>
> ---
> drivers/usb/gadget/function/f_tcm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
> index d235113..a82e2bd 100644
> --- a/drivers/usb/gadget/function/f_tcm.c
> +++ b/drivers/usb/gadget/function/f_tcm.c
> @@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)
> usb_ep_free_request(fu->ep_in, fu->bot_req_in);
> usb_ep_free_request(fu->ep_out, fu->bot_req_out);
> usb_ep_free_request(fu->ep_out, fu->cmd.req);
> - usb_ep_free_request(fu->ep_out, fu->bot_status.req);
> + usb_ep_free_request(fu->ep_in, fu->bot_status.req);
>
> kfree(fu->cmd.buf);
>

Applied to target-pending/master.

Thanks!

2017-03-22 09:38:01

by Felipe Balbi

[permalink] [raw]

Subject: Re: [PATCH] usb: gadget: Correct usb EP argument for BOT status request

---

Hi,

"Nicholas A. Bellinger" <[email protected]> writes:
> Hi Manish,
>
> (Added target-devel CC')
>
> On Mon, 2017-03-20 at 15:05 +0530, Manish Narani wrote:
>> This patch corrects the argument in usb_ep_free_request as it is
>> mistakenly set to ep_out. It should be ep_in for status request.
>>
>> Signed-off-by: Manish Narani <[email protected]>
>> ---
>> drivers/usb/gadget/function/f_tcm.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
>> index d235113..a82e2bd 100644
>> --- a/drivers/usb/gadget/function/f_tcm.c
>> +++ b/drivers/usb/gadget/function/f_tcm.c
>> @@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)
>> usb_ep_free_request(fu->ep_in, fu->bot_req_in);
>> usb_ep_free_request(fu->ep_out, fu->bot_req_out);
>> usb_ep_free_request(fu->ep_out, fu->cmd.req);
>> - usb_ep_free_request(fu->ep_out, fu->bot_status.req);
>> + usb_ep_free_request(fu->ep_in, fu->bot_status.req);
>>
>> kfree(fu->cmd.buf);
>>
>
> Applied to target-pending/master.

Oh, so you're taking patches for f_tcm? Fair enough:

Acked-by: Felipe Balbi <[email protected]>

--
balbi

---

Attachments:

signature.asc (832.00 B)