2017-08-11 13:25:32

by Yunlong Song

Subject: [PATCH] f2fs-tools: the overprovision should be 0 as default

The usage message gives a wrong number, so fix it.

Signed-off-by: Yunlong Song <[email protected]>
---
mkfs/f2fs_format_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
index a3652a9..6712b5c 100644
--- a/mkfs/f2fs_format_main.c
+++ b/mkfs/f2fs_format_main.c
@@ -41,7 +41,7 @@ static void mkfs_usage()
MSG(0, " -f force overwrite the exist filesystem\n");
MSG(0, " -l label\n");
MSG(0, " -m support zoned block device [default:0]\n");
- MSG(0, " -o overprovision ratio [default:5]\n");
+ MSG(0, " -o overprovision ratio [default:0]\n");
MSG(0, " -O [feature list] e.g. \"encrypt\"\n");
MSG(0, " -q quiet mode\n");
MSG(0, " -s # of segments per section [default:1]\n");
--
1.8.5.2

2017-08-15 03:24:29

by Jaegeuk Kim

Subject: Re: [PATCH] f2fs-tools: the overprovision should be 0 as default

On 08/11, Yunlong Song wrote:
> The usage message gives a wrong number, so fix it.
>
> Signed-off-by: Yunlong Song <[email protected]>
> ---
> mkfs/f2fs_format_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
> index a3652a9..6712b5c 100644
> --- a/mkfs/f2fs_format_main.c
> +++ b/mkfs/f2fs_format_main.c
> @@ -41,7 +41,7 @@ static void mkfs_usage()
> MSG(0, " -f force overwrite the exist filesystem\n");
> MSG(0, " -l label\n");
> MSG(0, " -m support zoned block device [default:0]\n");
> - MSG(0, " -o overprovision ratio [default:5]\n");
> + MSG(0, " -o overprovision ratio [default:0]\n");

We need to remove [default:xx], since the default is not fixed?

> MSG(0, " -O [feature list] e.g. \"encrypt\"\n");
> MSG(0, " -q quiet mode\n");
> MSG(0, " -s # of segments per section [default:1]\n");
> --
> 1.8.5.2

2017-08-15 07:42:17

by Yunlong Song

Subject: [PATCH v2] f2fs-tools: fix the usage message of overprovision option

The usage message shows a wrong message for ovp option, so fix it.

Signed-off-by: Yunlong Song <[email protected]>
---
mkfs/f2fs_format_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
index a3652a9..3279829 100644
--- a/mkfs/f2fs_format_main.c
+++ b/mkfs/f2fs_format_main.c
@@ -41,7 +41,7 @@ static void mkfs_usage()
MSG(0, " -f force overwrite the exist filesystem\n");
MSG(0, " -l label\n");
MSG(0, " -m support zoned block device [default:0]\n");
- MSG(0, " -o overprovision ratio [default:5]\n");
+ MSG(0, " -o overprovision ratio [initial value 0 lets mkfs determine its best value]\n");
MSG(0, " -O [feature list] e.g. \"encrypt\"\n");
MSG(0, " -q quiet mode\n");
MSG(0, " -s # of segments per section [default:1]\n");
--
1.8.5.2

2017-08-15 12:10:27

by Chao Yu

Subject: Re: [PATCH v2] f2fs-tools: fix the usage message of overprovision option

On 2017/8/15 15:41, Yunlong Song wrote:
> The usage message shows a wrong message for ovp option, so fix it.
>
> Signed-off-by: Yunlong Song <[email protected]>
> ---
> mkfs/f2fs_format_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
> index a3652a9..3279829 100644
> --- a/mkfs/f2fs_format_main.c
> +++ b/mkfs/f2fs_format_main.c
> @@ -41,7 +41,7 @@ static void mkfs_usage()
> MSG(0, " -f force overwrite the exist filesystem\n");
> MSG(0, " -l label\n");
> MSG(0, " -m support zoned block device [default:0]\n");
> - MSG(0, " -o overprovision ratio [default:5]\n");
> + MSG(0, " -o overprovision ratio [initial value 0 lets mkfs determine its best value]\n");

[mkfs decides, the value trends to maximize user visible space] ?

Thanks,

> MSG(0, " -O [feature list] e.g. \"encrypt\"\n");
> MSG(0, " -q quiet mode\n");
> MSG(0, " -s # of segments per section [default:1]\n");
>