2018-03-26 14:39:06

by Wei Yongjun

Subject: [PATCH -next] powerpc: Fix error return code in ppc4xx_msi_probe()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <[email protected]>
---
arch/powerpc/platforms/4xx/msi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/4xx/msi.c b/arch/powerpc/platforms/4xx/msi.c
index 4b859c8..0b71c52 100644
--- a/arch/powerpc/platforms/4xx/msi.c
+++ b/arch/powerpc/platforms/4xx/msi.c
@@ -241,7 +241,8 @@ static int ppc4xx_msi_probe(struct platform_device *dev)
if (!msi_irqs)
return -ENODEV;

- if (ppc4xx_setup_pcieh_hw(dev, res, msi))
+ err = ppc4xx_setup_pcieh_hw(dev, res, msi)
+ if (err)
goto error_out;

err = ppc4xx_msi_init_allocator(dev, msi);

2018-03-31 14:06:03

by Michael Ellerman

Subject: Re: [-next] powerpc: Fix error return code in ppc4xx_msi_probe()

On Mon, 2018-03-26 at 14:43:09 UTC, Wei Yongjun wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/9a2c1d31e6910b9d5e0205f9167d0b

cheers