2018-10-31 07:51:01

by Andy Tang

[permalink] [raw]
Subject: [PATCH v3] clk: qoriq: add more chips support

Add more chip-specific compatible strings to support more Socs.

Signed-off-by: Yuantian Tang <[email protected]>
---
v3:
- undo deleting old bindings
- split dts and driver code to different patchset
v2:
- remove all legacy code

drivers/clk/clk-qoriq.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
index 4c30b6e..5baa9e0 100644
--- a/drivers/clk/clk-qoriq.c
+++ b/drivers/clk/clk-qoriq.c
@@ -1418,12 +1418,23 @@ static void __init clockgen_init(struct device_node *np)

CLK_OF_DECLARE(qoriq_clockgen_1, "fsl,qoriq-clockgen-1.0", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_2, "fsl,qoriq-clockgen-2.0", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_b4420, "fsl,b4420-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_b4860, "fsl,b4860-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_ls1021a, "fsl,ls1021a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_p3041, "fsl,p3041-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_p5020, "fsl,p5020-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_p5040, "fsl,p5040-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_t1023, "fsl,t1023-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_t1040, "fsl,t1040-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_t2080, "fsl,t2080-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_t4240, "fsl,t4240-clockgen", clockgen_init);

/* Legacy nodes */
CLK_OF_DECLARE(qoriq_sysclk_1, "fsl,qoriq-sysclk-1.0", sysclk_init);
--
1.7.1



2018-11-06 17:25:54

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v3] clk: qoriq: add more chips support

Quoting Yuantian Tang (2018-10-31 00:46:16)
> diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
> index 4c30b6e..5baa9e0 100644
> --- a/drivers/clk/clk-qoriq.c
> +++ b/drivers/clk/clk-qoriq.c
> @@ -1418,12 +1418,23 @@ static void __init clockgen_init(struct device_node *np)
>
> CLK_OF_DECLARE(qoriq_clockgen_1, "fsl,qoriq-clockgen-1.0", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_2, "fsl,qoriq-clockgen-2.0", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_b4420, "fsl,b4420-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_b4860, "fsl,b4860-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_ls1021a, "fsl,ls1021a-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_p3041, "fsl,p3041-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_p5020, "fsl,p5020-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_p5040, "fsl,p5040-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_t1023, "fsl,t1023-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_t1040, "fsl,t1040-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_t2080, "fsl,t2080-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_t4240, "fsl,t4240-clockgen", clockgen_init);

Some of these compatibles aren't documented. What happened to the
binding patch to add more compatible strings?


2018-11-07 00:54:22

by Andy Tang

[permalink] [raw]
Subject: RE: [PATCH v3] clk: qoriq: add more chips support

Hi Stephen,

> -----Original Message-----
> From: Stephen Boyd <[email protected]>
> Sent: 2018年11月7日 1:25
> To: Andy Tang <[email protected]>; [email protected]
> Cc: [email protected]; [email protected]; Andy Tang
> <[email protected]>
> Subject: Re: [PATCH v3] clk: qoriq: add more chips support
>
> Quoting Yuantian Tang (2018-10-31 00:46:16)
> > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> > 4c30b6e..5baa9e0 100644
> > --- a/drivers/clk/clk-qoriq.c
> > +++ b/drivers/clk/clk-qoriq.c
> > @@ -1418,12 +1418,23 @@ static void __init clockgen_init(struct
> > device_node *np)
> >
> > CLK_OF_DECLARE(qoriq_clockgen_1, "fsl,qoriq-clockgen-1.0",
> > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_2,
> > "fsl,qoriq-clockgen-2.0", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_b4420, "fsl,b4420-clockgen",
> > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_b4860,
> > +"fsl,b4860-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen",
> > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1021a,
> > "fsl,ls1021a-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen",
> > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1046a,
> > "fsl,ls1046a-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen",
> > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls2080a,
> > "fsl,ls2080a-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen",
> > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p3041,
> > +"fsl,p3041-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen",
> > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p5020,
> > +"fsl,p5020-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_p5040, "fsl,p5040-clockgen",
> > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_t1023,
> > +"fsl,t1023-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_t1040, "fsl,t1040-clockgen",
> > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_t2080,
> > +"fsl,t2080-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_t4240, "fsl,t4240-clockgen",
> > +clockgen_init);
>
> Some of these compatibles aren't documented. What happened to the
> binding patch to add more compatible strings?
Nothing happened. Binding patch will be merged to PowerPC tree soon. But it will take time to
get to mainline tree or your tree.

BR,
Andy

2018-11-07 23:27:15

by Stephen Boyd

[permalink] [raw]
Subject: RE: [PATCH v3] clk: qoriq: add more chips support

Quoting Andy Tang (2018-11-06 16:52:19)
> Hi Stephen,
>
> > -----Original Message-----
> > From: Stephen Boyd <[email protected]>
> > Sent: 2018年11月7日 1:25
> > To: Andy Tang <[email protected]>; [email protected]
> > Cc: [email protected]; [email protected]; Andy Tang
> > <[email protected]>
> > Subject: Re: [PATCH v3] clk: qoriq: add more chips support
> >
> > Quoting Yuantian Tang (2018-10-31 00:46:16)
> > > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> > > 4c30b6e..5baa9e0 100644
> > > --- a/drivers/clk/clk-qoriq.c
> > > +++ b/drivers/clk/clk-qoriq.c
> > > @@ -1418,12 +1418,23 @@ static void __init clockgen_init(struct
> > > device_node *np)
> > >
> > > CLK_OF_DECLARE(qoriq_clockgen_1, "fsl,qoriq-clockgen-1.0",
> > > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_2,
> > > "fsl,qoriq-clockgen-2.0", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_b4420, "fsl,b4420-clockgen",
> > > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_b4860,
> > > +"fsl,b4860-clockgen", clockgen_init);
> > > CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen",
> > > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1021a,
> > > "fsl,ls1021a-clockgen", clockgen_init);
> > > CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen",
> > > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1046a,
> > > "fsl,ls1046a-clockgen", clockgen_init);
> > > CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen",
> > > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls2080a,
> > > "fsl,ls2080a-clockgen", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen",
> > > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p3041,
> > > +"fsl,p3041-clockgen", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen",
> > > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p5020,
> > > +"fsl,p5020-clockgen", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_p5040, "fsl,p5040-clockgen",
> > > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_t1023,
> > > +"fsl,t1023-clockgen", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_t1040, "fsl,t1040-clockgen",
> > > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_t2080,
> > > +"fsl,t2080-clockgen", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_t4240, "fsl,t4240-clockgen",
> > > +clockgen_init);
> >
> > Some of these compatibles aren't documented. What happened to the
> > binding patch to add more compatible strings?
> Nothing happened. Binding patch will be merged to PowerPC tree soon. But it will take time to
> get to mainline tree or your tree.
>

Ok. So I'll just merge this patch into clk-next then. Thanks!