2019-01-18 05:34:53

by Masahiro Yamada

Subject: [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again

Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to
nand_controller_ops") missed to invert the if-conditonal for denali.
Since then, the Denali NAND driver cannnot invoke setup_data_interface.

Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops")
Cc: linux-stable <[email protected]> # v4.20
Signed-off-by: Masahiro Yamada <[email protected]>
---

drivers/mtd/nand/raw/denali.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c
index eebac35..6e8edc9 100644
--- a/drivers/mtd/nand/raw/denali.c
+++ b/drivers/mtd/nand/raw/denali.c
@@ -1322,7 +1322,7 @@ int denali_init(struct denali_nand_info *denali)
}

/* clk rate info is needed for setup_data_interface */
- if (denali->clk_rate && denali->clk_x_rate)
+ if (!denali->clk_rate || !denali->clk_x_rate)
chip->options |= NAND_KEEP_TIMINGS;

chip->legacy.dummy_controller.ops = &denali_controller_ops;
--
2.7.4

2019-01-18 06:23:06

by Boris Brezillon

Subject: Re: [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again

On Fri, 18 Jan 2019 14:30:38 +0900
Masahiro Yamada <[email protected]> wrote:

> Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to
> nand_controller_ops") missed to invert the if-conditonal for denali.
> Since then, the Denali NAND driver cannnot invoke setup_data_interface.
>
> Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops")
> Cc: linux-stable <[email protected]> # v4.20

Commit 7a08dbaedd36 was merged in 5.0, I'll drop Cc stable when
applying.

> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> drivers/mtd/nand/raw/denali.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c
> index eebac35..6e8edc9 100644
> --- a/drivers/mtd/nand/raw/denali.c
> +++ b/drivers/mtd/nand/raw/denali.c
> @@ -1322,7 +1322,7 @@ int denali_init(struct denali_nand_info *denali)
> }
>
> /* clk rate info is needed for setup_data_interface */
> - if (denali->clk_rate && denali->clk_x_rate)
> + if (!denali->clk_rate || !denali->clk_x_rate)
> chip->options |= NAND_KEEP_TIMINGS;
>
> chip->legacy.dummy_controller.ops = &denali_controller_ops;

2019-01-18 06:30:38

by Masahiro Yamada

Subject: Re: [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again

On Fri, Jan 18, 2019 at 3:19 PM Boris Brezillon <[email protected]> wrote:
>
> On Fri, 18 Jan 2019 14:30:38 +0900
> Masahiro Yamada <[email protected]> wrote:
>
> > Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to
> > nand_controller_ops") missed to invert the if-conditonal for denali.
> > Since then, the Denali NAND driver cannnot invoke setup_data_interface.
> >
> > Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops")
> > Cc: linux-stable <[email protected]> # v4.20
>
> Commit 7a08dbaedd36 was merged in 5.0, I'll drop Cc stable when
> applying.


Ah, right. Thanks.




--
Best Regards
Masahiro Yamada

2019-01-18 08:54:26

by Miquel Raynal

Subject: Re: [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again

Hi Masahiro,

Masahiro Yamada <[email protected]> wrote on Fri, 18 Jan
2019 14:30:38 +0900:

> Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to
> nand_controller_ops") missed to invert the if-conditonal for denali.
> Since then, the Denali NAND driver cannnot invoke setup_data_interface.
>
> Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops")
> Cc: linux-stable <[email protected]> # v4.20
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>

Acked-by: Miquel Raynal <[email protected]>


Thanks,
Miquèl

2019-01-18 11:46:07

by Boris Brezillon

Subject: Re: mtd: rawnand: denali: get ->setup_data_interface() working again

On Fri, 2019-01-18 at 05:30:38 UTC, Masahiro Yamada wrote:
> Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to
> nand_controller_ops") missed to invert the if-conditonal for denali.
> Since then, the Denali NAND driver cannnot invoke setup_data_interface.
>
> Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops")
> Cc: linux-stable <[email protected]> # v4.20
> Signed-off-by: Masahiro Yamada <[email protected]>
> Acked-by: Miquel Raynal <[email protected]>

Applied to http://git.infradead.org/linux-mtd.git mtd/fixes, thanks.

Boris