2019-02-11 02:14:22

by Ryder Lee

Subject: [PATCH] mt76: change the retun type of mt76_dma_attach()

There is no need to retun 0 in mt76_dma_attach(), so switch it to void.

Signed-off-by: Ryder Lee <[email protected]>
---
drivers/net/wireless/mediatek/mt76/dma.c | 3 +--
drivers/net/wireless/mediatek/mt76/dma.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/dma.c b/drivers/net/wireless/mediatek/mt76/dma.c
index e2ba263..d934d72 100644
--- a/drivers/net/wireless/mediatek/mt76/dma.c
+++ b/drivers/net/wireless/mediatek/mt76/dma.c
@@ -522,10 +522,9 @@ int mt76_dma_tx_queue_skb(struct mt76_dev *dev, struct mt76_queue *q,
.kick = mt76_dma_kick_queue,
};

-int mt76_dma_attach(struct mt76_dev *dev)
+void mt76_dma_attach(struct mt76_dev *dev)
{
dev->queue_ops = &mt76_dma_ops;
- return 0;
}
EXPORT_SYMBOL_GPL(mt76_dma_attach);

diff --git a/drivers/net/wireless/mediatek/mt76/dma.h b/drivers/net/wireless/mediatek/mt76/dma.h
index 357cc35..e3292df 100644
--- a/drivers/net/wireless/mediatek/mt76/dma.h
+++ b/drivers/net/wireless/mediatek/mt76/dma.h
@@ -54,7 +54,7 @@ enum mt76_mcu_evt_type {
EVT_EVENT_DFS_DETECT_RSP,
};

-int mt76_dma_attach(struct mt76_dev *dev);
+void mt76_dma_attach(struct mt76_dev *dev);
void mt76_dma_cleanup(struct mt76_dev *dev);

#endif
--
1.9.1

2019-02-11 08:39:35

by Sergei Shtylyov

Subject: Re: [PATCH] mt76: change the retun type of mt76_dma_attach()

Hello!

On 11.02.2019 5:13, Ryder Lee wrote:

> There is no need to retun 0 in mt76_dma_attach(), so switch it to void.
^ r missing :-)
>
> Signed-off-by: Ryder Lee <[email protected]>
[...]

MBR, Sergei

2019-02-11 08:50:34

by Ryder Lee

Subject: Re: [PATCH] mt76: change the retun type of mt76_dma_attach()

On Mon, 2019-02-11 at 11:38 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 11.02.2019 5:13, Ryder Lee wrote:
>
> > There is no need to retun 0 in mt76_dma_attach(), so switch it to void.
> ^ r missing :-)
> >
> > Signed-off-by: Ryder Lee <[email protected]>
> [...]
>
> MBR, Sergei
>

I will resend a new one.

Thanks
Ryder

2019-02-11 09:19:59

by Kalle Valo

Subject: Re: [Resend PATCH] mt76: change the return type of mt76_dma_attach()

Ryder Lee <[email protected]> writes:

> There is no need to return 0 in mt76_dma_attach(), so switch it to void.
>
> Signed-off-by: Ryder Lee <[email protected]>

When you send a new version mark it as v2:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing

And add a changelog:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing

No need to resend because of this, but please do remember this in the
future.

--
Kalle Valo

2019-02-11 20:39:45

by Felix Fietkau

Subject: Re: [PATCH] mt76: change the retun type of mt76_dma_attach()

On 2019-02-11 03:13, Ryder Lee wrote:
> There is no need to retun 0 in mt76_dma_attach(), so switch it to void.
>
> Signed-off-by: Ryder Lee <[email protected]>
Applied, thanks.

- Felix