Removes below resources which were defined during
pre-silicon phase and the real silicons do NOT have
them, they have never been used, latest system
controller firmware also removed them:
IMX_SC_R_DC_0_CAPTURE0
IMX_SC_R_DC_0_CAPTURE1
IMX_SC_R_DC_0_INTEGRAL0
IMX_SC_R_DC_0_INTEGRAL1
IMX_SC_R_DC_0_FRAC1
IMX_SC_R_DC_1_CAPTURE0
IMX_SC_R_DC_1_CAPTURE1
IMX_SC_R_DC_1_INTEGRAL0
IMX_SC_R_DC_1_INTEGRAL1
IMX_SC_R_DC_1_FRAC1
IMX_SC_R_GPU_3_PID0
IMX_SC_R_M4_0_SIM
IMX_SC_R_M4_0_WDOG
IMX_SC_R_M4_1_SIM
IMX_SC_R_M4_1_WDOG
Signed-off-by: Anson Huang <[email protected]>
---
Changes since V3:
- just remove those unused resource and no need to define UNUSED resource.
--
include/dt-bindings/firmware/imx/rsrc.h | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/include/dt-bindings/firmware/imx/rsrc.h b/include/dt-bindings/firmware/imx/rsrc.h
index 4481f2d..d69f934 100644
--- a/include/dt-bindings/firmware/imx/rsrc.h
+++ b/include/dt-bindings/firmware/imx/rsrc.h
@@ -36,15 +36,10 @@
#define IMX_SC_R_DC_0_BLIT1 20
#define IMX_SC_R_DC_0_BLIT2 21
#define IMX_SC_R_DC_0_BLIT_OUT 22
-#define IMX_SC_R_DC_0_CAPTURE0 23
-#define IMX_SC_R_DC_0_CAPTURE1 24
#define IMX_SC_R_DC_0_WARP 25
-#define IMX_SC_R_DC_0_INTEGRAL0 26
-#define IMX_SC_R_DC_0_INTEGRAL1 27
#define IMX_SC_R_DC_0_VIDEO0 28
#define IMX_SC_R_DC_0_VIDEO1 29
#define IMX_SC_R_DC_0_FRAC0 30
-#define IMX_SC_R_DC_0_FRAC1 31
#define IMX_SC_R_DC_0 32
#define IMX_SC_R_GPU_2_PID0 33
#define IMX_SC_R_DC_0_PLL_0 34
@@ -53,17 +48,11 @@
#define IMX_SC_R_DC_1_BLIT1 37
#define IMX_SC_R_DC_1_BLIT2 38
#define IMX_SC_R_DC_1_BLIT_OUT 39
-#define IMX_SC_R_DC_1_CAPTURE0 40
-#define IMX_SC_R_DC_1_CAPTURE1 41
#define IMX_SC_R_DC_1_WARP 42
-#define IMX_SC_R_DC_1_INTEGRAL0 43
-#define IMX_SC_R_DC_1_INTEGRAL1 44
#define IMX_SC_R_DC_1_VIDEO0 45
#define IMX_SC_R_DC_1_VIDEO1 46
#define IMX_SC_R_DC_1_FRAC0 47
-#define IMX_SC_R_DC_1_FRAC1 48
#define IMX_SC_R_DC_1 49
-#define IMX_SC_R_GPU_3_PID0 50
#define IMX_SC_R_DC_1_PLL_0 51
#define IMX_SC_R_DC_1_PLL_1 52
#define IMX_SC_R_SPI_0 53
@@ -303,8 +292,6 @@
#define IMX_SC_R_M4_0_UART 287
#define IMX_SC_R_M4_0_I2C 288
#define IMX_SC_R_M4_0_INTMUX 289
-#define IMX_SC_R_M4_0_SIM 290
-#define IMX_SC_R_M4_0_WDOG 291
#define IMX_SC_R_M4_0_MU_0B 292
#define IMX_SC_R_M4_0_MU_0A0 293
#define IMX_SC_R_M4_0_MU_0A1 294
@@ -323,8 +310,6 @@
#define IMX_SC_R_M4_1_UART 307
#define IMX_SC_R_M4_1_I2C 308
#define IMX_SC_R_M4_1_INTMUX 309
-#define IMX_SC_R_M4_1_SIM 310
-#define IMX_SC_R_M4_1_WDOG 311
#define IMX_SC_R_M4_1_MU_0B 312
#define IMX_SC_R_M4_1_MU_0A0 313
#define IMX_SC_R_M4_1_MU_0A1 314
--
2.7.4
Add new resources as below according to latest system
controller firmware for new features:
IMX_SC_R_PERF
IMX_SC_R_OCRAM
IMX_SC_R_DMA_5_CH0
IMX_SC_R_DMA_5_CH1
IMX_SC_R_DMA_5_CH2
IMX_SC_R_DMA_5_CH3
IMX_SC_R_ATTESTATION
Signed-off-by: Anson Huang <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
No changes since V3.
---
include/dt-bindings/firmware/imx/rsrc.h | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/include/dt-bindings/firmware/imx/rsrc.h b/include/dt-bindings/firmware/imx/rsrc.h
index d69f934..4e61f64 100644
--- a/include/dt-bindings/firmware/imx/rsrc.h
+++ b/include/dt-bindings/firmware/imx/rsrc.h
@@ -36,6 +36,7 @@
#define IMX_SC_R_DC_0_BLIT1 20
#define IMX_SC_R_DC_0_BLIT2 21
#define IMX_SC_R_DC_0_BLIT_OUT 22
+#define IMX_SC_R_PERF 23
#define IMX_SC_R_DC_0_WARP 25
#define IMX_SC_R_DC_0_VIDEO0 28
#define IMX_SC_R_DC_0_VIDEO1 29
@@ -322,7 +323,7 @@
#define IMX_SC_R_IRQSTR_SCU2 321
#define IMX_SC_R_IRQSTR_DSP 322
#define IMX_SC_R_ELCDIF_PLL 323
-#define IMX_SC_R_UNUSED6 324
+#define IMX_SC_R_OCRAM 324
#define IMX_SC_R_AUDIO_PLL_0 325
#define IMX_SC_R_PI_0 326
#define IMX_SC_R_PI_0_PWM_0 327
@@ -539,6 +540,11 @@
#define IMX_SC_R_VPU_MU_3 538
#define IMX_SC_R_VPU_ENC_1 539
#define IMX_SC_R_VPU 540
-#define IMX_SC_R_LAST 541
+#define IMX_SC_R_DMA_5_CH0 541
+#define IMX_SC_R_DMA_5_CH1 542
+#define IMX_SC_R_DMA_5_CH2 543
+#define IMX_SC_R_DMA_5_CH3 544
+#define IMX_SC_R_ATTESTATION 545
+#define IMX_SC_R_LAST 546
#endif /* __DT_BINDINGS_RSCRC_IMX_H */
--
2.7.4
> From: Anson Huang
> Sent: Saturday, February 23, 2019 11:20 AM
> To: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; Aisheng Dong <[email protected]>;
> [email protected]; [email protected];
> [email protected]
> Cc: dl-linux-imx <[email protected]>
> Subject: [PATCH V4 1/2] dt-bindings: imx: remove unused resources from scu
> resource table
>
> Removes below resources which were defined during pre-silicon phase and the
> real silicons do NOT have them, they have never been used, latest system
> controller firmware also removed them:
>
> IMX_SC_R_DC_0_CAPTURE0
> IMX_SC_R_DC_0_CAPTURE1
> IMX_SC_R_DC_0_INTEGRAL0
> IMX_SC_R_DC_0_INTEGRAL1
> IMX_SC_R_DC_0_FRAC1
> IMX_SC_R_DC_1_CAPTURE0
> IMX_SC_R_DC_1_CAPTURE1
> IMX_SC_R_DC_1_INTEGRAL0
> IMX_SC_R_DC_1_INTEGRAL1
> IMX_SC_R_DC_1_FRAC1
> IMX_SC_R_GPU_3_PID0
> IMX_SC_R_M4_0_SIM
> IMX_SC_R_M4_0_WDOG
> IMX_SC_R_M4_1_SIM
> IMX_SC_R_M4_1_WDOG
>
> Signed-off-by: Anson Huang <[email protected]>
There're gaps left after removing, but I can't see it's actually a problem.
So:
Reviewed-by: Dong Aisheng <[email protected]>
Regards
Dong Aisheng
> ---
> Changes since V3:
> - just remove those unused resource and no need to define UNUSED
> resource.
> --
> include/dt-bindings/firmware/imx/rsrc.h | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/include/dt-bindings/firmware/imx/rsrc.h
> b/include/dt-bindings/firmware/imx/rsrc.h
> index 4481f2d..d69f934 100644
> --- a/include/dt-bindings/firmware/imx/rsrc.h
> +++ b/include/dt-bindings/firmware/imx/rsrc.h
> @@ -36,15 +36,10 @@
> #define IMX_SC_R_DC_0_BLIT1 20
> #define IMX_SC_R_DC_0_BLIT2 21
> #define IMX_SC_R_DC_0_BLIT_OUT 22
> -#define IMX_SC_R_DC_0_CAPTURE0 23
> -#define IMX_SC_R_DC_0_CAPTURE1 24
> #define IMX_SC_R_DC_0_WARP 25
> -#define IMX_SC_R_DC_0_INTEGRAL0 26
> -#define IMX_SC_R_DC_0_INTEGRAL1 27
> #define IMX_SC_R_DC_0_VIDEO0 28
> #define IMX_SC_R_DC_0_VIDEO1 29
> #define IMX_SC_R_DC_0_FRAC0 30
> -#define IMX_SC_R_DC_0_FRAC1 31
> #define IMX_SC_R_DC_0 32
> #define IMX_SC_R_GPU_2_PID0 33
> #define IMX_SC_R_DC_0_PLL_0 34
> @@ -53,17 +48,11 @@
> #define IMX_SC_R_DC_1_BLIT1 37
> #define IMX_SC_R_DC_1_BLIT2 38
> #define IMX_SC_R_DC_1_BLIT_OUT 39
> -#define IMX_SC_R_DC_1_CAPTURE0 40
> -#define IMX_SC_R_DC_1_CAPTURE1 41
> #define IMX_SC_R_DC_1_WARP 42
> -#define IMX_SC_R_DC_1_INTEGRAL0 43
> -#define IMX_SC_R_DC_1_INTEGRAL1 44
> #define IMX_SC_R_DC_1_VIDEO0 45
> #define IMX_SC_R_DC_1_VIDEO1 46
> #define IMX_SC_R_DC_1_FRAC0 47
> -#define IMX_SC_R_DC_1_FRAC1 48
> #define IMX_SC_R_DC_1 49
> -#define IMX_SC_R_GPU_3_PID0 50
> #define IMX_SC_R_DC_1_PLL_0 51
> #define IMX_SC_R_DC_1_PLL_1 52
> #define IMX_SC_R_SPI_0 53
> @@ -303,8 +292,6 @@
> #define IMX_SC_R_M4_0_UART 287
> #define IMX_SC_R_M4_0_I2C 288
> #define IMX_SC_R_M4_0_INTMUX 289
> -#define IMX_SC_R_M4_0_SIM 290
> -#define IMX_SC_R_M4_0_WDOG 291
> #define IMX_SC_R_M4_0_MU_0B 292
> #define IMX_SC_R_M4_0_MU_0A0 293
> #define IMX_SC_R_M4_0_MU_0A1 294
> @@ -323,8 +310,6 @@
> #define IMX_SC_R_M4_1_UART 307
> #define IMX_SC_R_M4_1_I2C 308
> #define IMX_SC_R_M4_1_INTMUX 309
> -#define IMX_SC_R_M4_1_SIM 310
> -#define IMX_SC_R_M4_1_WDOG 311
> #define IMX_SC_R_M4_1_MU_0B 312
> #define IMX_SC_R_M4_1_MU_0A0 313
> #define IMX_SC_R_M4_1_MU_0A1 314
> --
> 2.7.4
> From: Anson Huang
> Sent: Saturday, February 23, 2019 11:20 AM
>
> Add new resources as below according to latest system controller firmware for
> new features:
>
> IMX_SC_R_PERF
> IMX_SC_R_OCRAM
> IMX_SC_R_DMA_5_CH0
> IMX_SC_R_DMA_5_CH1
> IMX_SC_R_DMA_5_CH2
> IMX_SC_R_DMA_5_CH3
> IMX_SC_R_ATTESTATION
>
> Signed-off-by: Anson Huang <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
Please update the patch title to:
dt-bindings: firmware: imx-scu: xxxx
Otherwise:
Reviewed-by: Dong Aisheng <[email protected]>
Regards
Dong Aisheng
> ---
> No changes since V3.
> ---
> include/dt-bindings/firmware/imx/rsrc.h | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/include/dt-bindings/firmware/imx/rsrc.h
> b/include/dt-bindings/firmware/imx/rsrc.h
> index d69f934..4e61f64 100644
> --- a/include/dt-bindings/firmware/imx/rsrc.h
> +++ b/include/dt-bindings/firmware/imx/rsrc.h
> @@ -36,6 +36,7 @@
> #define IMX_SC_R_DC_0_BLIT1 20
> #define IMX_SC_R_DC_0_BLIT2 21
> #define IMX_SC_R_DC_0_BLIT_OUT 22
> +#define IMX_SC_R_PERF 23
> #define IMX_SC_R_DC_0_WARP 25
> #define IMX_SC_R_DC_0_VIDEO0 28
> #define IMX_SC_R_DC_0_VIDEO1 29
> @@ -322,7 +323,7 @@
> #define IMX_SC_R_IRQSTR_SCU2 321
> #define IMX_SC_R_IRQSTR_DSP 322
> #define IMX_SC_R_ELCDIF_PLL 323
> -#define IMX_SC_R_UNUSED6 324
> +#define IMX_SC_R_OCRAM 324
> #define IMX_SC_R_AUDIO_PLL_0 325
> #define IMX_SC_R_PI_0 326
> #define IMX_SC_R_PI_0_PWM_0 327
> @@ -539,6 +540,11 @@
> #define IMX_SC_R_VPU_MU_3 538
> #define IMX_SC_R_VPU_ENC_1 539
> #define IMX_SC_R_VPU 540
> -#define IMX_SC_R_LAST 541
> +#define IMX_SC_R_DMA_5_CH0 541
> +#define IMX_SC_R_DMA_5_CH1 542
> +#define IMX_SC_R_DMA_5_CH2 543
> +#define IMX_SC_R_DMA_5_CH3 544
> +#define IMX_SC_R_ATTESTATION 545
> +#define IMX_SC_R_LAST 546
>
> #endif /* __DT_BINDINGS_RSCRC_IMX_H */
> --
> 2.7.4
> > Subject: [PATCH V4 1/2] dt-bindings: imx: remove unused resources from
> > scu resource table
> >
> > Removes below resources which were defined during pre-silicon phase
> > and the real silicons do NOT have them, they have never been used,
> > latest system controller firmware also removed them:
> >
> > IMX_SC_R_DC_0_CAPTURE0
> > IMX_SC_R_DC_0_CAPTURE1
> > IMX_SC_R_DC_0_INTEGRAL0
> > IMX_SC_R_DC_0_INTEGRAL1
> > IMX_SC_R_DC_0_FRAC1
> > IMX_SC_R_DC_1_CAPTURE0
> > IMX_SC_R_DC_1_CAPTURE1
> > IMX_SC_R_DC_1_INTEGRAL0
> > IMX_SC_R_DC_1_INTEGRAL1
> > IMX_SC_R_DC_1_FRAC1
> > IMX_SC_R_GPU_3_PID0
> > IMX_SC_R_M4_0_SIM
> > IMX_SC_R_M4_0_WDOG
> > IMX_SC_R_M4_1_SIM
> > IMX_SC_R_M4_1_WDOG
> >
> > Signed-off-by: Anson Huang <[email protected]>
>
> There're gaps left after removing, but I can't see it's actually a problem.
> So:
> Reviewed-by: Dong Aisheng <[email protected]>
>
Sorry, missed to comment that please update the patch title:
dt-bindings: firmware: imx-scu: xxxx
Regards
Dong Aisheng
> Regards
> Dong Aisheng
>
> > ---
> > Changes since V3:
> > - just remove those unused resource and no need to define UNUSED
> > resource.
> > --
> > include/dt-bindings/firmware/imx/rsrc.h | 15 ---------------
> > 1 file changed, 15 deletions(-)
> >
> > diff --git a/include/dt-bindings/firmware/imx/rsrc.h
> > b/include/dt-bindings/firmware/imx/rsrc.h
> > index 4481f2d..d69f934 100644
> > --- a/include/dt-bindings/firmware/imx/rsrc.h
> > +++ b/include/dt-bindings/firmware/imx/rsrc.h
> > @@ -36,15 +36,10 @@
> > #define IMX_SC_R_DC_0_BLIT1 20
> > #define IMX_SC_R_DC_0_BLIT2 21
> > #define IMX_SC_R_DC_0_BLIT_OUT 22
> > -#define IMX_SC_R_DC_0_CAPTURE0 23
> > -#define IMX_SC_R_DC_0_CAPTURE1 24
> > #define IMX_SC_R_DC_0_WARP 25
> > -#define IMX_SC_R_DC_0_INTEGRAL0 26
> > -#define IMX_SC_R_DC_0_INTEGRAL1 27
> > #define IMX_SC_R_DC_0_VIDEO0 28
> > #define IMX_SC_R_DC_0_VIDEO1 29
> > #define IMX_SC_R_DC_0_FRAC0 30
> > -#define IMX_SC_R_DC_0_FRAC1 31
> > #define IMX_SC_R_DC_0 32
> > #define IMX_SC_R_GPU_2_PID0 33
> > #define IMX_SC_R_DC_0_PLL_0 34
> > @@ -53,17 +48,11 @@
> > #define IMX_SC_R_DC_1_BLIT1 37
> > #define IMX_SC_R_DC_1_BLIT2 38
> > #define IMX_SC_R_DC_1_BLIT_OUT 39
> > -#define IMX_SC_R_DC_1_CAPTURE0 40
> > -#define IMX_SC_R_DC_1_CAPTURE1 41
> > #define IMX_SC_R_DC_1_WARP 42
> > -#define IMX_SC_R_DC_1_INTEGRAL0 43
> > -#define IMX_SC_R_DC_1_INTEGRAL1 44
> > #define IMX_SC_R_DC_1_VIDEO0 45
> > #define IMX_SC_R_DC_1_VIDEO1 46
> > #define IMX_SC_R_DC_1_FRAC0 47
> > -#define IMX_SC_R_DC_1_FRAC1 48
> > #define IMX_SC_R_DC_1 49
> > -#define IMX_SC_R_GPU_3_PID0 50
> > #define IMX_SC_R_DC_1_PLL_0 51
> > #define IMX_SC_R_DC_1_PLL_1 52
> > #define IMX_SC_R_SPI_0 53
> > @@ -303,8 +292,6 @@
> > #define IMX_SC_R_M4_0_UART 287
> > #define IMX_SC_R_M4_0_I2C 288
> > #define IMX_SC_R_M4_0_INTMUX 289
> > -#define IMX_SC_R_M4_0_SIM 290
> > -#define IMX_SC_R_M4_0_WDOG 291
> > #define IMX_SC_R_M4_0_MU_0B 292
> > #define IMX_SC_R_M4_0_MU_0A0 293
> > #define IMX_SC_R_M4_0_MU_0A1 294
> > @@ -323,8 +310,6 @@
> > #define IMX_SC_R_M4_1_UART 307
> > #define IMX_SC_R_M4_1_I2C 308
> > #define IMX_SC_R_M4_1_INTMUX 309
> > -#define IMX_SC_R_M4_1_SIM 310
> > -#define IMX_SC_R_M4_1_WDOG 311
> > #define IMX_SC_R_M4_1_MU_0B 312
> > #define IMX_SC_R_M4_1_MU_0A0 313
> > #define IMX_SC_R_M4_1_MU_0A1 314
> > --
> > 2.7.4