2021-01-15 10:12:41

by Abaci Team

[permalink] [raw]
Subject: [PATCH] drivers/pinctrl/bcm: Simplify bool comparison

Fix the follow coccicheck warnings:

./drivers/pinctrl/bcm/pinctrl-ns2-mux.c:856:29-38: WARNING:
Comparison to bool.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Zhong <[email protected]>
---
drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c
index 57044ab..0fe4a1f 100644
--- a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c
+++ b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c
@@ -853,7 +853,7 @@ static int ns2_pin_config_get(struct pinctrl_dev *pctldev, unsigned int pin,
switch (param) {
case PIN_CONFIG_BIAS_DISABLE:
ns2_pin_get_pull(pctldev, pin, &pull_up, &pull_down);
- if ((pull_up == false) && (pull_down == false))
+ if (!pull_up && !pull_down)
return 0;
else
return -EINVAL;
--
1.8.3.1


2021-01-15 18:26:31

by Ray Jui

[permalink] [raw]
Subject: Re: [PATCH] drivers/pinctrl/bcm: Simplify bool comparison



On 1/15/2021 2:09 AM, Jiapeng Zhong wrote:
> Fix the follow coccicheck warnings:
>
> ./drivers/pinctrl/bcm/pinctrl-ns2-mux.c:856:29-38: WARNING:
> Comparison to bool.
>

Sorry I must be missing something here. Why is there a warning while
'pull_up' and 'pull_down' are already of type 'bool' and compared to
'false'?

> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Zhong <[email protected]>
> ---
> drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c
> index 57044ab..0fe4a1f 100644
> --- a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c
> +++ b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c
> @@ -853,7 +853,7 @@ static int ns2_pin_config_get(struct pinctrl_dev *pctldev, unsigned int pin,
> switch (param) {
> case PIN_CONFIG_BIAS_DISABLE:
> ns2_pin_get_pull(pctldev, pin, &pull_up, &pull_down);
> - if ((pull_up == false) && (pull_down == false))
> + if (!pull_up && !pull_down)


Looks fine as improvement, but I'm curious why there's a warning to
start with.

Thanks,

Ray

> return 0;
> else
> return -EINVAL;
>

Attachments:
smime.p7s (4.05 kB)
S/MIME Cryptographic Signature

2021-01-18 15:40:02

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] drivers/pinctrl/bcm: Simplify bool comparison

On Fri, Jan 15, 2021 at 7:24 PM Ray Jui <[email protected]> wrote:

> > - if ((pull_up == false) && (pull_down == false))
> > + if (!pull_up && !pull_down)
>
> Looks fine as improvement, but I'm curious why there's a warning to
> start with.

There is no semantic difference. This is a purely syntactic warning.

Yours,
Linus Walleij

2021-01-19 04:43:36

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] drivers/pinctrl/bcm: Simplify bool comparison

On Fri, Jan 15, 2021 at 11:09 AM Jiapeng Zhong
<[email protected]> wrote:

> Fix the follow coccicheck warnings:
>
> ./drivers/pinctrl/bcm/pinctrl-ns2-mux.c:856:29-38: WARNING:
> Comparison to bool.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Zhong <[email protected]>

Patch applied.

Yours,
Linus Walleij