2021-06-09 15:01:05

by Colin King

Subject: [PATCH] rtc: v3020: remove redundant initialization of variable retval

From: Colin Ian King <[email protected]>

The variable retval is being initialized with a value that is never read,
it is being updated later on. The assignment is redundant and can be
removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/rtc/rtc-v3020.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-v3020.c b/drivers/rtc/rtc-v3020.c
index d2da92187d56..4e8341c49f51 100644
--- a/drivers/rtc/rtc-v3020.c
+++ b/drivers/rtc/rtc-v3020.c
@@ -282,7 +282,7 @@ static int rtc_probe(struct platform_device *pdev)
{
struct v3020_platform_data *pdata = dev_get_platdata(&pdev->dev);
struct v3020 *chip;
- int retval = -EBUSY;
+ int retval;
int i;

chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);
--
2.31.1

2021-06-20 20:35:45

by Alexandre Belloni

Subject: Re: [PATCH] rtc: v3020: remove redundant initialization of variable retval

On Wed, 9 Jun 2021 13:00:50 +0100, Colin King wrote:
> The variable retval is being initialized with a value that is never read,
> it is being updated later on. The assignment is redundant and can be
> removed.

Applied, thanks!

[1/1] rtc: v3020: remove redundant initialization of variable retval
commit: fc3c335226a92f69aa01061e66b60ace88475dd3

Best regards,
--
Alexandre Belloni <[email protected]>