Smatch Warns:
drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe()
warn: missing unwind goto?
Store the error value in ret and use correct label with a goto.
Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Reported-by: Dan Carpenter <[email protected]>
Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/
Suggested-by: Dan Carpenter <[email protected]>
Signed-off-by: Harshit Mogalapalli <[email protected]>
---
Only Compile tested, found with Smatch.
---
drivers/net/wireless/ath/ath12k/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c
index ae7f6083c9fc..f523aa15885f 100644
--- a/drivers/net/wireless/ath/ath12k/pci.c
+++ b/drivers/net/wireless/ath/ath12k/pci.c
@@ -1195,7 +1195,8 @@ static int ath12k_pci_probe(struct pci_dev *pdev,
dev_err(&pdev->dev,
"Unknown hardware version found for QCN9274: 0x%x\n",
soc_hw_version_major);
- return -EOPNOTSUPP;
+ ret = -EOPNOTSUPP;
+ goto err_pci_free_region;
}
break;
case WCN7850_DEVICE_ID:
--
2.38.1
On Tue, Mar 07, 2023 at 02:47:06AM -0800, Harshit Mogalapalli wrote:
> Smatch Warns:
> drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe()
> warn: missing unwind goto?
>
> Store the error value in ret and use correct label with a goto.
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Reported-by: Dan Carpenter <[email protected]>
> Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/
> Suggested-by: Dan Carpenter <[email protected]>
> Signed-off-by: Harshit Mogalapalli <[email protected]>
> ---
> Only Compile tested, found with Smatch.
Reviewed-by: Simon Horman <[email protected]>
Harshit Mogalapalli <[email protected]> wrote:
> Smatch Warns:
> drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe()
> warn: missing unwind goto?
>
> Store the error value in ret and use correct label with a goto.
>
> Only Compile tested, found with Smatch.
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Reported-by: Dan Carpenter <[email protected]>
> Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/
> Suggested-by: Dan Carpenter <[email protected]>
> Signed-off-by: Harshit Mogalapalli <[email protected]>
> Reviewed-by: Simon Horman <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
488d9a484f96 wifi: ath12k: Add missing unwind goto in ath12k_pci_probe()
--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches