2024-03-19 01:42:48

by Yufeng Wang

Subject: [PATCH v2] floppy: remove duplicated code in redo_fd_request()

duplicated code in redo_fd_request(),
unlock_fdc() function has the same code "do_floppy = NULL" inside.

Signed-off-by: Yufeng Wang <[email protected]>
Suggested-by: Denis Efremov <[email protected]>
---
v2: The commit title is too long, update a new short commit title.
---
drivers/block/floppy.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 1b399ec8c07d..25c9d85667f1 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -2787,7 +2787,6 @@ static void redo_fd_request(void)
pending = set_next_request();
spin_unlock_irq(&floppy_lock);
if (!pending) {
- do_floppy = NULL;
unlock_fdc();
return;
}
--
2.34.1

2024-03-19 02:20:24

by Jens Axboe

Subject: Re: [PATCH v2] floppy: remove duplicated code in redo_fd_request()

On Tue, 19 Mar 2024 09:42:19 +0800, Yufeng Wang wrote:
> duplicated code in redo_fd_request(),
> unlock_fdc() function has the same code "do_floppy = NULL" inside.
>
>

Applied, thanks!

[1/1] floppy: remove duplicated code in redo_fd_request()
commit: 50171b8667733146f139c773d8f00866ceb4cee4

Best regards,
--
Jens Axboe