2022-06-10 03:35:49

by Xing Zhengjun

Subject: [PATCH v3 0/5] Add perf stat default events for hybrid machines

From: Zhengjun Xing <[email protected]>

The patch series is to clean up the existing perf stat default and support
the perf metrics Topdown for the p-core PMU in the perf stat default. The
first 4 patches are the clean-up patch and fixing the "--detailed" issue.
The last patch adds support for the perf metrics Topdown, the perf metrics
Topdown support for e-core PMU will be implemented later separately.

Kan Liang (4):
perf stat: Revert "perf stat: Add default hybrid events"
perf evsel: Add arch_evsel__hw_name()
perf evlist: Always use arch_evlist__add_default_attrs()
perf x86 evlist: Add default hybrid events for perf stat

Zhengjun Xing (1):
perf stat: Add topdown metrics in the default perf stat on the hybrid
machine

tools/perf/arch/x86/util/evlist.c | 64 +++++++++++++++++++++++++-----
tools/perf/arch/x86/util/evsel.c | 20 ++++++++++
tools/perf/arch/x86/util/topdown.c | 51 ++++++++++++++++++++++++
tools/perf/arch/x86/util/topdown.h | 1 +
tools/perf/builtin-stat.c | 50 ++++-------------------
tools/perf/util/evlist.c | 11 +++--
tools/perf/util/evlist.h | 9 ++++-
tools/perf/util/evsel.c | 7 +++-
tools/perf/util/evsel.h | 1 +
tools/perf/util/stat-display.c | 2 +-
tools/perf/util/topdown.c | 7 ++++
tools/perf/util/topdown.h | 3 +-
12 files changed, 166 insertions(+), 60 deletions(-)

--
2.25.1

2022-06-14 18:11:24

by Namhyung Kim

Subject: Re: [PATCH v3 0/5] Add perf stat default events for hybrid machines

Hello,

On Thu, Jun 9, 2022 at 7:55 PM <[email protected]> wrote:
>
> From: Zhengjun Xing <[email protected]>
>
> The patch series is to clean up the existing perf stat default and support
> the perf metrics Topdown for the p-core PMU in the perf stat default. The
> first 4 patches are the clean-up patch and fixing the "--detailed" issue.
> The last patch adds support for the perf metrics Topdown, the perf metrics
> Topdown support for e-core PMU will be implemented later separately.
>
> Kan Liang (4):
> perf stat: Revert "perf stat: Add default hybrid events"
> perf evsel: Add arch_evsel__hw_name()
> perf evlist: Always use arch_evlist__add_default_attrs()
> perf x86 evlist: Add default hybrid events for perf stat
>
> Zhengjun Xing (1):
> perf stat: Add topdown metrics in the default perf stat on the hybrid
> machine

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung


>
> tools/perf/arch/x86/util/evlist.c | 64 +++++++++++++++++++++++++-----
> tools/perf/arch/x86/util/evsel.c | 20 ++++++++++
> tools/perf/arch/x86/util/topdown.c | 51 ++++++++++++++++++++++++
> tools/perf/arch/x86/util/topdown.h | 1 +
> tools/perf/builtin-stat.c | 50 ++++-------------------
> tools/perf/util/evlist.c | 11 +++--
> tools/perf/util/evlist.h | 9 ++++-
> tools/perf/util/evsel.c | 7 +++-
> tools/perf/util/evsel.h | 1 +
> tools/perf/util/stat-display.c | 2 +-
> tools/perf/util/topdown.c | 7 ++++
> tools/perf/util/topdown.h | 3 +-
> 12 files changed, 166 insertions(+), 60 deletions(-)
>
> --
> 2.25.1
>

2022-07-04 09:50:47

by Xing Zhengjun

Subject: Re: [PATCH v3 0/5] Add perf stat default events for hybrid machines

Hi,

On 6/15/2022 1:59 AM, Namhyung Kim wrote:
> Hello,
>
> On Thu, Jun 9, 2022 at 7:55 PM <[email protected]> wrote:
>>
>> From: Zhengjun Xing <[email protected]>
>>
>> The patch series is to clean up the existing perf stat default and support
>> the perf metrics Topdown for the p-core PMU in the perf stat default. The
>> first 4 patches are the clean-up patch and fixing the "--detailed" issue.
>> The last patch adds support for the perf metrics Topdown, the perf metrics
>> Topdown support for e-core PMU will be implemented later separately.
>>
>> Kan Liang (4):
>> perf stat: Revert "perf stat: Add default hybrid events"
>> perf evsel: Add arch_evsel__hw_name()
>> perf evlist: Always use arch_evlist__add_default_attrs()
>> perf x86 evlist: Add default hybrid events for perf stat
>>
>> Zhengjun Xing (1):
>> perf stat: Add topdown metrics in the default perf stat on the hybrid
>> machine
>
> Acked-by: Namhyung Kim <[email protected]>
>

Thanks Namhyung.

Hi Arnaldo,

Can this patch series go in?
Thanks.

> Thanks,
> Namhyung
>
>
>>
>> tools/perf/arch/x86/util/evlist.c | 64 +++++++++++++++++++++++++-----
>> tools/perf/arch/x86/util/evsel.c | 20 ++++++++++
>> tools/perf/arch/x86/util/topdown.c | 51 ++++++++++++++++++++++++
>> tools/perf/arch/x86/util/topdown.h | 1 +
>> tools/perf/builtin-stat.c | 50 ++++-------------------
>> tools/perf/util/evlist.c | 11 +++--
>> tools/perf/util/evlist.h | 9 ++++-
>> tools/perf/util/evsel.c | 7 +++-
>> tools/perf/util/evsel.h | 1 +
>> tools/perf/util/stat-display.c | 2 +-
>> tools/perf/util/topdown.c | 7 ++++
>> tools/perf/util/topdown.h | 3 +-
>> 12 files changed, 166 insertions(+), 60 deletions(-)
>>
>> --
>> 2.25.1
>>

--
Zhengjun Xing

2022-07-21 06:57:11

by Xing Zhengjun

Subject: Re: [PATCH v3 0/5] Add perf stat default events for hybrid machines

Hi Arnaldo,

On 7/4/2022 5:05 PM, Xing Zhengjun wrote:
> Hi,
>
> On 6/15/2022 1:59 AM, Namhyung Kim wrote:
>> Hello,
>>
>> On Thu, Jun 9, 2022 at 7:55 PM <[email protected]> wrote:
>>>
>>> From: Zhengjun Xing <[email protected]>
>>>
>>> The patch series is to clean up the existing perf stat default and
>>> support
>>> the perf metrics Topdown for the p-core PMU in the perf stat default.
>>> The
>>> first 4 patches are the clean-up patch and fixing the "--detailed"
>>> issue.
>>> The last patch adds support for the perf metrics Topdown, the perf
>>> metrics
>>> Topdown support for e-core PMU will be implemented later separately.
>>>
>>> Kan Liang (4):
>>>    perf stat: Revert "perf stat: Add default hybrid events"
>>>    perf evsel: Add arch_evsel__hw_name()
>>>    perf evlist: Always use arch_evlist__add_default_attrs()
>>>    perf x86 evlist: Add default hybrid events for perf stat
>>>
>>> Zhengjun Xing (1):
>>>    perf stat: Add topdown metrics in the default perf stat on the hybrid
>>>      machine
>>
>> Acked-by: Namhyung Kim <[email protected]>
>>
>
> Thanks Namhyung.
>
> Hi Arnaldo,
>
> Can this patch series go in?
> Thanks.

This patch series has been a long time, patch2(perf evsel: Add
arch_evsel__hw_name() ) need rebase to the latest perf/core branch,
I will send a v4 version for it.
>
>> Thanks,
>> Namhyung
>>
>>
>>>
>>>   tools/perf/arch/x86/util/evlist.c  | 64 +++++++++++++++++++++++++-----
>>>   tools/perf/arch/x86/util/evsel.c   | 20 ++++++++++
>>>   tools/perf/arch/x86/util/topdown.c | 51 ++++++++++++++++++++++++
>>>   tools/perf/arch/x86/util/topdown.h |  1 +
>>>   tools/perf/builtin-stat.c          | 50 ++++-------------------
>>>   tools/perf/util/evlist.c           | 11 +++--
>>>   tools/perf/util/evlist.h           |  9 ++++-
>>>   tools/perf/util/evsel.c            |  7 +++-
>>>   tools/perf/util/evsel.h            |  1 +
>>>   tools/perf/util/stat-display.c     |  2 +-
>>>   tools/perf/util/topdown.c          |  7 ++++
>>>   tools/perf/util/topdown.h          |  3 +-
>>>   12 files changed, 166 insertions(+), 60 deletions(-)
>>>
>>> --
>>> 2.25.1
>>>
>

--
Zhengjun Xing