2003-09-22 08:34:32

by Andrew Morton

[permalink] [raw]
Subject: 2.6.0-test5-mm4


ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test5/2.6.0-test5-mm4/


. A series of patches from Al Viro which introduce 32-bit dev_t support

. Various new fixes




Changes since 2.6.0-test5-mm3:


linus.patch

Latest Linus tree

-ecc-support.patch
-rt-tasks-special-vm-treatment.patch
-rt-tasks-special-vm-treatment-2.patch
-group_leader-rework.patch
-group_leader-rework-fix.patch
-claim-serio-early.patch
-reiserfs-large-file-fix.patch
-irq-vector-overflow-check.patch
-mtrr-warning-fix.patch
-nls-alias-fixes.patch
-nls-elisp-removal.patch
-sched-2.6.0-test2-mm2-A3.patch
-ppc-sched_clock.patch
-sched-balance-tuning.patch
-sched-interactivity.patch
-might_sleep-diags.patch
-agp-build-fix.patch
-slab-debug-additions.patch
-slab-debug-additions-fix.patch
-remove-smp-txt.patch
-agp-warning-fix.patch
-mwave-needs-8250.patch
-any_online_cpu-fix.patch
-numa-detection-fail-fix.patch
-misc35.patch
-reiserfs-consistency-checks.patch
-remove-dupe-SOUND_RME96XX.patch
-istallion-build-fix.patch
-flock-memleak2.patch
-init-argv-fix.patch
-ens1370-name-fix.patch
-summit-apic-numbering-rework.patch
-wanXL-driver.patch
-floppy-pending-timer-fix.patch
-remove-config_build_info.patch
-access_ok-is-likely.patch
-elv-doc.patch
-sysfs_remove_dir-leak-fix.patch
-modpost-typo-fix.patch
-sbni-compile-fix.patch
-export-new-cdev-functions.patch
-INPUT_KEYCODE-fix.patch
-hangcheck-compile-fix.patch
-fix-make-rpm.patch
-NCR5380-timeout-fix.patch
-SIGRTMAX-fix.patch
-x445-no-ioapic-check.patch
-deadline-insert_here-fix.patch
-bio_dirty_fn-release-fix.patch
-direct-io-skip-compound-pages.patch
-e1000-build-fix.patch
-right-ctrl-scancode-fix.patch
-p00001_synaptics-restore-on-close.patch
-p00002_psmouse-reset-timeout.patch
-p00003_synaptics-multi-button.patch
-p00004_synaptics-optional.patch
-p00005_synaptics-pass-through.patch
-p00006_psmouse-suspend-resume.patch
-p00007_synaptics-old-proto.patch
-synaptics-mode-set.patch
-syn-multi-btn-fix.patch

Merged

+really-fix-make-rpm.patch

Fix `make rpm'

+sysrq-cleanups.patch

cleanup some peftovers

+misc36.patch

Misc fixes

+declaration-after-statement-check.patch

Use -Wdeclaration-after-statement i the compiler supports it

-flush-invalidate-fixes-warning-fix.patch

Folded into flush-invalidate-fixes.patch

+sysfs-dentry-leak-fix.patch

Fix possible sysfs dentry leak

+filesystem-option-parsing-tweaks.patch
+filesystem-option-parsing-fixes.patch
+filesystem-option-parsing-no-alloca.patch

Fixes and cleanups for filesystem-option-parsing.patch

+node-enumeration-cleanup-fix-01.patch

Update to the NUMA node enumeration patches

+CONFIG_HUGETLBFS-sets-CONFIG_HUGETLB_PAGE.patch

Compile the arch hugetlb support if hugetlbfs is selected

+acpi-thinkpad-fix.patch

input fix

+readonly-bind-mounts.patch

Support readonly mount --bind (preliminary - Al needs a go at this)

+setuid-removal-fix.patch

Correctly clear setuid bits

+synaptics-fix.patch
+synaptics-multibutton-fix.patch
+synaptics-code-cleanup.patch

Synaptics work

+smbfs-nls-fix.patch

SMBFS fix

+KD28-reiserfs-B5.patch
+KD29-drm-B5.patch
+KD30-xfs-B5.patch
+KD31-tty_devnum-B5.patch
+KD32-nfs-B5.patch
+KD33-jfs-B5.patch
+KD34-jffs2-B5.patch
+KD35-md-B5.patch
+KD36-dm-B5.patch
+KD37-misc3-B5.patch
+KD38-syscalls-B5.patch
+KD39-loop-B5.patch
+KD40-coda-B5.patch
+KD41-stat-B5.patch
+KD42-32bit-B5.patch
+KD43-real32-B5.patch

32-bit dev_t

+keyboard-resend-fix-fix.patch

Fix keyboard-resend-fix.patch for ppc64 and others.






All 158 patches:


linus.patch
cset-20030917_2214.txt.gz

mm.patch
add -mmN to EXTRAVERSION

kgdb-ga.patch
kgdb stub for ia32 (George Anzinger's one)
kgdbL warning fix

kgdb-buff-too-big.patch
kgdb buffer overflow fix

kgdb-warning-fix.patch
kgdbL warning fix

kgdb-build-fix.patch

kgdb-spinlock-fix.patch

kgdb-fix-debug-info.patch
kgdb: CONFIG_DEBUG_INFO fix

kgdb-cpumask_t.patch

kgdb-x86_64-fixes.patch
x86_64 fixes

kgdb-over-ethernet.patch
kgdb-over-ethernet patch

kgdb-over-ethernet-fixes.patch
kgdb-over-ethernet fixlets

kgdb-CONFIG_NET_POLL_CONTROLLER.patch
kgdb: replace CONFIG_KGDB with CONFIG_NET_RX_POLL in net drivers

kgdb-handle-stopped-NICs.patch
kgdb: handle netif_stopped NICs

eepro100-poll-controller.patch

tlan-poll_controller.patch

tulip-poll_controller.patch

tg3-poll_controller.patch
kgdb: tg3 poll_controller

kgdb-eth-smp-fix.patch
kgdb-over-ethernet: fix SMP

kgdb-eth-reattach.patch

kgdb-skb_reserve-fix.patch
kgdb-over-ethernet: skb_reserve() fix

acpi-20030916.patch
acpi-20030916

separate-output-dir.patch
kbuild: Separate output directory support

really-fix-make-rpm.patch
Really fix `make rpm'

acpi_disabled-fix.patch
acpi_disabled fix

acpi_off-fix.patch
fix acpi=off

cfq-4.patch
CFQ io scheduler
CFQ fixes

no-unit-at-a-time.patch
Use -fno-unit-at-a-time if gcc supports it

config_spinline.patch
uninline spinlocks for profiling accuracy.

ppc64-bar-0-fix.patch
Allow PCI BARs that start at 0

ppc64-reloc_hide.patch

ppc64-semaphore-reimplementation.patch
ppc64: use the ia32 semaphore implementation

ppc64-sym2-fix.patch
ppc64 sym2 fix

sym-do-160.patch
make the SYM driver do 160 MB/sec

input-use-after-free-checks.patch
input layer debug checks

fbdev.patch
framebbuffer driver update

cursor-flashing-fix.patch
fbdev: fix cursor letovers

slab-hexdump.patch
slab: hexdump structures when things go wrong

aic7xxx-parallel-build-fix.patch
fix parallel builds for aic7xxx

ramdisk-cleanup.patch

delay-ksoftirqd-fallback.patch
Try harded in IRQ context before falling back to ksoftirqd

intel8x0-cleanup.patch
intel8x0 cleanups

mark-devfs-obsolete.patch
mark devfs obsolete

uml-update.patch
Update UML to 2.6.0-test5

md-make_request-crash-fix.patch
md: crash fix

sysfs-dput-fix.patch
sysfs dput fix

sysrq-cleanups.patch
kill some leftovers from the big sysrq syncing rewrite

misc36.patch
misc fixes

declaration-after-statement-check.patch
add -Wdeclaration-after-statement

test5-pm2.patch

test5-pm2-fix.patch

flush-invalidate-fixes.patch
memory writeback/invalidation fixes

ide_floppy-maybe-fix.patch
might fix ide_floppy

pdflush-diag.patch

joydev-exclusions.patch
joydev is too eager claiming input devices

utime-on-immutable-file-fix.patch
disallow utime{s}() on immutable or append-only files

dgap.patch
New DGAP driver

dgap-cleanups.patch
dgap driver cleanups

pdc4030-update.patch
update pdc4030 driver

ali14xx-update.patch
update ali14xx driver

dtc2278-update.patch
update dtc2278 driver

ht6560b-update.patch
update ht6560b driver

qd65xx-update.patch
update qd65xx driver

umc8672-update.patch
update umc8672 driver

kobject-oops-fixes.patch
fix oopses is kobject parent is removed before child

futex_lock-splitup.patch
Split futex global spinlock futex_lock

futex-uninlinings.patch
futex uninlining

sysfs-dentry-leak-fix.patch
sysfs dentry leak fix

filesystem-option-parsing.patch
table-driven filesystems option parsing

filesystem-option-parsing-tweaks.patch
whitespace tweaks

filesystem-option-parsing-fixes.patch
filesystem option parser: fix handling of integers

filesystem-option-parsing-no-alloca.patch
filesystem option parser: don't use alloca()

befs-use-parser.patch
BEFS: Use table-driven option parsing

do_no_page-debug.patch

node-enumeration-cleanup-01.patch
Clean up MAX_NR_NODES/NUMNODES/etc. [1/5]

node-enumeration-cleanup-02.patch
Clean up MAX_NR_NODES/NUMNODES/etc. [2/5]

node-enumeration-cleanup-03.patch
Clean up MAX_NR_NODES/NUMNODES/etc. [3/5]

node-enumeration-cleanup-04.patch
Clean up MAX_NR_NODES/NUMNODES/etc. [4/5]

node-enumeration-cleanup-05.patch
Clean up MAX_NR_NODES/NUMNODES/etc. [5/5]

node-enumeration-cleanup-fix-01.patch
node enumeration fixes

reenable-athlon-prefetch.patch
Athlon/Opteron Prefetch Fix

hugetlbfs-accounting-fix.patch
Hugetlb FS quota accounting problem
hugetlbfs-accounting-fix tweaks

CONFIG_HUGETLBFS-sets-CONFIG_HUGETLB_PAGE.patch
make CONFIG_HUGETLB_PAGE mirror CONFIG_HUGETLBFS

zap_page_range-debug.patch
zap_page_range() debug

acpi-thinkpad-fix.patch
APCI fix for thinkpads

readonly-bind-mounts.patch
readonly mount --bind support

setuid-removal-fix.patch
setuid clearing fix

synaptics-fix.patch
Fix psmouse->pktcnt in Synaptics mode

synaptics-multibutton-fix.patch
synaptics: Don't try to handle more than eight multi buttons

synaptics-code-cleanup.patch
synaptics: Code cleanup

smbfs-nls-fix.patch

KD28-reiserfs-B5.patch

KD29-drm-B5.patch

KD30-xfs-B5.patch

KD31-tty_devnum-B5.patch

KD32-nfs-B5.patch

KD33-jfs-B5.patch

KD34-jffs2-B5.patch

KD35-md-B5.patch

KD36-dm-B5.patch

KD37-misc3-B5.patch

KD38-syscalls-B5.patch

KD39-loop-B5.patch

KD40-coda-B5.patch

KD41-stat-B5.patch

KD42-32bit-B5.patch

KD43-real32-B5.patch

psmouse_ipms2-option.patch
Force mouse detection as imps/2 (and fix my KVM switch)

i8042-history.patch
debug: i8042 history dumping

keyboard-resend-fix.patch
keyboard resend fix

keyboard-resend-fix-fix.patch

list_del-debug.patch
list_del debug check

print-build-options-on-oops.patch
print a few config options on oops

show_task-free-stack-fix.patch
show_task() fix and cleanup

oops-dump-preceding-code.patch
i386 oops output: dump preceding code

lockmeter.patch

printk-oops-mangle-fix.patch
disentangle printk's whilst oopsing on SMP

20-odirect_enable.patch

21-odirect_cruft.patch

22-read_proc.patch

23-write_proc.patch

24-commit_proc.patch

25-odirect.patch

nfs-O_DIRECT-always-enabled.patch
Force CONFIG_NFS_DIRECTIO

4g-2.6.0-test2-mm2-A5.patch
4G/4G split patch
4G/4G: remove debug code
4g4g: pmd fix
4g/4g: fixes from Bill
4g4g: fpu emulation fix
4g/4g usercopy atomicity fix
4G/4G: remove debug code
4g4g: pmd fix
4g/4g: fixes from Bill
4g4g: fpu emulation fix
4g/4g usercopy atomicity fix
4G/4G preempt on vstack
4G/4G: even number of kmap types
4g4g: fix __get_user in slab
4g4g: Remove extra .data.idt section definition
4g/4g linker error (overlapping sections)
4G/4G: remove debug code
4g4g: pmd fix
4g/4g: fixes from Bill
4g4g: fpu emulation fix
4g4g: show_registers() fix
4g/4g usercopy atomicity fix
4g4g: debug flags fix
4g4g: Fix wrong asm-offsets entry
cyclone time fixmap fix
4G/4G preempt on vstack
4G/4G: even number of kmap types
4g4g: fix __get_user in slab
4g4g: Remove extra .data.idt section definition
4g/4g linker error (overlapping sections)
4G/4G: remove debug code
4g4g: pmd fix
4g/4g: fixes from Bill
4g4g: fpu emulation fix
4g4g: show_registers() fix
4g/4g usercopy atomicity fix
4g4g: debug flags fix
4g4g: Fix wrong asm-offsets entry
cyclone time fixmap fix

4g4g-cyclone-timer-fix.patch

4g4g-copy_mount_options-fix.patch
use direct_copy_{to,from}_user for kernel access in mm/usercopy.c

4g4g-might_sleep-warning-fix.patch
4G/4G might_sleep warning fix

4g4g-pagetable-accounting-fix.patch
4g/4g pagetable accounting fix

ppc-fixes.patch
make mm4 compile on ppc

aic7xxx_old-oops-fix.patch

aio-01-retry.patch
AIO: Core retry infrastructure
Fix aio process hang on EINVAL

aio-02-lockpage_wq.patch
AIO: Async page wait

aio-03-fs_read.patch
AIO: Filesystem aio read

aio-04-buffer_wq.patch
AIO: Async buffer wait

aio-05-fs_write.patch
AIO: Filesystem aio write

aio-06-bread_wq.patch
AIO: Async block read

aio-07-ext2getblk_wq.patch
AIO: Async get block for ext2

O_SYNC-speedup-2.patch
speed up O_SYNC writes

aio-09-o_sync.patch
aio O_SYNC

aio-10-BUG-fix.patch
AIO: fix a BUG

aio-11-workqueue-flush.patch
AIO: flush workqueues before destroying ioctx'es

aio-12-readahead.patch
AIO: readahead fixes

aio-dio-no-readahead.patch
aio O_DIRECT no readahead

lock_buffer_wq-fix.patch
lock_buffer_wq fix

unuse_mm-locked.patch
AIO: hold the context lock across unuse_mm

aio-take-task_lock.patch
task task_lock in use_mm()

aio-O_SYNC-fix.patch
Unify o_sync changes for aio and regular writes
aio-O_SYNC-fix bits got lost
aio: writev nr_segs fix

aio-readahead-rework.patch
Unified page range readahead for aio and regular reads

aio-readahead-speedup.patch
Readahead issues and AIO read speedup

aio-osync-fix-2.patch
More AIO O_SYNC related fixes

gang_lookup_next.patch
Change the page gang lookup API

aio-gang_lookup-fix.patch
AIO gang lookup fixes

aio-O_SYNC-short-write-fix.patch
Fix for O_SYNC short writes

O_DIRECT-race-fixes.patch
DIO fixes forward port and AIO-DIO fix

O_DIRECT-race-fixes-fixes.patch

O_DIRECT-race-fixes-commentary.patch
O_DIRECT race fixes comments

O_DIRECT-race-fixes-fixes-2.patch
O_DRIECT race fixes fix fix fix




2003-09-22 10:08:49

by Florian Schanda

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

On Monday 22 September 2003 09:35, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test5/2

Hi,

I need this patch to compile ide modules properly.

Florian

--- old/drivers/block/ll_rw_blk.c 2003-09-22 12:59:39.000000000 +0100
+++ linux-2.6.0-test5/drivers/block/ll_rw_blk.c 2003-09-22 13:01:46.000000000
+0100
@@ -2903,3 +2903,4 @@
EXPORT_SYMBOL(blk_run_queues);

EXPORT_SYMBOL(blk_rq_bio_prep);
+EXPORT_SYMBOL(blk_rq_prep_restart);

2003-09-22 11:50:10

by Adrian Bunk

[permalink] [raw]
Subject: 2.6.0-test5-mm4: BeFS compile error

On Mon, Sep 22, 2003 at 01:35:48AM -0700, Andrew Morton wrote:
>...
> befs-use-parser.patch
> BEFS: Use table-driven option parsing
>...

It seems this patch broke the compilation of BeFS:

<-- snip -->

...
CC fs/befs/linuxvfs.o
fs/befs/linuxvfs.c: In function `parse_options':
fs/befs/linuxvfs.c:712: too few arguments to function `match_int'
fs/befs/linuxvfs.c:724: too few arguments to function `match_int'
make[2]: *** [fs/befs/linuxvfs.o] Error 1

<-- snip -->

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2003-09-22 12:18:00

by Alistair John Strachan

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

On Monday 22 September 2003 09:35, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test5/2
>.6.0-test5-mm4/
>
>
> . A series of patches from Al Viro which introduce 32-bit dev_t support
>
> . Various new fixes
>
>

Hi Andrew,

-mm4 won't mount my ext3 root device whereas -mm3 will. Presumably this is
some byproduct of the dev_t patches.

VFS: Cannot open root device "302" or hda2.
Please append correct "root=" boot option.
Kernel Panic: VFS: Unable to mount root fs on hda2.

One possible explanation is that I have devfs compiled into my kernel. I do
not, however, have it automatically mounting on boot. It overlays /dev (which
is populated with original style device nodes) after INIT has loaded.

Perhaps there is some other procedure I must complete before I can use 32bit
dev_t?

[alistair] 01:15 PM [/usr/src/linux-2.6] egrep -e "DEVFS" -e "EXT3_FS" .config
CONFIG_EXT3_FS=y
CONFIG_EXT3_FS_XATTR=y
CONFIG_EXT3_FS_POSIX_ACL=y
CONFIG_EXT3_FS_SECURITY=y
CONFIG_DEVFS_FS=y
# CONFIG_DEVFS_MOUNT is not set
# CONFIG_DEVFS_DEBUG is not set

[alistair] 01:16 PM [/usr/src/linux-2.6] dmesg | grep p2
/dev/ide/host0/bus0/target0/lun0: p1 p2 p4

Cheers,
Alistair.

2003-09-22 12:29:19

by Florian Schanda

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 22 September 2003 13:17, Alistair J Strachan wrote:
> -mm4 won't mount my ext3 root device whereas -mm3 will. Presumably this is
> some byproduct of the dev_t patches.

I don't think this has to do with ext3, since my root xfs partition can't be
mounted either.

> VFS: Cannot open root device "302" or hda2.
> Please append correct "root=" boot option.
> Kernel Panic: VFS: Unable to mount root fs on hda2.

same over here, except replace hda2 with sda3 and (302 with 803 of couse).

> One possible explanation is that I have devfs compiled into my kernel. I do
> not, however, have it automatically mounting on boot. It overlays /dev
> (which is populated with original style device nodes) after INIT has
> loaded.

I disabled mount at root and created some device nodes, but it still doesn't
work, befor that I had pure devfs. Reading the config help for devfs says
it's obsoleted, and stripped down to a "bare minimum to not break anyting".
Does that "bare minimum" include hard disks?

Florian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/bwdvfCf8muQVS4cRAmQ0AJ9N6WBJIOKholW9Rf2QV6wdxlWyHACeNsoP
niBAErfeLd0NR0WR6ElKOhU=
=Iysp
-----END PGP SIGNATURE-----

2003-09-22 13:40:24

by Zilvinas Valinskas

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

On Mon, Sep 22, 2003 at 01:17:42PM +0100, Alistair J Strachan wrote:
> On Monday 22 September 2003 09:35, Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test5/2
> >.6.0-test5-mm4/
> >
> >
> > . A series of patches from Al Viro which introduce 32-bit dev_t support
> >
> > . Various new fixes
> >
> >
>
> Hi Andrew,
>
> -mm4 won't mount my ext3 root device whereas -mm3 will. Presumably this is
> some byproduct of the dev_t patches.
>
> VFS: Cannot open root device "302" or hda2.
> Please append correct "root=" boot option.
> Kernel Panic: VFS: Unable to mount root fs on hda2.

Do you use devfsd ?

I had to specify root like this :
root=/dev/ide/host0/bus0/target0/lun0/part5 then it worked just fine.

Btw Andrew ,

this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver
from http://w1.894.telia.com/~u89404340/touchpad/index.html.


-static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/
2", "ImPS/2", "ImExPS/2", "Synaptics"};
+static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"};


>
> One possible explanation is that I have devfs compiled into my kernel. I do
> not, however, have it automatically mounting on boot. It overlays /dev (which
> is populated with original style device nodes) after INIT has loaded.
>
> Perhaps there is some other procedure I must complete before I can use 32bit
> dev_t?
>
> [alistair] 01:15 PM [/usr/src/linux-2.6] egrep -e "DEVFS" -e "EXT3_FS" .config
> CONFIG_EXT3_FS=y
> CONFIG_EXT3_FS_XATTR=y
> CONFIG_EXT3_FS_POSIX_ACL=y
> CONFIG_EXT3_FS_SECURITY=y
> CONFIG_DEVFS_FS=y
> # CONFIG_DEVFS_MOUNT is not set
> # CONFIG_DEVFS_DEBUG is not set
>
> [alistair] 01:16 PM [/usr/src/linux-2.6] dmesg | grep p2
> /dev/ide/host0/bus0/target0/lun0: p1 p2 p4
>
> Cheers,
> Alistair.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2003-09-22 13:54:21

by Alistair John Strachan

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

On Monday 22 September 2003 14:49, Alistair J Strachan wrote:
[snip]
>
> I'll try that, thanks. But I have this in lilo.conf:
>
> boot=/dev/discs/disc0/disc
> root=/dev/discs/disc0/part2
>
> /dev/discs is indeed a symlink, but it should be resolved when LILO is
> installed, i.e., prior to the reboot. Why has this behaviour changed?
>

Changing it as per your suggestion makes no difference. I still cannot boot,
and the error is identical.

Disregard my last email.

Cheers,
Alistair.

2003-09-22 13:48:15

by Al Viro

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

On Mon, Sep 22, 2003 at 01:17:42PM +0100, Alistair J Strachan wrote:
> One possible explanation is that I have devfs compiled into my kernel. I do
> not, however, have it automatically mounting on boot. It overlays /dev (which
> is populated with original style device nodes) after INIT has loaded.

Amazingly idiotic typo. And yes, it gets hit only if devfs is configured.

diff -u B5-real32/init/do_mounts.h B5-current/init/do_mounts.h
--- B5-real32/init/do_mounts.h Sun Sep 21 21:22:33 2003
+++ B5-current/init/do_mounts.h Mon Sep 22 09:41:21 2003
@@ -53,7 +53,7 @@
static inline u32 bstat(char *name)
{
struct stat64 stat;
- if (!sys_stat64(name, &stat) != 0)
+ if (sys_stat64(name, &stat) != 0)
return 0;
if (!S_ISBLK(stat.st_mode))
return 0;
@@ -65,7 +65,7 @@
static inline u32 bstat(char *name)
{
struct stat stat;
- if (!sys_newstat(name, &stat) != 0)
+ if (sys_newstat(name, &stat) != 0)
return 0;
if (!S_ISBLK(stat.st_mode))
return 0;

2003-09-22 13:50:25

by Alistair John Strachan

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

On Monday 22 September 2003 15:36, Zilvinas Valinskas wrote:
[snip]
> >
> > VFS: Cannot open root device "302" or hda2.
> > Please append correct "root=" boot option.
> > Kernel Panic: VFS: Unable to mount root fs on hda2.
>
> Do you use devfsd ?
>

No. As I said, I mount /dev with mount -t devfs devfs /dev in a sysinit
bootscript. Whether it's in the kernel or not shouldn't make any difference.
Maybe I just need to reissue LILO after booting the 32bit dev_t kernel?

> I had to specify root like this :
> root=/dev/ide/host0/bus0/target0/lun0/part5 then it worked just fine.
>

I'll try that, thanks. But I have this in lilo.conf:

boot=/dev/discs/disc0/disc
root=/dev/discs/disc0/part2

/dev/discs is indeed a symlink, but it should be resolved when LILO is
installed, i.e., prior to the reboot. Why has this behaviour changed?

Cheers,
Alistair.

2003-09-22 14:30:26

by Alistair John Strachan

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

On Monday 22 September 2003 14:48, you wrote:
> On Mon, Sep 22, 2003 at 01:17:42PM +0100, Alistair J Strachan wrote:
> > One possible explanation is that I have devfs compiled into my kernel. I
> > do not, however, have it automatically mounting on boot. It overlays /dev
> > (which is populated with original style device nodes) after INIT has
> > loaded.
>
> Amazingly idiotic typo. And yes, it gets hit only if devfs is configured.
>
> diff -u B5-real32/init/do_mounts.h B5-current/init/do_mounts.h
> --- B5-real32/init/do_mounts.h Sun Sep 21 21:22:33 2003
> +++ B5-current/init/do_mounts.h Mon Sep 22 09:41:21 2003
> @@ -53,7 +53,7 @@
> static inline u32 bstat(char *name)
> {
> struct stat64 stat;
> - if (!sys_stat64(name, &stat) != 0)
> + if (sys_stat64(name, &stat) != 0)
> return 0;
> if (!S_ISBLK(stat.st_mode))
> return 0;
> @@ -65,7 +65,7 @@
> static inline u32 bstat(char *name)
> {
> struct stat stat;
> - if (!sys_newstat(name, &stat) != 0)
> + if (sys_newstat(name, &stat) != 0)
> return 0;
> if (!S_ISBLK(stat.st_mode))
> return 0;

Thanks for that. It's working fine now.

Cheers,
Alistair.

2003-09-22 17:57:23

by Will Dyson

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4: BeFS compile error

On Mon, 2003-09-22 at 07:49, Adrian Bunk wrote:
> On Mon, Sep 22, 2003 at 01:35:48AM -0700, Andrew Morton wrote:
> >...
> > befs-use-parser.patch
> > BEFS: Use table-driven option parsing
> >...
>
> It seems this patch broke the compilation of BeFS:
>
> <-- snip -->
>
> ...
> CC fs/befs/linuxvfs.o
> fs/befs/linuxvfs.c: In function `parse_options':
> fs/befs/linuxvfs.c:712: too few arguments to function `match_int'
> fs/befs/linuxvfs.c:724: too few arguments to function `match_int'
> make[2]: *** [fs/befs/linuxvfs.o] Error 1

Seems Andrew merged a different version of the options patch than the
one that was posted to the list. I can make a fixup tonight.

Also, from looking at the test5-mm4 patch, I think that match_number()
from lib/parser.c is ignoring the base argument and using a hardcoded
value of zero for the simple_strtol() call. This should result in
match_octal() and match_hex() being broken (well, being the same as
match_int).

--
Will Dyson
"Back off man, I'm a scientist!" -Dr. Peter Venkman

2003-09-22 19:11:00

by Adrian Bunk

[permalink] [raw]
Subject: 2.6.0-test5-mm4: wanxl doesn't compile with gcc 2.95

I'm getting the following compile error with gcc 2.95:

<-- snip -->

...
CC drivers/net/wan/wanxl.o
drivers/net/wan/wanxl.c: In function `pci_map_single_debug':
drivers/net/wan/wanxl.c:128: warning: unsigned int format, different type arg (arg 3)
drivers/net/wan/wanxl.c: In function `wanxl_tx_intr':
drivers/net/wan/wanxl.c:185: parse error before `struct'
drivers/net/wan/wanxl.c:200: `skb' undeclared (first use in this function)
drivers/net/wan/wanxl.c:200: (Each undeclared identifier is reported only once
drivers/net/wan/wanxl.c:200: for each function it appears in.)
drivers/net/wan/wanxl.c: In function `wanxl_xmit':
drivers/net/wan/wanxl.c:298: parse error before `*'
drivers/net/wan/wanxl.c:299: `desc' undeclared (first use in this function)
drivers/net/wan/wanxl.c: In function `wanxl_pci_init_one':
drivers/net/wan/wanxl.c:631: warning: unsigned int format, different type arg (arg 3)
drivers/net/wan/wanxl.c: At top level:
drivers/net/wan/wanxl.c:34: warning: `version' defined but not used
make[3]: *** [drivers/net/wan/wanxl.o] Error 1

<-- snip -->

For gcc 2.95, all variable declarations must be at the beginning.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2003-09-22 19:14:41

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

Zilvinas Valinskas <[email protected]> wrote:
>
> Btw Andrew ,
>
> this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver
> from http://w1.894.telia.com/~u89404340/touchpad/index.html.
>
>
> -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/
> 2", "ImPS/2", "ImExPS/2", "Synaptics"};
> +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"};

You mean it breaks the XFree driver? Is it just a matter of editing
XF86Config to tell it the new protocl name?

Either way, it looks like a change which should be reverted?

2003-09-22 19:42:06

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4: wanxl doesn't compile with gcc 2.95

Adrian Bunk <[email protected]> wrote:
>
> I'm getting the following compile error with gcc 2.95:
>
> <-- snip -->
>
> ...
> CC drivers/net/wan/wanxl.o
> drivers/net/wan/wanxl.c: In function `pci_map_single_debug':
> drivers/net/wan/wanxl.c:128: warning: unsigned int format, different type arg (arg 3)
> drivers/net/wan/wanxl.c: In function `wanxl_tx_intr':
> drivers/net/wan/wanxl.c:185: parse error before `struct'


25-akpm/drivers/net/wan/wanxl.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)

diff -puN drivers/net/wan/wanxl.c~wanxl-build-fix drivers/net/wan/wanxl.c
--- 25/drivers/net/wan/wanxl.c~wanxl-build-fix Mon Sep 22 12:18:36 2003
+++ 25-akpm/drivers/net/wan/wanxl.c Mon Sep 22 12:21:30 2003
@@ -125,7 +125,8 @@ static inline dma_addr_t pci_map_single_
dma_addr_t addr = pci_map_single(pdev, ptr, size, direction);
if (addr + size > 0x100000000LL)
printk(KERN_CRIT "wanXL %s: pci_map_single() returned memory"
- " at 0x%X!\n", card_name(pdev), addr);
+ " at 0x%LX!\n",
+ card_name(pdev), (unsigned long long)addr);
return addr;
}

@@ -180,8 +181,7 @@ static inline void wanxl_cable_intr(port
static inline void wanxl_tx_intr(port_t *port)
{
while (1) {
- desc_t *desc;
- desc = &get_status(port)->tx_descs[port->tx_in];
+ desc_t *desc = &get_status(port)->tx_descs[port->tx_in];
struct sk_buff *skb = port->tx_skbs[port->tx_in];

switch (desc->stat) {
@@ -290,12 +290,13 @@ static irqreturn_t wanxl_intr(int irq, v

static int wanxl_xmit(struct sk_buff *skb, struct net_device *dev)
{
+ desc_t *desc;
hdlc_device *hdlc = dev_to_hdlc(dev);
port_t *port = hdlc_to_port(hdlc);

spin_lock(&port->lock);

- desc_t *desc = &get_status(port)->tx_descs[port->tx_out];
+ desc = &get_status(port)->tx_descs[port->tx_out];
if (desc->stat != PACKET_EMPTY) {
/* should never happen - previous xmit should stop queue */
#ifdef DEBUG_PKT

_

2003-09-22 21:28:00

by Peter Osterlund

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

Andrew Morton <[email protected]> writes:

> Zilvinas Valinskas <[email protected]> wrote:
> >
> > Btw Andrew ,
> >
> > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver
> > from http://w1.894.telia.com/~u89404340/touchpad/index.html.
> >
> >
> > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/
> > 2", "ImPS/2", "ImExPS/2", "Synaptics"};
> > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"};
>
> You mean it breaks the XFree driver? Is it just a matter of editing
> XF86Config to tell it the new protocl name?

It breaks the event device auto detection, which works by parsing
/proc/bus/input/devices. The protocol name is hard coded so you can't
just change the XF86Config file.

> Either way, it looks like a change which should be reverted?

I think the new protocol name is better, so why not just fix the X
driver instead. Here is a fixed version:

http://w1.894.telia.com/~u89404340/touchpad/synaptics-0.11.4.tar.bz2

--
Peter Osterlund - [email protected]
http://w1.894.telia.com/~u89404340

2003-09-22 21:44:36

by Vojtech Pavlik

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

On Mon, Sep 22, 2003 at 11:55:09AM -0700, Andrew Morton wrote:
> Zilvinas Valinskas <[email protected]> wrote:
> >
> > Btw Andrew ,
> >
> > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver
> > from http://w1.894.telia.com/~u89404340/touchpad/index.html.
> >
> >
> > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/
> > 2", "ImPS/2", "ImExPS/2", "Synaptics"};
> > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"};
>
> You mean it breaks the XFree driver? Is it just a matter of editing
> XF86Config to tell it the new protocl name?

Ouch? This is just an information string, it is not supposed to be used
anywhere except printks etc ... I really HOPE nobody is parsing these
strings.

Before the patch, the input_dev.name string said

"Synaptics Synaptics Pad", which kind of didn't make much sense.

Since it's a concatenation of protocol, vendor and device names, it
now says

"SynPS/2 Synaptics Pad", which sounds a bit better.

> Either way, it looks like a change which should be reverted?

If it breaks anything, that needs to be fixed in what it broke, because
nothing should depend on this. If it does, then that's a big bug.

--
Vojtech Pavlik
SuSE Labs, SuSE CR

2003-09-22 21:45:51

by Vojtech Pavlik

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

On Mon, Sep 22, 2003 at 11:27:17PM +0200, Peter Osterlund wrote:
> Andrew Morton <[email protected]> writes:
>
> > Zilvinas Valinskas <[email protected]> wrote:
> > >
> > > Btw Andrew ,
> > >
> > > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver
> > > from http://w1.894.telia.com/~u89404340/touchpad/index.html.
> > >
> > >
> > > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/
> > > 2", "ImPS/2", "ImExPS/2", "Synaptics"};
> > > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"};
> >
> > You mean it breaks the XFree driver? Is it just a matter of editing
> > XF86Config to tell it the new protocl name?
>
> It breaks the event device auto detection, which works by parsing
> /proc/bus/input/devices. The protocol name is hard coded so you can't
> just change the XF86Config file.
>
> > Either way, it looks like a change which should be reverted?
>
> I think the new protocol name is better, so why not just fix the X
> driver instead. Here is a fixed version:
>
> http://w1.894.telia.com/~u89404340/touchpad/synaptics-0.11.4.tar.bz2

I'd suggest the driver either checks the BUS/VENDOR/DEVICE ids or the
bitfields for the pad, not the name. Names are unreliable ...

--
Vojtech Pavlik
SuSE Labs, SuSE CR

2003-09-22 23:01:15

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4: wanxl doesn't compile with gcc 2.95

Krzysztof Halasa <[email protected]> wrote:
>
> + " at 0x%LX!\n", card_name(pdev), (u64)addr);

This should be "unsigned long long", not u64. That is what "%L" means,
after all.

2003-09-23 13:37:08

by Krzysztof Halasa

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4: wanxl doesn't compile with gcc 2.95

Andrew Morton <[email protected]> writes:

> > + " at 0x%LX!\n", card_name(pdev), (u64)addr);
>
> This should be "unsigned long long", not u64. That is what "%L" means,
> after all.

Right. I was under an impression they're the same.

I assume you don't want (me to post) a corrected patch, do you?

Thanks.
--
Krzysztof Halasa, B*FH

2003-09-25 00:13:24

by Peter Osterlund

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

Vojtech Pavlik <[email protected]> writes:

> On Mon, Sep 22, 2003 at 11:27:17PM +0200, Peter Osterlund wrote:
> > Andrew Morton <[email protected]> writes:
> >
> > > Zilvinas Valinskas <[email protected]> wrote:
> > > >
> > > > Btw Andrew ,
> > > >
> > > > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver
> > > > from http://w1.894.telia.com/~u89404340/touchpad/index.html.
> > > >
> > > >
> > > > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/
> > > > 2", "ImPS/2", "ImExPS/2", "Synaptics"};
> > > > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"};
> > >
> > > You mean it breaks the XFree driver? Is it just a matter of editing
> > > XF86Config to tell it the new protocl name?
> >
> > It breaks the event device auto detection, which works by parsing
> > /proc/bus/input/devices. The protocol name is hard coded so you can't
> > just change the XF86Config file.
> >
> > > Either way, it looks like a change which should be reverted?
> >
> > I think the new protocol name is better, so why not just fix the X
> > driver instead. Here is a fixed version:
> >
> > http://w1.894.telia.com/~u89404340/touchpad/synaptics-0.11.4.tar.bz2
>
> I'd suggest the driver either checks the BUS/VENDOR/DEVICE ids or the
> bitfields for the pad, not the name. Names are unreliable ...

OK, this is now implemented in version 0.11.5, which I just uploaded
to my web site. This version also adds support for the new events
ABS_TOOL_WIDTH, BTN_TOOL_FINGER, BTN_TOOL_DOUBLETAP and
BTN_TOOL_TRIPLETAP.

--
Peter Osterlund - [email protected]
http://w1.894.telia.com/~u89404340

2003-09-25 12:43:59

by Vojtech Pavlik

[permalink] [raw]
Subject: Re: 2.6.0-test5-mm4

On Thu, Sep 25, 2003 at 02:13:04AM +0200, Peter Osterlund wrote:

> Vojtech Pavlik <[email protected]> writes:
>
> > On Mon, Sep 22, 2003 at 11:27:17PM +0200, Peter Osterlund wrote:
> > > Andrew Morton <[email protected]> writes:
> > >
> > > > Zilvinas Valinskas <[email protected]> wrote:
> > > > >
> > > > > Btw Andrew ,
> > > > >
> > > > > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver
> > > > > from http://w1.894.telia.com/~u89404340/touchpad/index.html.
> > > > >
> > > > >
> > > > > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/
> > > > > 2", "ImPS/2", "ImExPS/2", "Synaptics"};
> > > > > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"};
> > > >
> > > > You mean it breaks the XFree driver? Is it just a matter of editing
> > > > XF86Config to tell it the new protocl name?
> > >
> > > It breaks the event device auto detection, which works by parsing
> > > /proc/bus/input/devices. The protocol name is hard coded so you can't
> > > just change the XF86Config file.
> > >
> > > > Either way, it looks like a change which should be reverted?
> > >
> > > I think the new protocol name is better, so why not just fix the X
> > > driver instead. Here is a fixed version:
> > >
> > > http://w1.894.telia.com/~u89404340/touchpad/synaptics-0.11.4.tar.bz2
> >
> > I'd suggest the driver either checks the BUS/VENDOR/DEVICE ids or the
> > bitfields for the pad, not the name. Names are unreliable ...
>
> OK, this is now implemented in version 0.11.5, which I just uploaded
> to my web site. This version also adds support for the new events
> ABS_TOOL_WIDTH, BTN_TOOL_FINGER, BTN_TOOL_DOUBLETAP and
> BTN_TOOL_TRIPLETAP.

Great, thanks.

--
Vojtech Pavlik
SuSE Labs, SuSE CR