2005-01-22 18:08:46

by Russell King

Subject: I2C algorithm IDs

Greg,

Are I2C algorithm IDs supposed to be unique? Do they have any meaning in
reality at all? If the answer is yes to either of these questions, the
following should probably be resolved:

#define I2C_ALGO_PCA 0x150000 /* PCA 9564 style adapters */
#define I2C_ALGO_SIBYTE 0x150000 /* Broadcom SiByte SOCs */

--
Russell King

2005-02-01 07:40:47

by Greg KH

Subject: Re: I2C algorithm IDs

On Sat, Jan 22, 2005 at 05:47:18PM +0000, Russell King wrote:
> Greg,
>
> Are I2C algorithm IDs supposed to be unique? Do they have any meaning in
> reality at all? If the answer is yes to either of these questions, the
> following should probably be resolved:

Yes, they are used in some places, and yes they do need to be unique.

> #define I2C_ALGO_PCA 0x150000 /* PCA 9564 style adapters */
> #define I2C_ALGO_SIBYTE 0x150000 /* Broadcom SiByte SOCs */

Thanks for pointing this out, I've gone and fixed this up and will send
the patch upward.

thanks,

greg k-h