On Tue, 09 Jan 2007 12:01:14 +0300
Dmitriy Monakhov <[email protected]> wrote:
> network pci drivers have to return correct error code during resume stage in
> case of errors.
> Signed-off-by: Dmitriy Monakhov <[email protected]>
> -----
Please don't introduce one dev_err() call into a device driver if all the other
error printout's use a different interface.
--
Stephen Hemminger <[email protected]>
Stephen Hemminger <[email protected]> writes:
> On Tue, 09 Jan 2007 12:01:14 +0300
> Dmitriy Monakhov <[email protected]> wrote:
>
>> network pci drivers have to return correct error code during resume stage in
>> case of errors.
>> Signed-off-by: Dmitriy Monakhov <[email protected]>
>> -----
>
> Please don't introduce one dev_err() call into a device driver if all the other
> error printout's use a different interface.
Ok. It was wrong decision to fix all affected drivers in one patchset.
Especially without respect to concrete driver specific.
I'll try to rewrite it in more slowly but (i hope) more correct way
>
> --
> Stephen Hemminger <[email protected]>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/