2010-01-06 06:10:48

by Anton Blanchard

[permalink] [raw]
Subject: [patch 0/6] cpumask_of_node() should handle -1 as a node

A number of places in the kernel use cpumask_of_node(-1), but most arch
NUMA implementations are broken. The following patches fix this.

Apologies for the resend, somehow quilt mail screwed up the message ids.

--


2010-01-11 22:11:47

by Andrew Morton

[permalink] [raw]
Subject: Re: [patch 0/6] cpumask_of_node() should handle -1 as a node

On Wed, 06 Jan 2010 15:55:09 +1100
Anton Blanchard <[email protected]> wrote:

> A number of places in the kernel use cpumask_of_node(-1), but most arch
> NUMA implementations are broken. The following patches fix this.
>

So.. what's happening here? Nobody has applied the patches anywhere,
you later said "the scheduler oopses in a number of places with
CPUMASK_OFFSTACK and sparse node ids" and mention of a -stable backport
was mentioned.

2010-01-12 01:09:54

by Anton Blanchard

[permalink] [raw]
Subject: Re: [patch 0/6] cpumask_of_node() should handle -1 as a node


Hi Andrew,

> > A number of places in the kernel use cpumask_of_node(-1), but most arch
> > NUMA implementations are broken. The following patches fix this.
>
> So.. what's happening here? Nobody has applied the patches anywhere,
> you later said "the scheduler oopses in a number of places with
> CPUMASK_OFFSTACK and sparse node ids" and mention of a -stable backport
> was mentioned.

That scheduler issue doesn't appear in mainline as no one is allocating sparse
node IDs yet.

There is still the opportunity for an Oops with CPUMASK_OFFSTACK and
/sys/.../local_cpus and even with CPUMASK_OFFSTACK disabled it will return
random data.

Ralph has picked up the mips bit, Ben is sucking in the powerpc bit.
Davem has acked the sparc bit. I'll roll up a -stable patch once they
hit.

No answer from alpha and ia64.

Anton

2010-01-12 02:06:14

by Anton Blanchard

[permalink] [raw]
Subject: Re: [patch 0/6] cpumask_of_node() should handle -1 as a node


Hi,

> So.. what's happening here? Nobody has applied the patches anywhere,
> you later said "the scheduler oopses in a number of places with
> CPUMASK_OFFSTACK and sparse node ids" and mention of a -stable backport
> was mentioned.

Just checked and it's already upstream on ia64. That just leaves alpha.

Anton