Hello!
This series updates RCU maintainership as follows:
1. Add "R:" designated-reviewers tag as discussed on ksummit-discuss
email list.
2. Add designated reviewers for RCU.
3. Update RCU maintainership.
Thanx, Paul
------------------------------------------------------------------------
b/MAINTAINERS | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
From: "Paul E. McKenney" <[email protected]>
Adding Steven Rostedt, Mathieu Desnoyers, and Lai Jiangshan as designated
RCU reviewers based on recent emails:
o https://lkml.org/lkml/2014/6/2/578 (Steven)
o https://lkml.org/lkml/2014/6/2/621 (Mathieu)
o https://lkml.org/lkml/2014/6/3/897 (Lai)
Signed-off-by: Paul E. McKenney <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
MAINTAINERS | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1814075c0e74..92f2bf91eec1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7405,6 +7405,9 @@ F: kernel/rcu/torture.c
RCUTORTURE TEST FRAMEWORK
M: "Paul E. McKenney" <[email protected]>
+R: Steven Rostedt <[email protected]>
+R: Mathieu Desnoyers <[email protected]>
+R: Lai Jiangshan <[email protected]>
L: [email protected]
S: Supported
T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
@@ -7429,6 +7432,9 @@ F: net/rds/
READ-COPY UPDATE (RCU)
M: Dipankar Sarma <[email protected]>
M: "Paul E. McKenney" <[email protected]>
+R: Steven Rostedt <[email protected]>
+R: Mathieu Desnoyers <[email protected]>
+R: Lai Jiangshan <[email protected]>
L: [email protected]
W: http://www.rdrop.com/users/paulmck/RCU/
S: Supported
@@ -8208,6 +8214,8 @@ F: mm/sl?b.c
SLEEPABLE READ-COPY UPDATE (SRCU)
M: Lai Jiangshan <[email protected]>
M: "Paul E. McKenney" <[email protected]>
+R: Steven Rostedt <[email protected]>
+R: Mathieu Desnoyers <[email protected]>
L: [email protected]
W: http://www.rdrop.com/users/paulmck/RCU/
S: Supported
--
1.8.1.5
From: "Paul E. McKenney" <[email protected]>
A ksummit-discuss email thread looked at the difficulty recruiting
and retaining reviewers. Paul Walmsley also noted the need for patch
submitters to know who the key reviewers are and suggested adding an
"R:" tag to the MAINTAINERS file to record this information on a
per-subsystem basis. This commit does just that, and a subsequent
commit tags the designated reviewer for the RCU-related subsystems.
http://lists.linuxfoundation.org/pipermail/ksummit-discuss/2014-May/000830.html
Suggested-by: Paul Walmsley <[email protected]>
Signed-off-by: Paul E. McKenney <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
Acked-by: Steven Rostedt <[email protected]>
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 134483f206e4..1814075c0e74 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -70,6 +70,8 @@ Descriptions of section entries:
P: Person (obsolete)
M: Mail patches to: FullName <address@domain>
+ R: Designated reviewer: FullName <address@domain>
+ These reviewers should be CCed on patches.
L: Mailing list that is relevant to this area
W: Web-page with status/info
Q: Patchwork web based patch tracking system site
--
1.8.1.5
From: "Paul E. McKenney" <[email protected]>
Drop Dipankar Sarma at his request (https://lkml.org/lkml/2014/6/2/628),
add Josh Triplett based on long-term review, contributions, and
agreement to take on this role (https://lkml.org/lkml/2014/6/2/554).
Signed-off-by: Paul E. McKenney <[email protected]>
---
MAINTAINERS | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 92f2bf91eec1..922661d17083 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7405,6 +7405,7 @@ F: kernel/rcu/torture.c
RCUTORTURE TEST FRAMEWORK
M: "Paul E. McKenney" <[email protected]>
+M: Josh Triplett <[email protected]>
R: Steven Rostedt <[email protected]>
R: Mathieu Desnoyers <[email protected]>
R: Lai Jiangshan <[email protected]>
@@ -7430,8 +7431,8 @@ S: Supported
F: net/rds/
READ-COPY UPDATE (RCU)
-M: Dipankar Sarma <[email protected]>
M: "Paul E. McKenney" <[email protected]>
+M: Josh Triplett <[email protected]>
R: Steven Rostedt <[email protected]>
R: Mathieu Desnoyers <[email protected]>
R: Lai Jiangshan <[email protected]>
@@ -8214,6 +8215,7 @@ F: mm/sl?b.c
SLEEPABLE READ-COPY UPDATE (SRCU)
M: Lai Jiangshan <[email protected]>
M: "Paul E. McKenney" <[email protected]>
+M: Josh Triplett <[email protected]>
R: Steven Rostedt <[email protected]>
R: Mathieu Desnoyers <[email protected]>
L: [email protected]
--
1.8.1.5
On Mon, 2014-07-07 at 15:41 -0700, Paul E. McKenney wrote:
> This series updates RCU maintainership as follows:
>
> 1. Add "R:" designated-reviewers tag as discussed on ksummit-discuss
> email list.
>
> 2. Add designated reviewers for RCU.
>
> 3. Update RCU maintainership.
Missing
4. update get_maintainers...
On Mon, Jul 07, 2014 at 03:42:03PM -0700, Paul E. McKenney wrote:
> MAINTAINERS | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1814075c0e74..92f2bf91eec1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7405,6 +7405,9 @@ F: kernel/rcu/torture.c
>
> RCUTORTURE TEST FRAMEWORK
> M: "Paul E. McKenney" <[email protected]>
> +R: Steven Rostedt <[email protected]>
> +R: Mathieu Desnoyers <[email protected]>
> +R: Lai Jiangshan <[email protected]>
> L: [email protected]
> S: Supported
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
OK,.. so if we're going to do this can we talk about the syntax here.
I would like to also use this for SCHED and PERF, but since both are
rather big I would like to be able to subdivide things. Now I could of
course go create many MAINTAINER sections, but that feels artificial.
So I would like to be able to write:
SCHEDULER:
...
R: Steven Rostedt <[email protected]> (kernel/sched/rt.c)
R: Juri Lelli <[email protected]> (kernel/sched/deadline.c)
or something like that. And here I've already done concessions in that
the above is machine readable. Ideally I'd be able to say things like:
'for sched and numa related things' add 'rik and mel'.
Hmm, maybe we can look at the patch subject tag like: sched/numa or
sched/rt or sched/deadline etc.. instead of the files touched.
On Mon, Jul 07, 2014 at 03:42:04PM -0700, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <[email protected]>
>
> Drop Dipankar Sarma at his request (https://lkml.org/lkml/2014/6/2/628),
> add Josh Triplett based on long-term review, contributions, and
> agreement to take on this role (https://lkml.org/lkml/2014/6/2/554).
>
> Signed-off-by: Paul E. McKenney <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
Does it make sense to keep separate entries for each of these, at this
point, or should we just merge all of them into the main "READ-COPY
UPDATE (RCU)" entry?
> MAINTAINERS | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 92f2bf91eec1..922661d17083 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7405,6 +7405,7 @@ F: kernel/rcu/torture.c
>
> RCUTORTURE TEST FRAMEWORK
> M: "Paul E. McKenney" <[email protected]>
> +M: Josh Triplett <[email protected]>
> R: Steven Rostedt <[email protected]>
> R: Mathieu Desnoyers <[email protected]>
> R: Lai Jiangshan <[email protected]>
> @@ -7430,8 +7431,8 @@ S: Supported
> F: net/rds/
>
> READ-COPY UPDATE (RCU)
> -M: Dipankar Sarma <[email protected]>
> M: "Paul E. McKenney" <[email protected]>
> +M: Josh Triplett <[email protected]>
> R: Steven Rostedt <[email protected]>
> R: Mathieu Desnoyers <[email protected]>
> R: Lai Jiangshan <[email protected]>
> @@ -8214,6 +8215,7 @@ F: mm/sl?b.c
> SLEEPABLE READ-COPY UPDATE (SRCU)
> M: Lai Jiangshan <[email protected]>
> M: "Paul E. McKenney" <[email protected]>
> +M: Josh Triplett <[email protected]>
> R: Steven Rostedt <[email protected]>
> R: Mathieu Desnoyers <[email protected]>
> L: [email protected]
> --
> 1.8.1.5
>
On Tue, 2014-07-08 at 10:09 +0200, Peter Zijlstra wrote:
> On Mon, Jul 07, 2014 at 03:42:03PM -0700, Paul E. McKenney wrote:
> > MAINTAINERS | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 1814075c0e74..92f2bf91eec1 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -7405,6 +7405,9 @@ F: kernel/rcu/torture.c
> >
> > RCUTORTURE TEST FRAMEWORK
> > M: "Paul E. McKenney" <[email protected]>
> > +R: Steven Rostedt <[email protected]>
> > +R: Mathieu Desnoyers <[email protected]>
> > +R: Lai Jiangshan <[email protected]>
> > L: [email protected]
> > S: Supported
> > T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
>
> OK,.. so if we're going to do this can we talk about the syntax here.
>
> I would like to also use this for SCHED and PERF, but since both are
> rather big I would like to be able to subdivide things. Now I could of
> course go create many MAINTAINER sections, but that feels artificial.
>
> So I would like to be able to write:
>
> SCHEDULER:
> ...
> R: Steven Rostedt <[email protected]> (kernel/sched/rt.c)
> R: Juri Lelli <[email protected]> (kernel/sched/deadline.c)
>
> or something like that. And here I've already done concessions in that
> the above is machine readable. Ideally I'd be able to say things like:
> 'for sched and numa related things' add 'rik and mel'.
>
> Hmm, maybe we can look at the patch subject tag like: sched/numa or
> sched/rt or sched/deadline etc.. instead of the files touched.
I think it's best to use separate sections.
The parsing logic in get_maintainers is already ugly enough.
On Tue, Jul 08, 2014 at 11:06:24AM -0700, Joe Perches wrote:
> On Tue, 2014-07-08 at 10:09 +0200, Peter Zijlstra wrote:
> > On Mon, Jul 07, 2014 at 03:42:03PM -0700, Paul E. McKenney wrote:
> > > MAINTAINERS | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 1814075c0e74..92f2bf91eec1 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -7405,6 +7405,9 @@ F: kernel/rcu/torture.c
> > >
> > > RCUTORTURE TEST FRAMEWORK
> > > M: "Paul E. McKenney" <[email protected]>
> > > +R: Steven Rostedt <[email protected]>
> > > +R: Mathieu Desnoyers <[email protected]>
> > > +R: Lai Jiangshan <[email protected]>
> > > L: [email protected]
> > > S: Supported
> > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> >
> > OK,.. so if we're going to do this can we talk about the syntax here.
> >
> > I would like to also use this for SCHED and PERF, but since both are
> > rather big I would like to be able to subdivide things. Now I could of
> > course go create many MAINTAINER sections, but that feels artificial.
> >
> > So I would like to be able to write:
> >
> > SCHEDULER:
> > ...
> > R: Steven Rostedt <[email protected]> (kernel/sched/rt.c)
> > R: Juri Lelli <[email protected]> (kernel/sched/deadline.c)
> >
> > or something like that. And here I've already done concessions in that
> > the above is machine readable. Ideally I'd be able to say things like:
> > 'for sched and numa related things' add 'rik and mel'.
> >
> > Hmm, maybe we can look at the patch subject tag like: sched/numa or
> > sched/rt or sched/deadline etc.. instead of the files touched.
>
> I think it's best to use separate sections.
>
> The parsing logic in get_maintainers is already ugly enough.
OK, here is a basic change. Hey, I figure that if you weren't desperately
in need of entertainment, you would not have asked me to hack a perl script!
Thanx, Paul
------------------------------------------------------------------------
scripts: Teach get_maintainer.pl about the new "R:" tag
We can now designate reviewers in the MAINTAINERS file with the new
"R:" tag, so this commit teaches get_maintainers.pl to add their
email addresses.
Reported-by: Joe Perches <[email protected]>
Signed-off-by: Paul E. McKenney <[email protected]>
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 41987885bd31..03785ce7b5b6 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -536,7 +536,7 @@ sub range_has_maintainer {
if ($line =~ m/^(\C):\s*(.*)/) {
my $type = $1;
my $value = $2;
- if ($type eq 'M') {
+ if ($type eq 'M' || $type eq 'R') {
return 1;
}
}
@@ -1047,7 +1047,7 @@ sub add_categories {
}
}
}
- } elsif ($ptype eq "M") {
+ } elsif ($ptype eq "M" || $ptype eq "R") {
my ($name, $address) = parse_email($pvalue);
if ($name eq "") {
if ($i > 0) {
@@ -1062,7 +1062,11 @@ sub add_categories {
}
if ($email_maintainer) {
my $role = get_maintainer_role($i);
- push_email_addresses($pvalue, $role);
+ if ($ptype eq "M") {
+ push_email_addresses($pvalue, $role);
+ } else {
+ push_email_addresses($pvalue, "designated reviewer");
+ }
}
} elsif ($ptype eq "T") {
push(@scm, $pvalue);
On Tue, Jul 08, 2014 at 10:58:55AM -0700, Josh Triplett wrote:
> On Mon, Jul 07, 2014 at 03:42:04PM -0700, Paul E. McKenney wrote:
> > From: "Paul E. McKenney" <[email protected]>
> >
> > Drop Dipankar Sarma at his request (https://lkml.org/lkml/2014/6/2/628),
> > add Josh Triplett based on long-term review, contributions, and
> > agreement to take on this role (https://lkml.org/lkml/2014/6/2/554).
> >
> > Signed-off-by: Paul E. McKenney <[email protected]>
>
> Reviewed-by: Josh Triplett <[email protected]>
Got it, thank you!
> Does it make sense to keep separate entries for each of these, at this
> point, or should we just merge all of them into the main "READ-COPY
> UPDATE (RCU)" entry?
Good question! Let's see how we feel about it now, and then again a
year from now.
Thanx, Paul
> > MAINTAINERS | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 92f2bf91eec1..922661d17083 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -7405,6 +7405,7 @@ F: kernel/rcu/torture.c
> >
> > RCUTORTURE TEST FRAMEWORK
> > M: "Paul E. McKenney" <[email protected]>
> > +M: Josh Triplett <[email protected]>
> > R: Steven Rostedt <[email protected]>
> > R: Mathieu Desnoyers <[email protected]>
> > R: Lai Jiangshan <[email protected]>
> > @@ -7430,8 +7431,8 @@ S: Supported
> > F: net/rds/
> >
> > READ-COPY UPDATE (RCU)
> > -M: Dipankar Sarma <[email protected]>
> > M: "Paul E. McKenney" <[email protected]>
> > +M: Josh Triplett <[email protected]>
> > R: Steven Rostedt <[email protected]>
> > R: Mathieu Desnoyers <[email protected]>
> > R: Lai Jiangshan <[email protected]>
> > @@ -8214,6 +8215,7 @@ F: mm/sl?b.c
> > SLEEPABLE READ-COPY UPDATE (SRCU)
> > M: Lai Jiangshan <[email protected]>
> > M: "Paul E. McKenney" <[email protected]>
> > +M: Josh Triplett <[email protected]>
> > R: Steven Rostedt <[email protected]>
> > R: Mathieu Desnoyers <[email protected]>
> > L: [email protected]
> > --
> > 1.8.1.5
> >
>
On Tue, 2014-07-08 at 13:41 -0700, Paul E. McKenney wrote:
> On Tue, Jul 08, 2014 at 11:06:24AM -0700, Joe Perches wrote:
> > On Tue, 2014-07-08 at 10:09 +0200, Peter Zijlstra wrote:
> > > On Mon, Jul 07, 2014 at 03:42:03PM -0700, Paul E. McKenney wrote:
> > > > MAINTAINERS | 8 ++++++++
> > > > 1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 1814075c0e74..92f2bf91eec1 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -7405,6 +7405,9 @@ F: kernel/rcu/torture.c
> > > >
> > > > RCUTORTURE TEST FRAMEWORK
> > > > M: "Paul E. McKenney" <[email protected]>
> > > > +R: Steven Rostedt <[email protected]>
> > > > +R: Mathieu Desnoyers <[email protected]>
> > > > +R: Lai Jiangshan <[email protected]>
> > > > L: [email protected]
> > > > S: Supported
> > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> > >
> > > OK,.. so if we're going to do this can we talk about the syntax here.
> > >
> > > I would like to also use this for SCHED and PERF, but since both are
> > > rather big I would like to be able to subdivide things. Now I could of
> > > course go create many MAINTAINER sections, but that feels artificial.
> > >
> > > So I would like to be able to write:
> > >
> > > SCHEDULER:
> > > ...
> > > R: Steven Rostedt <[email protected]> (kernel/sched/rt.c)
> > > R: Juri Lelli <[email protected]> (kernel/sched/deadline.c)
> > >
> > > or something like that. And here I've already done concessions in that
> > > the above is machine readable. Ideally I'd be able to say things like:
> > > 'for sched and numa related things' add 'rik and mel'.
> > >
> > > Hmm, maybe we can look at the patch subject tag like: sched/numa or
> > > sched/rt or sched/deadline etc.. instead of the files touched.
> >
> > I think it's best to use separate sections.
> >
> > The parsing logic in get_maintainers is already ugly enough.
>
> OK, here is a basic change. Hey, I figure that if you weren't desperately
> in need of entertainment, you would not have asked me to hack a perl script!
>
> Thanx, Paul
>
> ------------------------------------------------------------------------
>
> scripts: Teach get_maintainer.pl about the new "R:" tag
>
> We can now designate reviewers in the MAINTAINERS file with the new
> "R:" tag, so this commit teaches get_maintainers.pl to add their
> email addresses.
>
> Reported-by: Joe Perches <[email protected]>
> Signed-off-by: Paul E. McKenney <[email protected]>
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 41987885bd31..03785ce7b5b6 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -536,7 +536,7 @@ sub range_has_maintainer {
> if ($line =~ m/^(\C):\s*(.*)/) {
> my $type = $1;
> my $value = $2;
> - if ($type eq 'M') {
> + if ($type eq 'M' || $type eq 'R') {
> return 1;
> }
> }
> @@ -1047,7 +1047,7 @@ sub add_categories {
> }
> }
> }..
> - } elsif ($ptype eq "M") {
> + } elsif ($ptype eq "M" || $ptype eq "R") {
> my ($name, $address) = parse_email($pvalue);
> if ($name eq "") {
> if ($i > 0) {
> @@ -1062,7 +1062,11 @@ sub add_categories {
> }
> if ($email_maintainer) {
> my $role = get_maintainer_role($i);
> - push_email_addresses($pvalue, $role);
> + if ($ptype eq "M") {
> + push_email_addresses($pvalue, $role);
> + } else {
> + push_email_addresses($pvalue, "designated reviewer");
> + }
> }
> } elsif ($ptype eq "T") {
> push(@scm, $pvalue);
>
Paul, I already sent you a better version over a month ago.
https://lkml.org/lkml/2014/6/2/585
On Tue, Jul 08, 2014 at 02:01:04PM -0700, Joe Perches wrote:
> On Tue, 2014-07-08 at 13:41 -0700, Paul E. McKenney wrote:
> > On Tue, Jul 08, 2014 at 11:06:24AM -0700, Joe Perches wrote:
> > > On Tue, 2014-07-08 at 10:09 +0200, Peter Zijlstra wrote:
> > > > On Mon, Jul 07, 2014 at 03:42:03PM -0700, Paul E. McKenney wrote:
> > > > > MAINTAINERS | 8 ++++++++
> > > > > 1 file changed, 8 insertions(+)
> > > > >
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index 1814075c0e74..92f2bf91eec1 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -7405,6 +7405,9 @@ F: kernel/rcu/torture.c
> > > > >
> > > > > RCUTORTURE TEST FRAMEWORK
> > > > > M: "Paul E. McKenney" <[email protected]>
> > > > > +R: Steven Rostedt <[email protected]>
> > > > > +R: Mathieu Desnoyers <[email protected]>
> > > > > +R: Lai Jiangshan <[email protected]>
> > > > > L: [email protected]
> > > > > S: Supported
> > > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> > > >
> > > > OK,.. so if we're going to do this can we talk about the syntax here.
> > > >
> > > > I would like to also use this for SCHED and PERF, but since both are
> > > > rather big I would like to be able to subdivide things. Now I could of
> > > > course go create many MAINTAINER sections, but that feels artificial.
> > > >
> > > > So I would like to be able to write:
> > > >
> > > > SCHEDULER:
> > > > ...
> > > > R: Steven Rostedt <[email protected]> (kernel/sched/rt.c)
> > > > R: Juri Lelli <[email protected]> (kernel/sched/deadline.c)
> > > >
> > > > or something like that. And here I've already done concessions in that
> > > > the above is machine readable. Ideally I'd be able to say things like:
> > > > 'for sched and numa related things' add 'rik and mel'.
> > > >
> > > > Hmm, maybe we can look at the patch subject tag like: sched/numa or
> > > > sched/rt or sched/deadline etc.. instead of the files touched.
> > >
> > > I think it's best to use separate sections.
> > >
> > > The parsing logic in get_maintainers is already ugly enough.
> >
> > OK, here is a basic change. Hey, I figure that if you weren't desperately
> > in need of entertainment, you would not have asked me to hack a perl script!
> >
> > Thanx, Paul
> >
> > ------------------------------------------------------------------------
> >
> > scripts: Teach get_maintainer.pl about the new "R:" tag
[ . . . ]
> Paul, I already sent you a better version over a month ago.
That would explain why I had already forgotten about it. ;-)
> https://lkml.org/lkml/2014/6/2/585
Unless you tell me otherwise, I assume that this means that you are
OK with my adding your Signed-off-by to that patch. (The lack thereof
being another reason I would not have queued it.) Please see below for
the proposed commit log and Signed-off-by.
If you don't tell me otherwise, I will submit this to the next merge
window.
Thanx, Paul
------------------------------------------------------------------------
scripts: Teach get_maintainer.pl about the new "R:" tag
We can now designate reviewers in the MAINTAINERS file with the new
"R:" tag, so this commit teaches get_maintainers.pl to add their
email addresses.
Signed-off-by: Joe Perches <[email protected]>
Signed-off-by: Paul E. McKenney <[email protected]>
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 41987885bd31..d7016279ec2b 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -21,6 +21,7 @@ my $lk_path = "./";
my $email = 1;
my $email_usename = 1;
my $email_maintainer = 1;
+my $email_reviewer = 1;
my $email_list = 1;
my $email_subscriber_list = 0;
my $email_git_penguin_chiefs = 0;
@@ -202,6 +203,7 @@ if (!GetOptions(
'remove-duplicates!' => \$email_remove_duplicates,
'mailmap!' => \$email_use_mailmap,
'm!' => \$email_maintainer,
+ 'r!' => \$email_reviewer,
'n!' => \$email_usename,
'l!' => \$email_list,
's!' => \$email_subscriber_list,
@@ -260,7 +262,8 @@ if ($sections) {
}
if ($email &&
- ($email_maintainer + $email_list + $email_subscriber_list +
+ ($email_maintainer + $email_reviewer +
+ $email_list + $email_subscriber_list +
$email_git + $email_git_penguin_chiefs + $email_git_blame) == 0) {
die "$P: Please select at least 1 email option\n";
}
@@ -750,6 +753,7 @@ MAINTAINER field selection options:
--hg-since => hg history to use (default: $email_hg_since)
--interactive => display a menu (mostly useful if used with the --git option)
--m => include maintainer(s) if any
+ --r => include reviewer(s) if any
--n => include name 'Full Name <addr\@domain.tld>'
--l => include list(s) if any
--s => include subscriber only list(s) if any
@@ -1064,6 +1068,22 @@ sub add_categories {
my $role = get_maintainer_role($i);
push_email_addresses($pvalue, $role);
}
+ } elsif ($ptype eq "R") {
+ my ($name, $address) = parse_email($pvalue);
+ if ($name eq "") {
+ if ($i > 0) {
+ my $tv = $typevalue[$i - 1];
+ if ($tv =~ m/^(\C):\s*(.*)/) {
+ if ($1 eq "P") {
+ $name = $2;
+ $pvalue = format_email($name, $address, $email_usename);
+ }
+ }
+ }
+ }
+ if ($email_reviewer) {
+ push_email_addresses($pvalue, 'reviewer');
+ }
} elsif ($ptype eq "T") {
push(@scm, $pvalue);
} elsif ($ptype eq "W") {
On Tue, 2014-07-08 at 14:52 -0700, Paul E. McKenney wrote:
> On Tue, Jul 08, 2014 at 02:01:04PM -0700, Joe Perches wrote:
> > On Tue, 2014-07-08 at 13:41 -0700, Paul E. McKenney wrote:
[]
> > > scripts: Teach get_maintainer.pl about the new "R:" tag
>
> [ . . . ]
>
> > Paul, I already sent you a better version over a month ago.
>
> That would explain why I had already forgotten about it. ;-)
>
> > https://lkml.org/lkml/2014/6/2/585
Too bad because you added your own "tested-by"
in a reply. :p
> Unless you tell me otherwise, I assume that this means that you are
> OK with my adding your Signed-off-by to that patch. (The lack thereof
> being another reason I would not have queued it.) Please see below for
> the proposed commit log and Signed-off-by.
>
> If you don't tell me otherwise, I will submit this to the next merge
> window.
Swell.
I still think the concept is pretty useless and it's
just a duplication of "M:", which isn't anything other
than a list of who should be sent patches.
MAINTAINERS describes the "M:" letter as just:
M: Mail patches to: FullName <address@domain>
It doesn't describe anything like a pull hierarchy
or even describe actual maintainership.
But if "R:" is going to go in, then get_maintainers
should be updated at the same time.
btw: most "M:" entries aren't actual maintainers.
Maybe those non-maintainer "M:" entries should be
converted to the "R:" category and "M:" should
only be used to describe for the pull hierarchy.
On Tue, Jul 08, 2014 at 03:05:16PM -0700, Joe Perches wrote:
> On Tue, 2014-07-08 at 14:52 -0700, Paul E. McKenney wrote:
> > On Tue, Jul 08, 2014 at 02:01:04PM -0700, Joe Perches wrote:
> > > On Tue, 2014-07-08 at 13:41 -0700, Paul E. McKenney wrote:
> []
> > > > scripts: Teach get_maintainer.pl about the new "R:" tag
> >
> > [ . . . ]
> >
> > > Paul, I already sent you a better version over a month ago.
> >
> > That would explain why I had already forgotten about it. ;-)
> >
> > > https://lkml.org/lkml/2014/6/2/585
>
> Too bad because you added your own "tested-by"
> in a reply. :p
That was because I was for whatever reason thinking that Someone Else
was going to be queueing these. As it stands, I have a Signed-off-by,
which in my case implies Tested-by.
> > Unless you tell me otherwise, I assume that this means that you are
> > OK with my adding your Signed-off-by to that patch. (The lack thereof
> > being another reason I would not have queued it.) Please see below for
> > the proposed commit log and Signed-off-by.
> >
> > If you don't tell me otherwise, I will submit this to the next merge
> > window.
>
> Swell.
>
> I still think the concept is pretty useless and it's
> just a duplication of "M:", which isn't anything other
> than a list of who should be sent patches.
>
> MAINTAINERS describes the "M:" letter as just:
>
> M: Mail patches to: FullName <address@domain>
>
> It doesn't describe anything like a pull hierarchy
> or even describe actual maintainership.
>
> But if "R:" is going to go in, then get_maintainers
> should be updated at the same time.
>
> btw: most "M:" entries aren't actual maintainers.
>
> Maybe those non-maintainer "M:" entries should be
> converted to the "R:" category and "M:" should
> only be used to describe for the pull hierarchy.
It will be interesting to see how things go. There did seem to be
some people who were comfortable being listed as RCU reviewers, but
not as RCU maintainers. Perhaps the same thing happens elsewhere.
Thanx, Paul
On Tue, 2014-07-08 at 15:25 -0700, Paul E. McKenney wrote:
> On Tue, Jul 08, 2014 at 03:05:16PM -0700, Joe Perches wrote:
[]
> > I still think the concept is pretty useless and it's
> > just a duplication of "M:", which isn't anything other
> > than a list of who should be sent patches.
[]
> It will be interesting to see how things go.
Yes, it might work out fine and maybe might cause some
other beneficial changes.
> There did seem to be
> some people who were comfortable being listed as RCU reviewers, but
> not as RCU maintainers. Perhaps the same thing happens elsewhere.
Maybe so.
I wrote a script to find which maintainer addresses that
haven't signed or authored a commit in the last 2 years.
I got ~250 entries. That's about 1/4 of all maintainer
email addresses.
Maybe a dozen of these are false positives though because
some maintainers prefer to receive email at one address
but ack from another.
These are all lowercase for better matching.
abhijit mahajan <[email protected]>
achim leubner <[email protected]>
adam radford <[email protected]>
al cho <[email protected]>
ali akcaagac <[email protected]>
allan stephens <[email protected]>
aloisio almeida jr <[email protected]>
andreas dilger <[email protected]>
andreas koensgen <[email protected]>
andrew hendry <[email protected]>
andrew veliath <[email protected]>
andries brouwer <[email protected]>
andy henroid <[email protected]>
anil ravindranath <[email protected]>
anil s keshavamurthy <[email protected]>
antoine jacquet <[email protected]>
antonino daplas <[email protected]>
armin schindler <[email protected]>
artur paszkiewicz <[email protected]>
"arvind r." <[email protected]>
ashley lai <[email protected]>
aurelien jacquiot <[email protected]>
balbir singh <[email protected]>
bill metzenthen <[email protected]>
bradley grove <[email protected]>
brett rudley <[email protected]>
brian johnson <[email protected]>
bruce chang <[email protected]>
bryan huntsman <[email protected]>
[email protected]
cesar miquel <[email protected]>
cezary jackiewicz <[email protected]>
chaoming li <[email protected]>
chen liqin <[email protected]>
chien yen <[email protected]>
chirag kantharia <[email protected]>
chris brannon <[email protected]>
christine caulfield <[email protected]>
christopher harrer <[email protected]>
"christopher li" <[email protected]>
christoph raisch <[email protected]>
cliff whickman <[email protected]>
colin leroy <[email protected]>
corentin labbe <[email protected]>
daniel drake <[email protected]>
daniele venzano <[email protected]>
daniel oliveira nascimento <[email protected]>
daniel ribeiro <[email protected]>
dario ballabio <[email protected]>
david kershner <[email protected]>
david rowe <[email protected]>
david safford <[email protected]>
david t?ht <[email protected]>
deepak saxena <[email protected]>
dirk eibach <[email protected]>
dirk opfer <[email protected]>
dmitry tarnyagin <[email protected]>
dominik brodowski <[email protected]>
doug gilbert <[email protected]>
doug thompson <[email protected]>
doug warzecha <[email protected]>
duncan sands <[email protected]>
"ed l. cashin" <[email protected]>
egor martovetsky <[email protected]>
eric biederman <[email protected]>
eric piel <[email protected]>
erik andren <[email protected]>
faisal latif <[email protected]>
ferenc bakonyi <[email protected]>
florian schilhabel <[email protected]>.
forest bond <[email protected]>
frank seidel <[email protected]>
fujita tomonori <[email protected]>
gary zambrano <[email protected]>
gilles muller <[email protected]>
gleb natapov <[email protected]>
guillaume ligneul <[email protected]>
guo-fu tseng <[email protected]>
gustavo padovan <[email protected]>
haavard skinnemoen <[email protected]>
hal rosenstock <[email protected]>
hansjoerg lipp <[email protected]>
hans ulli kroll <[email protected]>
harald welte <[email protected]>
harald welte <[email protected]>
henk vergonet <[email protected]>
henrique de moraes holschuh <[email protected]>
herton ronaldo krzesinski <[email protected]>
heungjun kim <[email protected]>
hideaki yoshifuji <[email protected]>
hoang-nam nguyen <[email protected]>
hubert feurstein <[email protected]>
"hung hing lun, mike" <[email protected]>
ian campbell <[email protected]>
ian molton <[email protected]>
ion badulescu <[email protected]>
ishizaki kou <[email protected]>
ivan kokshaysky <[email protected]>
jakub schmidtke <[email protected]>
"james e.j. bottomley" <[email protected]>
"james e.j. bottomley" <[email protected]>
"james e.j. bottomley" <[email protected]>
james morris <[email protected]>
"james r. van zandt" <[email protected]>
jamie lenehan <[email protected]>
jan-benedict glaw <[email protected]>
jan dumon <[email protected]>
jan harkes <[email protected]>
jan-simon moeller <[email protected]>
jarkko lavinen <[email protected]>
jarod wilson <[email protected]>
jason uhlenkott <[email protected]>
jaya kumar <[email protected]>
jaya kumar <[email protected]>
jay cliburn <[email protected]>
jean-paul roubelat <[email protected]>
jeff dike <[email protected]>
jens osterkamp <[email protected]>
jes sorensen <[email protected]>
jim paris <[email protected]>
jiri kosina <[email protected]>
jiri slaby <[email protected]>
joerg reuter <[email protected]>
joern engel <[email protected]>
johan hedberg <[email protected]>
john mccutchan <[email protected]>
john ronciak <[email protected]>
"john w. linville" <[email protected]>
jonathan buzzard <[email protected]>
"jon d. mason" <[email protected]>
jon nettleton <[email protected]>
josh triplett <[email protected]>
joshua morris <[email protected]>
joshua thompson <[email protected]>
juanjo ciarlante <[email protected]>
"juergen e. fischer" <[email protected]>
juergen stuber <[email protected]>
juerg haefliger <[email protected]>
kentaro takeda <[email protected]>
kevin curtis <[email protected]>
kevin hilman <[email protected]>
kirk reiser <[email protected]>
koichi yasutake <[email protected]>
kristoffer glembo <[email protected]>
kurt garloff <[email protected]>
leandro costantino <[email protected]>
len brown <[email protected]>
lennert buytenhek <[email protected]>
liam girdwood <[email protected]>
liam girdwood <[email protected]>
lior dotan <[email protected]>
"luis r. rodriguez" <[email protected]>
maik broemme <[email protected]>
manohar vanga <[email protected]>
marcelo henrique cerri <[email protected]>
marc hulsman <[email protected]>
"mark f. brown" <[email protected]>
martin mares <[email protected]>
matthew wilcox <[email protected]>
matt mackall <[email protected]>
maxim krasnyansky <[email protected]>
michael hanselmann <[email protected]>
michael petchkovsky <[email protected]>
michael reed <[email protected]>
michal januszewski <[email protected]>
michal ostrowski <[email protected]>
miguel ojeda sandonis <[email protected]>
mikael starvik <[email protected]>
mike marciniszyn <[email protected]>
mike rapoport <[email protected]>
miloslav trmac <[email protected]>
miroslav zagorac <[email protected]>
mitchell blank jr <[email protected]>
muli ben-yehuda <[email protected]>
nagalakshmi nandigama <[email protected]>
neela syam kolli <[email protected]>
nelson castillo <[email protected]>
nicholas a. bellinger <[email protected]>
nick piggin <[email protected]>
olav kongas <[email protected]>
olivier lorin <[email protected]>
pantelis antoniou <[email protected]>
pat gefre <[email protected]>
paul mackerras <[email protected]>
pau oliva fora <[email protected]>
peter chubb <[email protected]>
peter feuerer <[email protected]>
philip blundell <[email protected]>
philip kelleher <[email protected]>
philip moltmann <[email protected]>
praveen krishnamoorthy <[email protected]>
rakesh iyer <[email protected]>
ranganathan desikan <[email protected]>
remi denis-courmont <[email protected]>
riccardo facchetti <[email protected]>
richard l maliszewski <[email protected]>
"richard russon (flatcap)" <[email protected]>
rik faith <[email protected]>
robert gerlach <[email protected]>
robert love <[email protected]>
robert love <[email protected]>
rob herring <[email protected]>
roland dreier <[email protected]>
roland mcgrath <[email protected]>
ron mercer <[email protected]>
ron minnich <[email protected]>
samuel chessman <[email protected]>
santosh raspatur <[email protected]>
scott murray <[email protected]>
sergey lapin <[email protected]>
shane wang <[email protected]>
simon arlott <[email protected]>
simon kelley <[email protected]>
sorbica shieh <[email protected]>
srinivas kandagatla <[email protected]>
stefan eletzhofer <[email protected]>
stefano brivio <[email protected]>
steve french <[email protected]>
steve sakoman <[email protected]>
steve underwood <[email protected]>
steve wise <[email protected]>
subbu seetharaman <[email protected]>
sudarsana kalluru <[email protected]>
sujith thomas <[email protected]>
teddy wang <[email protected]>
terje bergstr?m <[email protected]>
thibaut varene <[email protected]>
thomas dahlmann <[email protected]>
thomas winischhofer <[email protected]>
"tigran a. aivazian" <[email protected]>
tigran aivazian <[email protected]>
till harbaum <[email protected]>
tim small <[email protected]>
tim waugh <[email protected]>
tony finch <[email protected]>
tony olech <[email protected]>
torben mathiasen <[email protected]>
ulrich kunitz <[email protected]>
vegard nossum <[email protected]>
ville syrjala <[email protected]>
vishwas a deshpande <[email protected]>
vitaly bordug <[email protected]>
vitaly bordug <[email protected]>
wensong zhang <[email protected]>
willem riede <[email protected]>
willy tarreau <[email protected]>
"wong hoi sing, edison" <[email protected]>
xavier deguillard <[email protected]>
yokota hiroshi <[email protected]>
zhang wei <[email protected]>
zwane mwaikambo <[email protected]>
On Tue, Jul 08, 2014 at 09:09:25PM -0700, Joe Perches wrote:
> On Tue, 2014-07-08 at 15:25 -0700, Paul E. McKenney wrote:
> > On Tue, Jul 08, 2014 at 03:05:16PM -0700, Joe Perches wrote:
> []
> > > I still think the concept is pretty useless and it's
> > > just a duplication of "M:", which isn't anything other
> > > than a list of who should be sent patches.
> []
> > It will be interesting to see how things go.
>
> Yes, it might work out fine and maybe might cause some
> other beneficial changes.
>
> > There did seem to be
> > some people who were comfortable being listed as RCU reviewers, but
> > not as RCU maintainers. Perhaps the same thing happens elsewhere.
>
> Maybe so.
>
> I wrote a script to find which maintainer addresses that
> haven't signed or authored a commit in the last 2 years.
>
> I got ~250 entries. That's about 1/4 of all maintainer
> email addresses.
>
> Maybe a dozen of these are false positives though because
> some maintainers prefer to receive email at one address
> but ack from another.
>
> These are all lowercase for better matching.
I am not too surprised. There is currently no penalty for keeping a
stale maintainer listing, and possibly severe social penalties for
wrongly removing one. ;-)
Thanx, Paul
> abhijit mahajan <[email protected]>
> achim leubner <[email protected]>
> adam radford <[email protected]>
> al cho <[email protected]>
> ali akcaagac <[email protected]>
> allan stephens <[email protected]>
> aloisio almeida jr <[email protected]>
> andreas dilger <[email protected]>
> andreas koensgen <[email protected]>
> andrew hendry <[email protected]>
> andrew veliath <[email protected]>
> andries brouwer <[email protected]>
> andy henroid <[email protected]>
> anil ravindranath <[email protected]>
> anil s keshavamurthy <[email protected]>
> antoine jacquet <[email protected]>
> antonino daplas <[email protected]>
> armin schindler <[email protected]>
> artur paszkiewicz <[email protected]>
> "arvind r." <[email protected]>
> ashley lai <[email protected]>
> aurelien jacquiot <[email protected]>
> balbir singh <[email protected]>
> bill metzenthen <[email protected]>
> bradley grove <[email protected]>
> brett rudley <[email protected]>
> brian johnson <[email protected]>
> bruce chang <[email protected]>
> bryan huntsman <[email protected]>
> [email protected]
> cesar miquel <[email protected]>
> cezary jackiewicz <[email protected]>
> chaoming li <[email protected]>
> chen liqin <[email protected]>
> chien yen <[email protected]>
> chirag kantharia <[email protected]>
> chris brannon <[email protected]>
> christine caulfield <[email protected]>
> christopher harrer <[email protected]>
> "christopher li" <[email protected]>
> christoph raisch <[email protected]>
> cliff whickman <[email protected]>
> colin leroy <[email protected]>
> corentin labbe <[email protected]>
> daniel drake <[email protected]>
> daniele venzano <[email protected]>
> daniel oliveira nascimento <[email protected]>
> daniel ribeiro <[email protected]>
> dario ballabio <[email protected]>
> david kershner <[email protected]>
> david rowe <[email protected]>
> david safford <[email protected]>
> david t?ht <[email protected]>
> deepak saxena <[email protected]>
> dirk eibach <[email protected]>
> dirk opfer <[email protected]>
> dmitry tarnyagin <[email protected]>
> dominik brodowski <[email protected]>
> doug gilbert <[email protected]>
> doug thompson <[email protected]>
> doug warzecha <[email protected]>
> duncan sands <[email protected]>
> "ed l. cashin" <[email protected]>
> egor martovetsky <[email protected]>
> eric biederman <[email protected]>
> eric piel <[email protected]>
> erik andren <[email protected]>
> faisal latif <[email protected]>
> ferenc bakonyi <[email protected]>
> florian schilhabel <[email protected]>.
> forest bond <[email protected]>
> frank seidel <[email protected]>
> fujita tomonori <[email protected]>
> gary zambrano <[email protected]>
> gilles muller <[email protected]>
> gleb natapov <[email protected]>
> guillaume ligneul <[email protected]>
> guo-fu tseng <[email protected]>
> gustavo padovan <[email protected]>
> haavard skinnemoen <[email protected]>
> hal rosenstock <[email protected]>
> hansjoerg lipp <[email protected]>
> hans ulli kroll <[email protected]>
> harald welte <[email protected]>
> harald welte <[email protected]>
> henk vergonet <[email protected]>
> henrique de moraes holschuh <[email protected]>
> herton ronaldo krzesinski <[email protected]>
> heungjun kim <[email protected]>
> hideaki yoshifuji <[email protected]>
> hoang-nam nguyen <[email protected]>
> hubert feurstein <[email protected]>
> "hung hing lun, mike" <[email protected]>
> ian campbell <[email protected]>
> ian molton <[email protected]>
> ion badulescu <[email protected]>
> ishizaki kou <[email protected]>
> ivan kokshaysky <[email protected]>
> jakub schmidtke <[email protected]>
> "james e.j. bottomley" <[email protected]>
> "james e.j. bottomley" <[email protected]>
> "james e.j. bottomley" <[email protected]>
> james morris <[email protected]>
> "james r. van zandt" <[email protected]>
> jamie lenehan <[email protected]>
> jan-benedict glaw <[email protected]>
> jan dumon <[email protected]>
> jan harkes <[email protected]>
> jan-simon moeller <[email protected]>
> jarkko lavinen <[email protected]>
> jarod wilson <[email protected]>
> jason uhlenkott <[email protected]>
> jaya kumar <[email protected]>
> jaya kumar <[email protected]>
> jay cliburn <[email protected]>
> jean-paul roubelat <[email protected]>
> jeff dike <[email protected]>
> jens osterkamp <[email protected]>
> jes sorensen <[email protected]>
> jim paris <[email protected]>
> jiri kosina <[email protected]>
> jiri slaby <[email protected]>
> joerg reuter <[email protected]>
> joern engel <[email protected]>
> johan hedberg <[email protected]>
> john mccutchan <[email protected]>
> john ronciak <[email protected]>
> "john w. linville" <[email protected]>
> jonathan buzzard <[email protected]>
> "jon d. mason" <[email protected]>
> jon nettleton <[email protected]>
> josh triplett <[email protected]>
> joshua morris <[email protected]>
> joshua thompson <[email protected]>
> juanjo ciarlante <[email protected]>
> "juergen e. fischer" <[email protected]>
> juergen stuber <[email protected]>
> juerg haefliger <[email protected]>
> kentaro takeda <[email protected]>
> kevin curtis <[email protected]>
> kevin hilman <[email protected]>
> kirk reiser <[email protected]>
> koichi yasutake <[email protected]>
> kristoffer glembo <[email protected]>
> kurt garloff <[email protected]>
> leandro costantino <[email protected]>
> len brown <[email protected]>
> lennert buytenhek <[email protected]>
> liam girdwood <[email protected]>
> liam girdwood <[email protected]>
> lior dotan <[email protected]>
> "luis r. rodriguez" <[email protected]>
> maik broemme <[email protected]>
> manohar vanga <[email protected]>
> marcelo henrique cerri <[email protected]>
> marc hulsman <[email protected]>
> "mark f. brown" <[email protected]>
> martin mares <[email protected]>
> matthew wilcox <[email protected]>
> matt mackall <[email protected]>
> maxim krasnyansky <[email protected]>
> michael hanselmann <[email protected]>
> michael petchkovsky <[email protected]>
> michael reed <[email protected]>
> michal januszewski <[email protected]>
> michal ostrowski <[email protected]>
> miguel ojeda sandonis <[email protected]>
> mikael starvik <[email protected]>
> mike marciniszyn <[email protected]>
> mike rapoport <[email protected]>
> miloslav trmac <[email protected]>
> miroslav zagorac <[email protected]>
> mitchell blank jr <[email protected]>
> muli ben-yehuda <[email protected]>
> nagalakshmi nandigama <[email protected]>
> neela syam kolli <[email protected]>
> nelson castillo <[email protected]>
> nicholas a. bellinger <[email protected]>
> nick piggin <[email protected]>
> olav kongas <[email protected]>
> olivier lorin <[email protected]>
> pantelis antoniou <[email protected]>
> pat gefre <[email protected]>
> paul mackerras <[email protected]>
> pau oliva fora <[email protected]>
> peter chubb <[email protected]>
> peter feuerer <[email protected]>
> philip blundell <[email protected]>
> philip kelleher <[email protected]>
> philip moltmann <[email protected]>
> praveen krishnamoorthy <[email protected]>
> rakesh iyer <[email protected]>
> ranganathan desikan <[email protected]>
> remi denis-courmont <[email protected]>
> riccardo facchetti <[email protected]>
> richard l maliszewski <[email protected]>
> "richard russon (flatcap)" <[email protected]>
> rik faith <[email protected]>
> robert gerlach <[email protected]>
> robert love <[email protected]>
> robert love <[email protected]>
> rob herring <[email protected]>
> roland dreier <[email protected]>
> roland mcgrath <[email protected]>
> ron mercer <[email protected]>
> ron minnich <[email protected]>
> samuel chessman <[email protected]>
> santosh raspatur <[email protected]>
> scott murray <[email protected]>
> sergey lapin <[email protected]>
> shane wang <[email protected]>
> simon arlott <[email protected]>
> simon kelley <[email protected]>
> sorbica shieh <[email protected]>
> srinivas kandagatla <[email protected]>
> stefan eletzhofer <[email protected]>
> stefano brivio <[email protected]>
> steve french <[email protected]>
> steve sakoman <[email protected]>
> steve underwood <[email protected]>
> steve wise <[email protected]>
> subbu seetharaman <[email protected]>
> sudarsana kalluru <[email protected]>
> sujith thomas <[email protected]>
> teddy wang <[email protected]>
> terje bergstr?m <[email protected]>
> thibaut varene <[email protected]>
> thomas dahlmann <[email protected]>
> thomas winischhofer <[email protected]>
> "tigran a. aivazian" <[email protected]>
> tigran aivazian <[email protected]>
> till harbaum <[email protected]>
> tim small <[email protected]>
> tim waugh <[email protected]>
> tony finch <[email protected]>
> tony olech <[email protected]>
> torben mathiasen <[email protected]>
> ulrich kunitz <[email protected]>
> vegard nossum <[email protected]>
> ville syrjala <[email protected]>
> vishwas a deshpande <[email protected]>
> vitaly bordug <[email protected]>
> vitaly bordug <[email protected]>
> wensong zhang <[email protected]>
> willem riede <[email protected]>
> willy tarreau <[email protected]>
> "wong hoi sing, edison" <[email protected]>
> xavier deguillard <[email protected]>
> yokota hiroshi <[email protected]>
> zhang wei <[email protected]>
> zwane mwaikambo <[email protected]>
>
>
On Wed, 2014-07-09 at 04:14 -0700, Paul E. McKenney wrote:
> On Tue, Jul 08, 2014 at 09:09:25PM -0700, Joe Perches wrote:
[]
> > I wrote a script to find which maintainer addresses that
> > haven't signed or authored a commit in the last 2 years.
> >
> > I got ~250 entries. That's about 1/4 of all maintainer
> > email addresses.
> >
> > Maybe a dozen of these are false positives though because
> > some maintainers prefer to receive email at one address
> > but ack from another.
> >
> > These are all lowercase for better matching.
>
> I am not too surprised. There is currently no penalty for keeping a
> stale maintainer listing, and possibly severe social penalties for
> wrongly removing one. ;-)
I guess I'm not that social.
Most of these were the initial code submitters that
haven't had to change anything in quite awhile.
My suggestion is to change the below "M:" entries to "R:"
sometime after "R:" is upstream.
Maybe also change the sections that have only these names to
"S: Odd Fixes" or "S: Orphan" or add a new
"S: Unmaintained but Reviewed" section type.
This might encourage people to take over maintainership of
old code, help people figure out who better to send a patch
to and maybe who's more likely to apply it.
Also reviewer ack's aren't an indication that an upstream
maintainer will pick it up and push it forward.
To Peter's point:
On Tue, 2014-07-08 at 10:09 +0200, Peter Zijlstra wrote:
> So I would like to be able to write:
>
> SCHEDULER:
> ...
> R: Steven Rostedt <[email protected]> (kernel/sched/rt.c)
> R: Juri Lelli <[email protected]> (kernel/sched/deadline.c)
Maybe a better syntax might be something like:
R: Steven Rostedt
F: kernel/sched/rt.c
where optional F:/X: lines override the default
assumption of all F:/X: from the section.
Anyone have any comment on these inactive maintainers
that should be converted to "R:" reviewers?
> > abhijit mahajan <[email protected]>
> > achim leubner <[email protected]>
> > adam radford <[email protected]>
> > al cho <[email protected]>
> > ali akcaagac <[email protected]>
> > allan stephens <[email protected]>
> > aloisio almeida jr <[email protected]>
> > andreas dilger <[email protected]>
> > andreas koensgen <[email protected]>
> > andrew hendry <[email protected]>onl
> > andrew veliath <[email protected]>
> > andries brouwer <[email protected]>
> > andy henroid <[email protected]>
> > anil ravindranath <[email protected]>
> > anil s keshavamurthy <[email protected]>
> > antoine jacquet <[email protected]>
> > antonino daplas <[email protected]>
> > armin schindler <[email protected]>
> > artur paszkiewicz <[email protected]>
> > "arvind r." <[email protected]>
> > ashley lai <[email protected]>
> > aurelien jacquiot <[email protected]>
> > balbir singh <[email protected]>
> > bill metzenthen <[email protected]>
> > bradley grove <[email protected]>
> > brett rudley <[email protected]>
> > brian johnson <[email protected]>
> > bruce chang <[email protected]>
> > bryan huntsman <[email protected]>
> > [email protected]
> > cesar miquel <[email protected]>
> > cezary jackiewicz <[email protected]>
> > chaoming li <[email protected]>
> > chen liqin <[email protected]>
> > chien yen <[email protected]>
> > chirag kantharia <[email protected]>
> > chris brannon <[email protected]>
> > christine caulfield <[email protected]>
> > christopher harrer <[email protected]>
> > "christopher li" <[email protected]>
> > christoph raisch <[email protected]>
> > cliff whickman <[email protected]>
> > colin leroy <[email protected]>
> > corentin labbe <[email protected]>
> > daniel drake <[email protected]>
> > daniele venzano <[email protected]>
> > daniel oliveira nascimento <[email protected]>
> > daniel ribeiro <[email protected]>
> > dario ballabio <[email protected]>
> > david kershner <[email protected]>
> > david rowe <[email protected]>
> > david safford <[email protected]>
> > david t?ht <[email protected]>
> > deepak saxena <[email protected]>
> > dirk eibach <[email protected]>
> > dirk opfer <[email protected]>
> > dmitry tarnyagin <[email protected]>
> > dominik brodowski <[email protected]>
> > doug gilbert <[email protected]>
> > doug thompson <[email protected]>
> > doug warzecha <[email protected]>
> > duncan sands <[email protected]>
> > "ed l. cashin" <[email protected]>
> > egor martovetsky <[email protected]>
> > eric biederman <[email protected]>
> > eric piel <[email protected]>
> > erik andren <[email protected]>
> > faisal latif <[email protected]>
> > ferenc bakonyi <[email protected]>
> > florian schilhabel <[email protected]>.
> > forest bond <[email protected]>
> > frank seidel <[email protected]>
> > fujita tomonori <[email protected]>
> > gary zambrano <[email protected]>
> > gilles muller <[email protected]>
> > gleb natapov <[email protected]>
> > guillaume ligneul <[email protected]>
> > guo-fu tseng <[email protected]>
> > gustavo padovan <[email protected]>
> > haavard skinnemoen <[email protected]>
> > hal rosenstock <[email protected]>
> > hansjoerg lipp <[email protected]>
> > hans ulli kroll <[email protected]>
> > harald welte <[email protected]>
> > harald welte <[email protected]>
> > henk vergonet <[email protected]>
> > henrique de moraes holschuh <[email protected]>
> > herton ronaldo krzesinski <[email protected]>
> > heungjun kim <[email protected]>
> > hideaki yoshifuji <[email protected]>
> > hoang-nam nguyen <[email protected]>
> > hubert feurstein <[email protected]>
> > "hung hing lun, mike" <[email protected]>
> > ian campbell <[email protected]>
> > ian molton <[email protected]>
> > ion badulescu <[email protected]>
> > ishizaki kou <[email protected]>
> > ivan kokshaysky <[email protected]>
> > jakub schmidtke <[email protected]>
> > "james e.j. bottomley" <[email protected]>
> > "james e.j. bottomley" <[email protected]>
> > "james e.j. bottomley" <[email protected]>
> > james morris <[email protected]>
> > "james r. van zandt" <[email protected]>
> > jamie lenehan <[email protected]>
> > jan-benedict glaw <[email protected]>
> > jan dumon <[email protected]>
> > jan harkes <[email protected]>
> > jan-simon moeller <[email protected]>
> > jarkko lavinen <[email protected]>
> > jarod wilson <[email protected]>
> > jason uhlenkott <[email protected]>
> > jaya kumar <[email protected]>
> > jaya kumar <[email protected]>
> > jay cliburn <[email protected]>
> > jean-paul roubelat <[email protected]>
> > jeff dike <[email protected]>
> > jens osterkamp <[email protected]>
> > jes sorensen <[email protected]>
> > jim paris <[email protected]>
> > jiri kosina <[email protected]>
> > jiri slaby <[email protected]>
> > joerg reuter <[email protected]>
> > joern engel <[email protected]>
> > johan hedberg <[email protected]>
> > john mccutchan <[email protected]>
> > john ronciak <[email protected]>
> > "john w. linville" <[email protected]>
> > jonathan buzzard <[email protected]>
> > "jon d. mason" <[email protected]>
> > jon nettleton <[email protected]>
> > josh triplett <[email protected]>
> > joshua morris <[email protected]>
> > joshua thompson <[email protected]>
> > juanjo ciarlante <[email protected]>
> > "juergen e. fischer" <[email protected]>
> > juergen stuber <[email protected]>
> > juerg haefliger <[email protected]>
> > kentaro takeda <[email protected]>
> > kevin curtis <[email protected]>
> > kevin hilman <[email protected]>
> > kirk reiser <[email protected]>
> > koichi yasutake <[email protected]>
> > kristoffer glembo <[email protected]>
> > kurt garloff <[email protected]>
> > leandro costantino <[email protected]>
> > len brown <[email protected]>
> > lennert buytenhek <[email protected]>
> > liam girdwood <[email protected]>
> > liam girdwood <[email protected]>
> > lior dotan <[email protected]>
> > "luis r. rodriguez" <[email protected]>
> > maik broemme <[email protected]>
> > manohar vanga <[email protected]>
> > marcelo henrique cerri <[email protected]>
> > marc hulsman <[email protected]>
> > "mark f. brown" <[email protected]>
> > martin mares <[email protected]>
> > matthew wilcox <[email protected]>
> > matt mackall <[email protected]>
> > maxim krasnyansky <[email protected]>
> > michael hanselmann <[email protected]>
> > michael petchkovsky <[email protected]>
> > michael reed <[email protected]>
> > michal januszewski <[email protected]>
> > michal ostrowski <[email protected]>
> > miguel ojeda sandonis <[email protected]>
> > mikael starvik <[email protected]>
> > mike marciniszyn <[email protected]>
> > mike rapoport <[email protected]>
> > miloslav trmac <[email protected]>
> > miroslav zagorac <[email protected]>
> > mitchell blank jr <[email protected]>
> > muli ben-yehuda <[email protected]>
> > nagalakshmi nandigama <[email protected]>
> > neela syam kolli <[email protected]>
> > nelson castillo <[email protected]>
> > nicholas a. bellinger <[email protected]>
> > nick piggin <[email protected]>
> > olav kongas <[email protected]>
> > olivier lorin <[email protected]>
> > pantelis antoniou <[email protected]>
> > pat gefre <[email protected]>
> > paul mackerras <[email protected]>
> > pau oliva fora <[email protected]>
> > peter chubb <[email protected]>
> > peter feuerer <[email protected]>
> > philip blundell <[email protected]>
> > philip kelleher <[email protected]>
> > philip moltmann <[email protected]>
> > praveen krishnamoorthy <[email protected]>
> > rakesh iyer <[email protected]>
> > ranganathan desikan <[email protected]>
> > remi denis-courmont <[email protected]>
> > riccardo facchetti <[email protected]>
> > richard l maliszewski <[email protected]>
> > "richard russon (flatcap)" <[email protected]>
> > rik faith <[email protected]>
> > robert gerlach <[email protected]>
> > robert love <[email protected]>
> > robert love <[email protected]>
> > rob herring <[email protected]>
> > roland dreier <[email protected]>
> > roland mcgrath <[email protected]>
> > ron mercer <[email protected]>
> > ron minnich <[email protected]>
> > samuel chessman <[email protected]>
> > santosh raspatur <[email protected]>
> > scott murray <[email protected]>
> > sergey lapin <[email protected]>
> > shane wang <[email protected]>
> > simon arlott <[email protected]>
> > simon kelley <[email protected]>
> > sorbica shieh <[email protected]>
> > srinivas kandagatla <[email protected]>
> > stefan eletzhofer <[email protected]>
> > stefano brivio <[email protected]>
> > steve french <[email protected]>
> > steve sakoman <[email protected]>
> > steve underwood <[email protected]>
> > steve wise <[email protected]>
> > subbu seetharaman <[email protected]>
> > sudarsana kalluru <[email protected]>
> > sujith thomas <[email protected]>
> > teddy wang <[email protected]>
> > terje bergstr?m <[email protected]>
> > thibaut varene <[email protected]>
> > thomas dahlmann <[email protected]>
> > thomas winischhofer <[email protected]>
> > "tigran a. aivazian" <[email protected]>
> > tigran aivazian <[email protected]>
> > till harbaum <[email protected]>
> > tim small <[email protected]>
> > tim waugh <[email protected]>
> > tony finch <[email protected]>
> > tony olech <[email protected]>
> > torben mathiasen <[email protected]>
> > ulrich kunitz <[email protected]>
> > vegard nossum <[email protected]>
> > ville syrjala <[email protected]>
> > vishwas a deshpande <[email protected]>
> > vitaly bordug <[email protected]>
> > vitaly bordug <[email protected]>
> > wensong zhang <[email protected]>
> > willem riede <[email protected]>
> > willy tarreau <[email protected]>
> > "wong hoi sing, edison" <[email protected]>
> > xavier deguillard <[email protected]>
> > yokota hiroshi <[email protected]>
> > zhang wei <[email protected]>
> > zwane mwaikambo <[email protected]>
On Tue, Jul 08, 2014 at 09:09:25PM -0700, Joe Perches wrote:
> On Tue, 2014-07-08 at 15:25 -0700, Paul E. McKenney wrote:
> > On Tue, Jul 08, 2014 at 03:05:16PM -0700, Joe Perches wrote:
> []
> > > I still think the concept is pretty useless and it's
> > > just a duplication of "M:", which isn't anything other
> > > than a list of who should be sent patches.
> []
> > It will be interesting to see how things go.
>
> Yes, it might work out fine and maybe might cause some
> other beneficial changes.
>
> > There did seem to be
> > some people who were comfortable being listed as RCU reviewers, but
> > not as RCU maintainers. Perhaps the same thing happens elsewhere.
>
> Maybe so.
>
> I wrote a script to find which maintainer addresses that
> haven't signed or authored a commit in the last 2 years.
Did you count Acked-by or Reviewed-by lines as maintainer activity as
well?
I do see a few cases of stale email addresses in there, for active
developers who don't use the listed email address. Myself included (I
don't use @freedesktop.org anymore, though it still works). I also see
a few lists or role addresses: ceph-devel and [email protected] seem
unlikely to author commits.
> I got ~250 entries. That's about 1/4 of all maintainer
> email addresses.
>
> Maybe a dozen of these are false positives though because
> some maintainers prefer to receive email at one address
> but ack from another.
>
> These are all lowercase for better matching.
>
> abhijit mahajan <[email protected]>
> achim leubner <[email protected]>
> adam radford <[email protected]>
> al cho <[email protected]>
> ali akcaagac <[email protected]>
> allan stephens <[email protected]>
> aloisio almeida jr <[email protected]>
> andreas dilger <[email protected]>
> andreas koensgen <[email protected]>
> andrew hendry <[email protected]>
> andrew veliath <[email protected]>
> andries brouwer <[email protected]>
> andy henroid <[email protected]>
> anil ravindranath <[email protected]>
> anil s keshavamurthy <[email protected]>
> antoine jacquet <[email protected]>
> antonino daplas <[email protected]>
> armin schindler <[email protected]>
> artur paszkiewicz <[email protected]>
> "arvind r." <[email protected]>
> ashley lai <[email protected]>
> aurelien jacquiot <[email protected]>
> balbir singh <[email protected]>
> bill metzenthen <[email protected]>
> bradley grove <[email protected]>
> brett rudley <[email protected]>
> brian johnson <[email protected]>
> bruce chang <[email protected]>
> bryan huntsman <[email protected]>
> [email protected]
> cesar miquel <[email protected]>
> cezary jackiewicz <[email protected]>
> chaoming li <[email protected]>
> chen liqin <[email protected]>
> chien yen <[email protected]>
> chirag kantharia <[email protected]>
> chris brannon <[email protected]>
> christine caulfield <[email protected]>
> christopher harrer <[email protected]>
> "christopher li" <[email protected]>
> christoph raisch <[email protected]>
> cliff whickman <[email protected]>
> colin leroy <[email protected]>
> corentin labbe <[email protected]>
> daniel drake <[email protected]>
> daniele venzano <[email protected]>
> daniel oliveira nascimento <[email protected]>
> daniel ribeiro <[email protected]>
> dario ballabio <[email protected]>
> david kershner <[email protected]>
> david rowe <[email protected]>
> david safford <[email protected]>
> david t?ht <[email protected]>
> deepak saxena <[email protected]>
> dirk eibach <[email protected]>
> dirk opfer <[email protected]>
> dmitry tarnyagin <[email protected]>
> dominik brodowski <[email protected]>
> doug gilbert <[email protected]>
> doug thompson <[email protected]>
> doug warzecha <[email protected]>
> duncan sands <[email protected]>
> "ed l. cashin" <[email protected]>
> egor martovetsky <[email protected]>
> eric biederman <[email protected]>
> eric piel <[email protected]>
> erik andren <[email protected]>
> faisal latif <[email protected]>
> ferenc bakonyi <[email protected]>
> florian schilhabel <[email protected]>.
> forest bond <[email protected]>
> frank seidel <[email protected]>
> fujita tomonori <[email protected]>
> gary zambrano <[email protected]>
> gilles muller <[email protected]>
> gleb natapov <[email protected]>
> guillaume ligneul <[email protected]>
> guo-fu tseng <[email protected]>
> gustavo padovan <[email protected]>
> haavard skinnemoen <[email protected]>
> hal rosenstock <[email protected]>
> hansjoerg lipp <[email protected]>
> hans ulli kroll <[email protected]>
> harald welte <[email protected]>
> harald welte <[email protected]>
> henk vergonet <[email protected]>
> henrique de moraes holschuh <[email protected]>
> herton ronaldo krzesinski <[email protected]>
> heungjun kim <[email protected]>
> hideaki yoshifuji <[email protected]>
> hoang-nam nguyen <[email protected]>
> hubert feurstein <[email protected]>
> "hung hing lun, mike" <[email protected]>
> ian campbell <[email protected]>
> ian molton <[email protected]>
> ion badulescu <[email protected]>
> ishizaki kou <[email protected]>
> ivan kokshaysky <[email protected]>
> jakub schmidtke <[email protected]>
> "james e.j. bottomley" <[email protected]>
> "james e.j. bottomley" <[email protected]>
> "james e.j. bottomley" <[email protected]>
> james morris <[email protected]>
> "james r. van zandt" <[email protected]>
> jamie lenehan <[email protected]>
> jan-benedict glaw <[email protected]>
> jan dumon <[email protected]>
> jan harkes <[email protected]>
> jan-simon moeller <[email protected]>
> jarkko lavinen <[email protected]>
> jarod wilson <[email protected]>
> jason uhlenkott <[email protected]>
> jaya kumar <[email protected]>
> jaya kumar <[email protected]>
> jay cliburn <[email protected]>
> jean-paul roubelat <[email protected]>
> jeff dike <[email protected]>
> jens osterkamp <[email protected]>
> jes sorensen <[email protected]>
> jim paris <[email protected]>
> jiri kosina <[email protected]>
> jiri slaby <[email protected]>
> joerg reuter <[email protected]>
> joern engel <[email protected]>
> johan hedberg <[email protected]>
> john mccutchan <[email protected]>
> john ronciak <[email protected]>
> "john w. linville" <[email protected]>
> jonathan buzzard <[email protected]>
> "jon d. mason" <[email protected]>
> jon nettleton <[email protected]>
> josh triplett <[email protected]>
> joshua morris <[email protected]>
> joshua thompson <[email protected]>
> juanjo ciarlante <[email protected]>
> "juergen e. fischer" <[email protected]>
> juergen stuber <[email protected]>
> juerg haefliger <[email protected]>
> kentaro takeda <[email protected]>
> kevin curtis <[email protected]>
> kevin hilman <[email protected]>
> kirk reiser <[email protected]>
> koichi yasutake <[email protected]>
> kristoffer glembo <[email protected]>
> kurt garloff <[email protected]>
> leandro costantino <[email protected]>
> len brown <[email protected]>
> lennert buytenhek <[email protected]>
> liam girdwood <[email protected]>
> liam girdwood <[email protected]>
> lior dotan <[email protected]>
> "luis r. rodriguez" <[email protected]>
> maik broemme <[email protected]>
> manohar vanga <[email protected]>
> marcelo henrique cerri <[email protected]>
> marc hulsman <[email protected]>
> "mark f. brown" <[email protected]>
> martin mares <[email protected]>
> matthew wilcox <[email protected]>
> matt mackall <[email protected]>
> maxim krasnyansky <[email protected]>
> michael hanselmann <[email protected]>
> michael petchkovsky <[email protected]>
> michael reed <[email protected]>
> michal januszewski <[email protected]>
> michal ostrowski <[email protected]>
> miguel ojeda sandonis <[email protected]>
> mikael starvik <[email protected]>
> mike marciniszyn <[email protected]>
> mike rapoport <[email protected]>
> miloslav trmac <[email protected]>
> miroslav zagorac <[email protected]>
> mitchell blank jr <[email protected]>
> muli ben-yehuda <[email protected]>
> nagalakshmi nandigama <[email protected]>
> neela syam kolli <[email protected]>
> nelson castillo <[email protected]>
> nicholas a. bellinger <[email protected]>
> nick piggin <[email protected]>
> olav kongas <[email protected]>
> olivier lorin <[email protected]>
> pantelis antoniou <[email protected]>
> pat gefre <[email protected]>
> paul mackerras <[email protected]>
> pau oliva fora <[email protected]>
> peter chubb <[email protected]>
> peter feuerer <[email protected]>
> philip blundell <[email protected]>
> philip kelleher <[email protected]>
> philip moltmann <[email protected]>
> praveen krishnamoorthy <[email protected]>
> rakesh iyer <[email protected]>
> ranganathan desikan <[email protected]>
> remi denis-courmont <[email protected]>
> riccardo facchetti <[email protected]>
> richard l maliszewski <[email protected]>
> "richard russon (flatcap)" <[email protected]>
> rik faith <[email protected]>
> robert gerlach <[email protected]>
> robert love <[email protected]>
> robert love <[email protected]>
> rob herring <[email protected]>
> roland dreier <[email protected]>
> roland mcgrath <[email protected]>
> ron mercer <[email protected]>
> ron minnich <[email protected]>
> samuel chessman <[email protected]>
> santosh raspatur <[email protected]>
> scott murray <[email protected]>
> sergey lapin <[email protected]>
> shane wang <[email protected]>
> simon arlott <[email protected]>
> simon kelley <[email protected]>
> sorbica shieh <[email protected]>
> srinivas kandagatla <[email protected]>
> stefan eletzhofer <[email protected]>
> stefano brivio <[email protected]>
> steve french <[email protected]>
> steve sakoman <[email protected]>
> steve underwood <[email protected]>
> steve wise <[email protected]>
> subbu seetharaman <[email protected]>
> sudarsana kalluru <[email protected]>
> sujith thomas <[email protected]>
> teddy wang <[email protected]>
> terje bergstr?m <[email protected]>
> thibaut varene <[email protected]>
> thomas dahlmann <[email protected]>
> thomas winischhofer <[email protected]>
> "tigran a. aivazian" <[email protected]>
> tigran aivazian <[email protected]>
> till harbaum <[email protected]>
> tim small <[email protected]>
> tim waugh <[email protected]>
> tony finch <[email protected]>
> tony olech <[email protected]>
> torben mathiasen <[email protected]>
> ulrich kunitz <[email protected]>
> vegard nossum <[email protected]>
> ville syrjala <[email protected]>
> vishwas a deshpande <[email protected]>
> vitaly bordug <[email protected]>
> vitaly bordug <[email protected]>
> wensong zhang <[email protected]>
> willem riede <[email protected]>
> willy tarreau <[email protected]>
> "wong hoi sing, edison" <[email protected]>
> xavier deguillard <[email protected]>
> yokota hiroshi <[email protected]>
> zhang wei <[email protected]>
> zwane mwaikambo <[email protected]>
>
>
On Wed, 2014-07-09 at 10:00 -0700, [email protected] wrote:
> On Tue, Jul 08, 2014 at 09:09:25PM -0700, Joe Perches wrote:
[]
> > I wrote a script to find which maintainer addresses that
> > haven't signed or authored a commit in the last 2 years.
>
> Did you count Acked-by or Reviewed-by lines as maintainer activity as
> well?
Yes.
Anything other than a cc: line counted as activity.
On Tue, Jul 08, 2014 at 09:09:25PM -0700, Joe Perches wrote:
> On Tue, 2014-07-08 at 15:25 -0700, Paul E. McKenney wrote:
> > On Tue, Jul 08, 2014 at 03:05:16PM -0700, Joe Perches wrote:
> []
> > > I still think the concept is pretty useless and it's
> > > just a duplication of "M:", which isn't anything other
> > > than a list of who should be sent patches.
> []
> > It will be interesting to see how things go.
>
> Yes, it might work out fine and maybe might cause some
> other beneficial changes.
>
> > There did seem to be
> > some people who were comfortable being listed as RCU reviewers, but
> > not as RCU maintainers. Perhaps the same thing happens elsewhere.
>
> Maybe so.
>
> I wrote a script to find which maintainer addresses that
> haven't signed or authored a commit in the last 2 years.
>
> I got ~250 entries. That's about 1/4 of all maintainer
> email addresses.
>
> Maybe a dozen of these are false positives though because
> some maintainers prefer to receive email at one address
> but ack from another.
>
> These are all lowercase for better matching.
Aren't we all falling in the typical pessimism trap, evil of the century!
Why do we always want to consider the lack of activity from a maintainer as a bad symptom?
What if it were actually a positive sign resulting of a finished, completed, and perfect
clean bug-free subsystem?
Once we accept that, all we need is support from the MAINTAINERS file:
diff --git a/MAINTAINERS b/MAINTAINERS
index 970c4a0..5da75dd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -76,6 +76,9 @@ Descriptions of section entries:
T: SCM tree type and location.
Type is one of: git, hg, quilt, stgit, topgit
S: Status, one of the following:
+ Finished: The code is finished. The maintainer has fixed all
+ the bugs and adressed all missing features. No further
+ patch is needed.
Supported: Someone is actually paid to look after this.
Maintained: Someone actually looks after it.
Odd Fixes: It has a maintainer but they don't have time to do
On Wed, 2014-07-09 at 19:42 +0200, Frederic Weisbecker wrote:
> On Tue, Jul 08, 2014 at 09:09:25PM -0700, Joe Perches wrote:
> > On Tue, 2014-07-08 at 15:25 -0700, Paul E. McKenney wrote:
> > > On Tue, Jul 08, 2014 at 03:05:16PM -0700, Joe Perches wrote:
> > []
> > > > I still think the concept is pretty useless and it's
> > > > just a duplication of "M:", which isn't anything other
> > > > than a list of who should be sent patches.
> > []
> > > It will be interesting to see how things go.
> >
> > Yes, it might work out fine and maybe might cause some
> > other beneficial changes.
> >
> > > There did seem to be
> > > some people who were comfortable being listed as RCU reviewers, but
> > > not as RCU maintainers. Perhaps the same thing happens elsewhere.
> >
> > Maybe so.
> >
> > I wrote a script to find which maintainer addresses that
> > haven't signed or authored a commit in the last 2 years.
> >
> > I got ~250 entries. That's about 1/4 of all maintainer
> > email addresses.
> >
> > Maybe a dozen of these are false positives though because
> > some maintainers prefer to receive email at one address
> > but ack from another.
> >
> > These are all lowercase for better matching.
>
> Aren't we all falling in the typical pessimism trap, evil of the century!
> Why do we always want to consider the lack of activity from a maintainer as a bad symptom?
> What if it were actually a positive sign resulting of a finished, completed, and perfect
> clean bug-free subsystem?
You mean "free of known defects".
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -76,6 +76,9 @@ Descriptions of section entries:
> T: SCM tree type and location.
> Type is one of: git, hg, quilt, stgit, topgit
> S: Status, one of the following:
> + Finished: The code is finished. The maintainer has fixed all
> + the bugs and adressed all missing features. No further
> + patch is needed.
Yeah, some'um like that.
But very few people are capable of writing bug-free,
"finished" code akin to Donald Knuth.
Maybe finding a bug in a section marked like that
should be worth something to the patch submitter.
Maybe:
virtual credit << bugs found
Most of those entries were for the people that
submitted the original code. Most of those too
are no longer active in linux development.
So either put them in the CREDITS file and remove
them altogether from MAINTAINERS or maybe mark them
as reviewers instead of maintainers.
btw: Here's a slightly cleaned up version of the
script I used
$ cat find_active_maintainers.sh
#!/bin/bash
git log --since=2-years-ago | tr [:upper:] [:lower:] > git.commit.log
git grep -E "^M:" MAINTAINERS | tr [:upper:] [:lower:] | cut -d: -f3- | \
sort | uniq | sed -r 's/^\s+//' > maintainer.addresses
cat maintainer.addresses |
while read entry ; do
email=$(echo $entry | sed -r -e 's/^[^<]*<//' -e 's/>.*//')
echo "---> $entry email --> $email"
grep -P "^\s*(?:author:|[\w\-]+by:).*\b$email\b" git.commit.log | \
sed -r -e 's/^\s+//' -e 's/>.*/>/' -e 's/\s+/ /g' | \
sort | uniq -c
done
On Wed, Jul 09, 2014 at 06:23:22AM -0700, Joe Perches wrote:
> > SCHEDULER:
> > ...
> > R: Steven Rostedt <[email protected]> (kernel/sched/rt.c)
> > R: Juri Lelli <[email protected]> (kernel/sched/deadline.c)
>
> Maybe a better syntax might be something like:
> R: Steven Rostedt
> F: kernel/sched/rt.c
>
> where optional F:/X: lines override the default
> assumption of all F:/X: from the section.
Would RF: make sense? Instead of the indenting.
On Thu, 2014-07-10 at 11:39 +0200, Peter Zijlstra wrote:
> On Wed, Jul 09, 2014 at 06:23:22AM -0700, Joe Perches wrote:
> > > SCHEDULER:
> > > ...
> > > R: Steven Rostedt <[email protected]> (kernel/sched/rt.c)
> > > R: Juri Lelli <[email protected]> (kernel/sched/deadline.c)
> >
> > Maybe a better syntax might be something like:
> > R: Steven Rostedt
> > F: kernel/sched/rt.c
> >
> > where optional F:/X: lines override the default
> > assumption of all F:/X: from the section.
>
> Would RF: make sense? Instead of the indenting.
Maybe.
As a preface:
I doubt the need for associating a subset of the files
patterns for a subsystem with a particular reviewer.
If a reviewer is interested enough in a subsystem to
volunteer to read patches then that reviewer likely won't
be overburdened by getting a few more emailed patches
that may be outside a scope of interest.
To answer the question:
If it's done, there needs to be some mechanism to
associate a particular reviewer and the files.
Ordering of "letter:" types in MAINTAINERS is currently
unstructured.
Given a desire to have more than one reviewer interested
in different files, any subset use will either impose some
ordering requirement on the file list or some association
with the reviewer and the reviewer's file patterns of interest.
On Thu, Jul 10, 2014 at 03:00:12AM -0700, Joe Perches wrote:
> On Thu, 2014-07-10 at 11:39 +0200, Peter Zijlstra wrote:
> > On Wed, Jul 09, 2014 at 06:23:22AM -0700, Joe Perches wrote:
> > > > SCHEDULER:
> > > > ...
> > > > R: Steven Rostedt <[email protected]> (kernel/sched/rt.c)
> > > > R: Juri Lelli <[email protected]> (kernel/sched/deadline.c)
> > >
> > > Maybe a better syntax might be something like:
> > > R: Steven Rostedt
> > > F: kernel/sched/rt.c
> > >
> > > where optional F:/X: lines override the default
> > > assumption of all F:/X: from the section.
> >
> > Would RF: make sense? Instead of the indenting.
>
> Maybe.
>
> As a preface:
>
> I doubt the need for associating a subset of the files
> patterns for a subsystem with a particular reviewer.
>
> If a reviewer is interested enough in a subsystem to
> volunteer to read patches then that reviewer likely won't
> be overburdened by getting a few more emailed patches
> that may be outside a scope of interest.
I agree. And if a subset of files needs a separate set of maintainers
or reviewers, it doesn't seem excessive to split it into a separate
MAINTAINERS entry. For instance, if you want kernel/sched/rt.c to have
an additional set of maintainers/reviewers, just add a MAINTAINERS entry
for "SCHEDULER - REALTIME" with an appropriate "F:" line.
- Josh Triplett
On Thu, Jul 10, 2014 at 04:16:23PM -0700, [email protected] wrote:
> On Thu, Jul 10, 2014 at 03:00:12AM -0700, Joe Perches wrote:
> > On Thu, 2014-07-10 at 11:39 +0200, Peter Zijlstra wrote:
> > > On Wed, Jul 09, 2014 at 06:23:22AM -0700, Joe Perches wrote:
> > > > > SCHEDULER:
> > > > > ...
> > > > > R: Steven Rostedt <[email protected]> (kernel/sched/rt.c)
> > > > > R: Juri Lelli <[email protected]> (kernel/sched/deadline.c)
> > > >
> > > > Maybe a better syntax might be something like:
> > > > R: Steven Rostedt
> > > > F: kernel/sched/rt.c
> > > >
> > > > where optional F:/X: lines override the default
> > > > assumption of all F:/X: from the section.
> > >
> > > Would RF: make sense? Instead of the indenting.
> >
> > Maybe.
> >
> > As a preface:
> >
> > I doubt the need for associating a subset of the files
> > patterns for a subsystem with a particular reviewer.
> >
> > If a reviewer is interested enough in a subsystem to
> > volunteer to read patches then that reviewer likely won't
> > be overburdened by getting a few more emailed patches
> > that may be outside a scope of interest.
>
> I agree. And if a subset of files needs a separate set of maintainers
> or reviewers, it doesn't seem excessive to split it into a separate
> MAINTAINERS entry. For instance, if you want kernel/sched/rt.c to have
> an additional set of maintainers/reviewers, just add a MAINTAINERS entry
> for "SCHEDULER - REALTIME" with an appropriate "F:" line.
Ideally I'd want semantic boundaries, but given this all needs to be
robot parsed that's going to be a massive pain.
I guess I'm just not going to use it then. Too much hassle.