2015-12-27 11:15:24

by Ksenija Stanojevic

Subject: [PATCH 0/2] Staging: panel: Fix checkpatch warnings

Fix checkpatch.pl warnings in panel.c

Signed-off-by: Ksenija Stanojevic <[email protected]>

Ksenija Stanojevic (2):
Staging: panel: Fix line over 80 characters
Staging: panel: Remove space

drivers/staging/panel/panel.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

--
1.9.1

2015-12-27 11:16:27

by Ksenija Stanojevic

Subject: [PATCH 1/2] Staging: panel: Fix line over 80 characters

Split comment in order to fit into 80 characters per line.
Found by checkpatch.pl

Signed-off-by: Ksenija Stanojevic <[email protected]>
---
drivers/staging/panel/panel.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 79ac192..7171c5d 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -947,7 +947,9 @@ static void lcd_clear_fast_s(void)
lcd_send_serial(0x5F); /* R/W=W, RS=1 */
lcd_send_serial(' ' & 0x0F);
lcd_send_serial((' ' >> 4) & 0x0F);
- usleep_range(40, 100); /* the shortest data takes at least 40 us */
+ usleep_range(40, 100); /* the shortest data
+ * takes at least 40 us
+ */
}
spin_unlock_irq(&pprt_lock);

--
1.9.1

2015-12-27 11:17:31

by Ksenija Stanojevic

Subject: [PATCH 2/2] Staging: panel: Remove space

No space is necessary after a cast, therefore remove it.
Found by checkpatch.pl

Signed-off-by: Ksenija Stanojevic <[email protected]>
---
drivers/staging/panel/panel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 7171c5d..567b584 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1790,7 +1790,7 @@ static void phys_scan_contacts(void)
gndmask = PNL_PINPUT(r_str(pprt)) & scan_mask_i;

/* grounded inputs are signals 40-44 */
- phys_read |= (pmask_t) gndmask << 40;
+ phys_read |= (pmask_t)gndmask << 40;

if (bitmask != gndmask) {
/*
@@ -1806,7 +1806,7 @@ static void phys_scan_contacts(void)

w_dtr(pprt, oldval & ~bitval); /* enable this output */
bitmask = PNL_PINPUT(r_str(pprt)) & ~gndmask;
- phys_read |= (pmask_t) bitmask << (5 * bit);
+ phys_read |= (pmask_t)bitmask << (5 * bit);
}
w_dtr(pprt, oldval); /* disable all outputs */
}
--
1.9.1

2015-12-30 05:02:14

by Sudip Mukherjee

Subject: Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote:
> Split comment in order to fit into 80 characters per line.
> Found by checkpatch.pl
>
> Signed-off-by: Ksenija Stanojevic <[email protected]>
> ---

Instead of multiline maybe this is better:

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 79ac192..3525919 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
lcd_send_serial(0x5F); /* R/W=W, RS=1 */
lcd_send_serial(' ' & 0x0F);
lcd_send_serial((' ' >> 4) & 0x0F);
- usleep_range(40, 100); /* the shortest data takes at least 40 us */
+ /* the shortest data takes at least 40 us */
+ usleep_range(40, 100);
}
spin_unlock_irq(&pprt_lock);


regards
sudip

2015-12-30 10:13:45

by Ksenija Stanojevic

Subject: Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee
<[email protected]> wrote:
> On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote:
>> Split comment in order to fit into 80 characters per line.
>> Found by checkpatch.pl
>>
>> Signed-off-by: Ksenija Stanojevic <[email protected]>
>> ---
>
> Instead of multiline maybe this is better:
>
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> index 79ac192..3525919 100644
> --- a/drivers/staging/panel/panel.c
> +++ b/drivers/staging/panel/panel.c
> @@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
> lcd_send_serial(0x5F); /* R/W=W, RS=1 */
> lcd_send_serial(' ' & 0x0F);
> lcd_send_serial((' ' >> 4) & 0x0F);
> - usleep_range(40, 100); /* the shortest data takes at least 40 us */
> + /* the shortest data takes at least 40 us */
> + usleep_range(40, 100);
> }
> spin_unlock_irq(&pprt_lock);

It's already been done by Bijosh Thykkoottathil:
https://lkml.org/lkml/2015/12/18/681

Regards,
Ksenija

2015-12-30 11:32:23

by Sudip Mukherjee

Subject: Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

On Wed, Dec 30, 2015 at 11:13:40AM +0100, Ksenija Stanojević wrote:
> On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee
> <[email protected]> wrote:
> > On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote:
> >> Split comment in order to fit into 80 characters per line.
> >> Found by checkpatch.pl
> >>
> >> Signed-off-by: Ksenija Stanojevic <[email protected]>
> >> ---
> >
> > Instead of multiline maybe this is better:
> >
> > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> > index 79ac192..3525919 100644
> > --- a/drivers/staging/panel/panel.c
> > +++ b/drivers/staging/panel/panel.c
> > @@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
> > lcd_send_serial(0x5F); /* R/W=W, RS=1 */
> > lcd_send_serial(' ' & 0x0F);
> > lcd_send_serial((' ' >> 4) & 0x0F);
> > - usleep_range(40, 100); /* the shortest data takes at least 40 us */
> > + /* the shortest data takes at least 40 us */
> > + usleep_range(40, 100);
> > }
> > spin_unlock_irq(&pprt_lock);
>
> It's already been done by Bijosh Thykkoottathil:
> https://lkml.org/lkml/2015/12/18/681

But I think not yet accepted by Greg. And his commit message doesnot
mention what coding style errors he has fixed. Usually Greg will not
accept them.

regards
sudip