2016-04-15 23:51:39

by Paul E. McKenney

[permalink] [raw]
Subject: Isolated expedited RCU code to a new tree_exp.h

Hello, Frederic,

One thing that I have had on my list for some time is to rearrange the
RCU source code to make it easier to find things. Given our discussion
yesterday, this seemed like a good time to take that step with the
expedited grace-period code. I have a couple of commits doing this in
-rcu, and would like your opinion. Worthwhile, or should I revert those
two commits?

Thanx, Paul


2016-04-16 13:08:39

by Frederic Weisbecker

[permalink] [raw]
Subject: Re: Isolated expedited RCU code to a new tree_exp.h

On Fri, Apr 15, 2016 at 04:52:02PM -0700, Paul E. McKenney wrote:
> Hello, Frederic,
>
> One thing that I have had on my list for some time is to rearrange the
> RCU source code to make it easier to find things. Given our discussion
> yesterday, this seemed like a good time to take that step with the
> expedited grace-period code. I have a couple of commits doing this in
> -rcu, and would like your opinion. Worthwhile, or should I revert those
> two commits?

It's definetly worth having a look! And it might help me eventually understand
that expedited grace period thing :-)

Thanks!

2016-04-16 15:29:13

by Mathieu Desnoyers

[permalink] [raw]
Subject: Re: Isolated expedited RCU code to a new tree_exp.h

----- On Apr 16, 2016, at 9:08 AM, Frederic Weisbecker [email protected] wrote:

> On Fri, Apr 15, 2016 at 04:52:02PM -0700, Paul E. McKenney wrote:
>> Hello, Frederic,
>>
>> One thing that I have had on my list for some time is to rearrange the
>> RCU source code to make it easier to find things. Given our discussion
>> yesterday, this seemed like a good time to take that step with the
>> expedited grace-period code. I have a couple of commits doing this in
>> -rcu, and would like your opinion. Worthwhile, or should I revert those
>> two commits?
>
> It's definetly worth having a look! And it might help me eventually understand
> that expedited grace period thing :-)

Moving the expedited handling into its own files indeed
seems to better organize the sub-parts of RCU. That seems
like a good idea.

Thanks,

Mathieu


--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

2016-04-17 02:34:38

by Paul E. McKenney

[permalink] [raw]
Subject: Re: Isolated expedited RCU code to a new tree_exp.h

On Sat, Apr 16, 2016 at 03:29:09PM +0000, Mathieu Desnoyers wrote:
> ----- On Apr 16, 2016, at 9:08 AM, Frederic Weisbecker [email protected] wrote:
>
> > On Fri, Apr 15, 2016 at 04:52:02PM -0700, Paul E. McKenney wrote:
> >> Hello, Frederic,
> >>
> >> One thing that I have had on my list for some time is to rearrange the
> >> RCU source code to make it easier to find things. Given our discussion
> >> yesterday, this seemed like a good time to take that step with the
> >> expedited grace-period code. I have a couple of commits doing this in
> >> -rcu, and would like your opinion. Worthwhile, or should I revert those
> >> two commits?
> >
> > It's definetly worth having a look! And it might help me eventually understand
> > that expedited grace period thing :-)

And for me to document it. ;-)

> Moving the expedited handling into its own files indeed
> seems to better organize the sub-parts of RCU. That seems
> like a good idea.

Sounds good, will give it a try. If it works well, I might do the same
for other sub-parts of RCU.

Thanx, Paul